Fix a bug in which set_params was overwritting existing priors. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleeman
force-pushed
the
fix_set_params_bug
branch
from
198ef57 to
bb81059
Compare
Also adds several tests that weren't being run :)
akleeman
force-pushed
the
fix_set_params_bug
branch
from
bb81059 to
6203305
Compare
more consistent.
akleeman
force-pushed
the
fix_set_params_bug
branch
from
6203305 to
a1f9040
Compare
This was referenced Dec 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in which
set_paramswas overwritting existing priors.The fix was accomplished by adding a new method
set_param_valueswhich can be used to set only the values and not the priors.Also adds several tests that weren't being run :) oops!