Typos: test/* (misc folders in test)
#75033
Conversation
Sajjon
requested review from
a team,
ahoppen,
bnbarham,
hamishknight,
rintaro,
hborla,
slavapestov,
xedin,
artemcm,
jckarter,
CodaFi,
DougGregor and
adrian-prantl
as code owners
|
@swift-ci please smoke test |
|
@bnbarham @AnthonyLatsis Sorry for downtime, I was on vacation, but back now. I've squashed and applied changes on top of main ( commit: 906efcb ) Anything I need to do to get this merged? |
|
@swift-ci Please smoke test |
|
@AnthonyLatsis thanks for the help! I've reverted/fixed your suggestions by amending the commit; 
Let me know if there is anything else needed to be done! |
|
@swift-ci Please smoke test |
This comment has been minimized.
This comment has been minimized.
| @@ -173,7 +173,7 @@ func rdar21080030() { | |||
| if s.count() == 0 {} // expected-error {{cannot call value of non-function type 'Int'}} | |||
| } | |||
|
|
|||
| // <rdar://problem/21248136> QoI: problem with return type inference mis-diagnosed as invalid arguments | |||
| // <rdar://problem/21248136> QoI: problem with return type inference misdiagnosed as invalid arguments | |||
There was a problem hiding this comment.
Please leave the spelling here alone, as you can't rename the record it refers to.
| @@ -2,7 +2,7 @@ | |||
| if 'asserts' not in config.available_features: | |||
| config.unsupported = True | |||
|
|
|||
| config.subsitutions = list(config.substitutions) | |||
| config.substitutions = list(config.substitutions) | |||
There was a problem hiding this comment.
This might cause a change in behavior. Are we certain it's correct?
There was a problem hiding this comment.
Looks very much like a typo in a line that did not prove necessary.
@compnerd Do we need this line removed or corrected?
| @@ -93,10 +93,10 @@ struct UnavailableType { | |||
| var storedClosure: Int = { .random() ? 0 : 1 }() | |||
|
|
|||
| @Wrapper | |||
| var wrappered = .random() ? 0 : 1 | |||
| var wrapped = .random() ? 0 : 1 | |||
There was a problem hiding this comment.
I'm probably being too paranoid, but the identifier wrapped is, in some really specific cases, special for property wrappers. I don't think it means anything special here, but out of an abundance of caution I'd be more comfortable giving this a name that completely avoids that problem, like wrappedProperty.
Fix typos in
test/*((misc folders in test)This is one batch of many PRs fixing typos, see the tracking issue.