-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comprehensive F extension support with SoftFloat integration #260
Conversation
f18fed7
to
311a100
Compare
Is it possible to use git submodule instead of copying SoftFloat files in this repository? |
I would like to revoke my opinion on the implementation of the RISC-V F extension. Integrating SoftFloat would achieve full compatibility and reduce maintenance efforts. There is no need to retain the original RV32F-specific code. That means the conditional build between the original and SoftFloat-specific code can be removed, and let's focus on SoftFloat. |
Currently, I've copied all files as I added additional files in the SoftFloat folder to comply with the risc-v F extension standard. Perhaps we can explore alternatives, such as copying these files into the SoftFloat directory during compilation. |
Sounds like a good idea, I'll make the change later. |
To incorporate external source code, please refer to the |
311a100
to
6fee4fb
Compare
Can you review |
84f93ac
to
d31e18c
Compare
We can remove the is_snan function as the softfloat library already provides the same functionality with isSignalingNaN. However, the rest of the content needs to be retained. Additionally, I'm considering whether renaming src/softfloat.h could prevent confusion. |
I'm uncertain why the current code is failing the Codacy Security Scan test. |
It seems that something is wrong with Docker Hub. |
d31e18c
to
22decfc
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
22decfc
to
27f3da2
Compare
When rv32emu is built without F extension, i.e.,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix build without F extension support.
This commit integrate the SoftFloat library into rv32emu, enabling comprehensive support for the F extension. The inclusion of SoftFloat ensures the complete implementation of F extension functionality within rv32emu, meeting the necessary standards and providing enhanced capability for floating-point operations.
27f3da2
to
9ebd8fa
Compare
Apologies for the error. I've corrected it. It should be resolved now. |
Thank @visitorckw for contributing! |
This PR aimed at achieving full F extension support within rv32emu. It incorporates the SoftFloat open-source library into the rv32emu project to provide comprehensive support for the F extension.
The key changes in this PR include:
Close: #78