feat(protocol): major protocol upgrade for alpha-3 testnet #13640

dantaik · 2023-04-23T13:50:53Z

test/TaikoL1LibTokenomicsTestnet.t.sol:TaikoL1WithTestnetConfig

Function Name	min	avg	median	max	# calls
proposeBlock	24976	70459	90776	104876	325
proveBlock	20066	84091	107966	155305	315
verifyBlocks	6026	14783	14748	23548	325

Co-authored-by: Jeffery Walsh <cyberhorsey@gmail.com> Co-authored-by: David <david@taiko.xyz> Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com> Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com> Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com> Co-authored-by: D <51912515+adaki2004@users.noreply.github.com> Co-authored-by: Keszey Dániel <keszeyd@MacBook-Pro.local> Co-authored-by: adaki2004 <keszeydani@gmail.com> Co-authored-by: Daniel Wang <dong77@gmail.com>

codecov · 2023-04-23T13:54:01Z

Codecov Report

Merging #13640 (f8c1797) into main (dda27cd) will increase coverage by 5.31%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main   #13640      +/-   ##
==========================================
+ Coverage   39.51%   44.82%   +5.31%     
==========================================
  Files         135      132       -3     
  Lines        4042     3534     -508     
  Branches      506      368     -138     
==========================================
- Hits         1597     1584      -13     
+ Misses       2341     1849     -492     
+ Partials      104      101       -3

Flag	Coverage Δ		*Carryforward flag
bridge-ui	`95.61% <80.00%> (-0.20%)`	⬇️
eventindexer	`82.08% <ø> (ø)`
protocol	`0.00% <0.00%> (ø)`		Carriedforward from bd203f3
relayer	`62.55% <ø> (+0.02%)`	⬆️
ui	`100.00% <ø> (ø)`		Carriedforward from bd203f3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
packages/bridge-ui/src/bridge/ERC20Bridge.ts	`88.88% <ø> (ø)`
...ges/bridge-ui/src/constants/abi/ICrossChainSync.ts	`100.00% <ø> (ø)`
packages/protocol/contracts/L1/TaikoL1.sol	`0.00% <ø> (ø)`
packages/protocol/contracts/L1/TaikoToken.sol	`0.00% <ø> (ø)`
...ckages/protocol/contracts/L1/libs/LibProposing.sol	`0.00% <ø> (ø)`
packages/protocol/contracts/L1/libs/LibProving.sol	`0.00% <0.00%> (ø)`
packages/protocol/contracts/L1/libs/LibUtils.sol	`0.00% <ø> (ø)`
...ckages/protocol/contracts/L1/libs/LibVerifying.sol	`0.00% <ø> (ø)`
packages/protocol/contracts/L2/TaikoL2.sol	`0.00% <ø> (ø)`
packages/protocol/contracts/bridge/Bridge.sol	`0.00% <ø> (ø)`
... and 28 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

)

…to major protocol upgrade (#13643) Co-authored-by: David <david@taiko.xyz>

Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>

This reverts commit f338783.

…om one (#13651) Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>

Brechtpd

Only some nitpicks and suggestions.

packages/protocol/contracts/L1/TaikoL1.sol

packages/protocol/contracts/L1/libs/LibUtils.sol

packages/protocol/contracts/L1/libs/LibProving.sol

packages/protocol/contracts/L1/libs/LibTokenomics.sol

packages/protocol/contracts/L1/TaikoData.sol

packages/protocol/contracts/L1/TaikoToken.sol

packages/protocol/contracts/L2/TaikoL2.sol

packages/protocol/contracts/signal/SignalService.sol

cyberhorsey · 2023-05-03T00:27:37Z

I approved this PR because it changed 296 files, and is so big, we will never go back to what is in main over this. It needs to be merged.

Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>

dantaik · 2023-05-03T01:29:40Z

Will fix all comments today for another review.

Co-authored-by: adaki2004 <keszeydani@gmail.com> Co-authored-by: Dani <51912515+adaki2004@users.noreply.github.com>

Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>

dantaik · 2023-05-03T02:07:32Z

READY for review again.

Co-authored-by: Jeffery Walsh <cyberhorsey@gmail.com> Co-authored-by: David <david@taiko.xyz> Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com> Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com> Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com> Co-authored-by: D <51912515+adaki2004@users.noreply.github.com> Co-authored-by: Keszey Dániel <keszeyd@MacBook-Pro.local> Co-authored-by: adaki2004 <keszeydani@gmail.com> Co-authored-by: Daniel Wang <dong77@gmail.com> Co-authored-by: Francisco Ramos <jscriptcoder@gmail.com>

dantaik requested review from cyberhorsey, davidtaikocha, Brechtpd and adaki2004 and removed request for cyberhorsey April 23, 2023 13:51

dantaik self-assigned this Apr 23, 2023

dantaik marked this pull request as ready for review April 23, 2023 13:51

vercel bot deployed to Preview April 23, 2023 13:51 View deployment

dantaik enabled auto-merge April 23, 2023 13:51

cyberhorsey and others added 2 commits April 23, 2023 12:54

Merge branch 'main' into major_protocol_upgrade_alpha3

642858f

test(protocol): Add foundry tests for TaikoToken (#13641)

e40a852

johntaiko mentioned this pull request Apr 24, 2023

In-circuit anchor transaction checks taikoxyz/zkevm-circuits#67

Closed

do some cleanup

5ee7788

vercel bot deployed to Preview April 24, 2023 12:51 View deployment

dantaik added the area.protocol label Apr 24, 2023

adaki2004 and others added 2 commits April 24, 2023 22:26

test(protocol): More tests and remove redundant revert statement (#13642

8eb9f1a

)

do some cleanup

572153b

vercel bot deployed to Preview April 24, 2023 14:50 View deployment

cyberhorsey and others added 4 commits April 24, 2023 14:37

feat(protocol): eventindexer/relayer/status-page/bridge-ui caught up …

ee8e875

…to major protocol upgrade (#13643) Co-authored-by: David <david@taiko.xyz>

feat(protocol): update ANCHOR_GAS_COST (#13645)

38497a5

fix(protocol): Rm unused config (#13644)

8ebd2ce

Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>

refactor(protocol): additional cleaning up (#13646)

a1fc8b1

vercel bot deployed to Preview April 25, 2023 12:36 View deployment

cyberhorsey and others added 4 commits April 25, 2023 13:07

oracle prover bug

f338783

Revert "oracle prover bug"

848fa36

This reverts commit f338783.

fix oracle proving bug

bd800a3

feat(protocol): Remove non-working FoundryRandom and implement a cust…

eee153c

…om one (#13651) Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>

vercel bot deployed to Preview May 2, 2023 13:23 View deployment

Brechtpd previously approved these changes May 2, 2023

View reviewed changes

cyberhorsey previously approved these changes May 3, 2023

View reviewed changes

Update packages/protocol/contracts/L1/TaikoL1.sol

9636c64

Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>

dantaik dismissed stale reviews from cyberhorsey and Brechtpd via 9636c64 May 3, 2023 01:27

dantaik and others added 4 commits May 3, 2023 09:27

Update packages/protocol/contracts/L1/libs/LibProving.sol

1fe7078

Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>

Update packages/protocol/contracts/L1/libs/LibTokenomics.sol

758a162

Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>

Update packages/protocol/contracts/L2/TaikoL2.sol

fb877ed

Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>

Update packages/protocol/contracts/L1/TaikoL1.sol

3b1fd49

Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>

feat(protocol): prevent oracle prover overriding the same proof (#13681)

029ba8c

Co-authored-by: adaki2004 <keszeydani@gmail.com> Co-authored-by: Dani <51912515+adaki2004@users.noreply.github.com>

vercel bot deployed to Preview May 3, 2023 01:31 View deployment

dantaik and others added 2 commits May 3, 2023 09:40

Update packages/protocol/contracts/L1/libs/LibTokenomics.sol

bd203f3

Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>

cleanup

f8c1797

vercel bot deployed to Preview May 3, 2023 02:06 View deployment

dantaik requested review from d1onys1us, Brechtpd, cyberhorsey and davidtaikocha May 3, 2023 02:07

davidtaikocha approved these changes May 3, 2023

View reviewed changes

Brechtpd approved these changes May 3, 2023

View reviewed changes

dantaik added this pull request to the merge queue May 3, 2023

Merged via the queue into main with commit 02552f2 May 3, 2023

dantaik deleted the major_protocol_upgrade_alpha3 branch May 3, 2023 02:27

github-actions bot mentioned this pull request May 4, 2023

chore: release main #13687

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(protocol): major protocol upgrade for alpha-3 testnet #13640

feat(protocol): major protocol upgrade for alpha-3 testnet #13640

dantaik commented Apr 23, 2023 •

edited

Loading

codecov bot commented Apr 23, 2023 •

edited

Loading

Brechtpd left a comment

cyberhorsey commented May 3, 2023

dantaik commented May 3, 2023

dantaik commented May 3, 2023

feat(protocol): major protocol upgrade for alpha-3 testnet #13640

feat(protocol): major protocol upgrade for alpha-3 testnet #13640

Conversation

dantaik commented Apr 23, 2023 • edited Loading

test/TaikoL1LibTokenomicsTestnet.t.sol:TaikoL1WithTestnetConfig

codecov bot commented Apr 23, 2023 • edited Loading

Codecov Report

Brechtpd left a comment

Choose a reason for hiding this comment

cyberhorsey commented May 3, 2023

dantaik commented May 3, 2023

dantaik commented May 3, 2023

dantaik commented Apr 23, 2023 •

edited

Loading

codecov bot commented Apr 23, 2023 •

edited

Loading