feat(protocol): major protocol upgrade #13389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeffery Walsh <cyberhorsey@gmail.com> Co-authored-by: David <david@taiko.xyz> Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com> Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com> Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com> Co-authored-by: D <51912515+adaki2004@users.noreply.github.com> Co-authored-by: Keszey Dániel <keszeyd@MacBook-Pro.local>
Codecov Report
@@ Coverage Diff @@
## major_protocol_upgrade_alpha3 #13389 +/- ##
=================================================================
+ Coverage 39.47% 44.91% +5.44%
=================================================================
Files 135 133 -2
Lines 4043 3553 -490
Branches 506 363 -143
=================================================================
Hits 1596 1596
+ Misses 2343 1853 -490
Partials 104 104
*This pull request uses carry forward flags. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dantaik
requested review from
cyberhorsey,
dionysuzx,
davidtaikocha,
adaki2004,
Brechtpd and
jscriptcoder
adaki2004
reviewed
Mar 22, 2023
Brechtpd
reviewed
Mar 22, 2023
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
Co-authored-by: adaki2004 <keszeydani@gmail.com>
Co-authored-by: David <david@taiko.xyz>
cyberhorsey
reviewed
Apr 22, 2023
| if (ethVault != address(0)) { | ||
| ethVault.sendEther(message.callValue); | ||
| } | ||
| ethVault.sendEther(message.callValue); |
There was a problem hiding this comment.
do we not burn the message.callValue now, because ethVault can be 0 address?
…#13489) Co-authored-by: Daniel Wang <dan@taiko.xyz> Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
…t [1] (#13617) Co-authored-by: adaki2004 <keszeydani@gmail.com> Co-authored-by: Dani <51912515+adaki2004@users.noreply.github.com>
Co-authored-by: adaki2004 <keszeydani@gmail.com> Co-authored-by: David <david@taiko.xyz> Co-authored-by: Dani <51912515+adaki2004@users.noreply.github.com>
Co-authored-by: adaki2004 <keszeydani@gmail.com> Co-authored-by: David <david@taiko.xyz> Co-authored-by: Dani <51912515+adaki2004@users.noreply.github.com>
Co-authored-by: Daniel Wang <dan@taiko.xyz> Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
dantaik
changed the title
auto-merge was automatically disabled
April 23, 2023 13:44
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR rebased on top of PR #13254. If any comments are not resolved there, we will continue to discuss there but new changes will be applied to this PR.
Major Changes:
string.concatandbytes.concatinstead of abi.encodePacked/abi.encodeconfig.rewardMultiplierPctgtoconfig.feeMultiplierPctgto be consistent with other config vars.getTimeAdjustedFeeTaikoL1.init()unchecked-- Need your careful review and feedback