Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue when releasing from a LTS branch #4

Closed
samoht opened this issue Apr 13, 2018 · 0 comments
Closed

Issue when releasing from a LTS branch #4

samoht opened this issue Apr 13, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@samoht
Copy link
Contributor

samoht commented Apr 13, 2018 •
edited
Loading

If the tag we are using while doing dune-release publish submit is not at the tip of master, toy-github-delegate (or its equivalent, eg. Dune_release.Github.publish_distrib) becomes confused a creates a new release on the wrong commit..
@samoht samoht mentioned this issue Jun 7, 2018
Merged
@samoht samoht added the bug Something isn't working label Jun 7, 2018
@samoht samoht closed this as completed Jun 7, 2018
samoht added a commit to samoht/opam-repository that referenced this issue Jun 8, 2018
@samoht
[new release] dune-release (0.2.0)
5604ed6 
CHANGES:

- Remove opam lint warnings for 1.2 files (tarides/dune-release#2, @samoht)
- Add a `--keep-v` option to not drop `v` at the beginning of version
  numbers (tarides/dune-release#6, @samoht)
- Pass `-p <package>` to jbuilder (tarides/dune-release#8, @diml)
- Fix a bug in `Distrib.write_subst` which could cause an infinite loop
  (tarides/dune-release#10, @diml)
- Add a `--dry-run` option to avoid side-effects for all commands (@samoht)
- Rewrite issues numbers in changelog to point to the right repository
  (tarides/dune-release#13, @samoht)
- Stop force pushing tags to `origin`. Instead, just force push the release
  tag directly to the `dev-repo` repository (@samoht)
- Fix publishing distribution when the the tag to publish is not the repository
  HEAD (tarides/dune-release#4, @samoht)
- Do not depend on `opam-publish` anymore. Use configuration files stored
  in `~/.dune` to parametrise the publishing workflow. (@samoht)
@samoht samoht mentioned this issue Jun 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samoht