Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure because jbuilder is not picking the right root #8

Closed
ghost opened this issue Apr 25, 2018 · 0 comments
Closed

Build failure because jbuilder is not picking the right root #8

ghost opened this issue Apr 25, 2018 · 0 comments

Comments

@ghost
Copy link

ghost commented Apr 25, 2018

Step to reproduce:

$ git clone https://github.com/janestreet/spawn.git
$ cd spawn
$ dune-release distrib
[...]
<failure because jbuilder picks up the wrong workspace root>

I think all the calls to jbuilder should have -p <package> to make sure they are reproducible, i.e.:

  • they don't read the user configuration file
  • the root is wherever jbuilder is started
  • ...
@ghost ghost mentioned this issue Apr 25, 2018
Merged
@samoht samoht closed this as completed in #9 Apr 25, 2018
samoht added a commit to samoht/opam-repository that referenced this issue Jun 8, 2018
@samoht
[new release] dune-release (0.2.0)
5604ed6 
CHANGES:

- Remove opam lint warnings for 1.2 files (tarides/dune-release#2, @samoht)
- Add a `--keep-v` option to not drop `v` at the beginning of version
  numbers (tarides/dune-release#6, @samoht)
- Pass `-p <package>` to jbuilder (tarides/dune-release#8, @diml)
- Fix a bug in `Distrib.write_subst` which could cause an infinite loop
  (tarides/dune-release#10, @diml)
- Add a `--dry-run` option to avoid side-effects for all commands (@samoht)
- Rewrite issues numbers in changelog to point to the right repository
  (tarides/dune-release#13, @samoht)
- Stop force pushing tags to `origin`. Instead, just force push the release
  tag directly to the `dev-repo` repository (@samoht)
- Fix publishing distribution when the the tag to publish is not the repository
  HEAD (tarides/dune-release#4, @samoht)
- Do not depend on `opam-publish` anymore. Use configuration files stored
  in `~/.dune` to parametrise the publishing workflow. (@samoht)
@samoht samoht mentioned this issue Jun 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants