Remove delegates #428
Merged
Remove delegates #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This was pretty simple and straightforward, I think most of the work will be improving a bit how we detect whether the packages are hosted on github and where. This still uses homepage, I believe to mimic what delegates were doing. We don't need to do this anymore! |
NathanReb
force-pushed
the
remove-delegates
branch
from
f13026c to
c248c7f
Compare
|
We need to fix Cmdliner's warning first! |
pitag-ha
reviewed
Feb 10, 2022
There was a problem hiding this comment.
Yessss, thank you! Looks all good to me (although I agree that we should release before merging this). I've had a look at our API (the man pages) with your change and I don't see any left-overs from delegates in there. The only nitpick might be that in help release, you could also change "WWW" for "github" when referring to publish, also for consistency with the rest of your changes.
This still uses homepage, I believe to mimic what delegates were doing. We don't need to do this anymore!
Which is also awesome!
|
Looks like @NathanReb released 1.6.0 with all the remaining pre-2.0 changes and it got merged to opam-repository ocaml/opam-repository#20714 so we are free to merge changes for a 2.0.0 release now 🎉 |
|
I'll rebase on #429 so we can see the CI! |
|
#429 has been merged and we released 1.6.1 with the fix since some people needed these fixes. |
NathanReb
force-pushed
the
remove-delegates
branch
from
c248c7f to
eb701f1
Compare
Leonidas-from-XIV
approved these changes
Mar 2, 2022
NathanReb
force-pushed
the
remove-delegates
branch
2 times, most recently
from
b97dfd8 to
fc01eab
Compare
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
force-pushed
the
remove-delegates
branch
from
fc01eab to
7d0e129
Compare
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Jun 22, 2023
CHANGES: ### Added - Adopt the OCaml Code of Conduct (tarides/dune-release#473, @rikusilvola) - Added support for projects that have their OPAM files in the `opam/` subdirectory. (tarides/dune-release#466, @Leonidas-from-XIV) ### Changed - Running `dune-release check` now attempts to discover and parse the change log, and a new flag `--skip-change-log` disables this behaviour. (tarides/dune-release#458, @gridbugs) - List the main package and amount of subpackages when creating the PR to avoid very long package lists in PRs (tarides/dune-release#465, @emillon) ### Fixed - Avoid collision between branch and tag name. Tag detection got confused when branch was named the same as tag. Now it searches only for tag refs, instead of all refs. (tarides/dune-release#452, @3Rafal) - Fix project name detection from `dune-project`. The parser could get confused when opam file generation is used. Now it only considers the first `(name X)` in the file. (tarides/dune-release#445, @emillon) ### Removed - Remove support for delegates. Previous users of this feature should now use `dune-release delegate-info` and wrap dune-release calls in a script. See tarides/dune-release#188 for details. (tarides/dune-release#428, @NathanReb) - Removed support for the OPAM 1.2.2 client. This means `dune-release` expects the `opam` binary to be version 2.0 at least. (tarides/dune-release#406, tarides/dune-release#411, @Leonidas-from-XIV)
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Jun 23, 2023
CHANGES: ### Added - Adopt the OCaml Code of Conduct (tarides/dune-release#473, @rikusilvola) - Added support for projects that have their OPAM files in the `opam/` subdirectory. (tarides/dune-release#466, @Leonidas-from-XIV) ### Changed - Running `dune-release check` now attempts to discover and parse the change log, and a new flag `--skip-change-log` disables this behaviour. (tarides/dune-release#458, @gridbugs) - List the main package and amount of subpackages when creating the PR to avoid very long package lists in PRs (tarides/dune-release#465, @emillon) ### Fixed - Avoid collision between branch and tag name. Tag detection got confused when branch was named the same as tag. Now it searches only for tag refs, instead of all refs. (tarides/dune-release#452, @3Rafal) - Fix project name detection from `dune-project`. The parser could get confused when opam file generation is used. Now it only considers the first `(name X)` in the file. (tarides/dune-release#445, @emillon) ### Removed - Remove support for delegates. Previous users of this feature should now use `dune-release delegate-info` and wrap dune-release calls in a script. See tarides/dune-release#188 for details. (tarides/dune-release#428, @NathanReb) - Removed support for the OPAM 1.2.2 client. This means `dune-release` expects the `opam` binary to be version 2.0 at least. (tarides/dune-release#406, tarides/dune-release#411, @Leonidas-from-XIV) ### Security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
It's finally here! This is also breaking so we should release whatever we already have if we want them available under 1.x.