Add flag to dune-release check that attempts to discover and parse the change log
#458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of missing parens [check_project] would return [Ok 0] if skip_lint was set, regardless of other failures.
gridbugs
force-pushed
the
check-change-log-flag
branch
from
42183da to
dd2782f
Compare
|
Definitely an useful addition, but for a more consistent user experience I think it would make sense to flip it: add |
|
Good suggestion. Fixed! |
Leonidas-from-XIV
requested changes
Mar 17, 2023
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Jun 22, 2023
CHANGES: ### Added - Adopt the OCaml Code of Conduct (tarides/dune-release#473, @rikusilvola) - Added support for projects that have their OPAM files in the `opam/` subdirectory. (tarides/dune-release#466, @Leonidas-from-XIV) ### Changed - Running `dune-release check` now attempts to discover and parse the change log, and a new flag `--skip-change-log` disables this behaviour. (tarides/dune-release#458, @gridbugs) - List the main package and amount of subpackages when creating the PR to avoid very long package lists in PRs (tarides/dune-release#465, @emillon) ### Fixed - Avoid collision between branch and tag name. Tag detection got confused when branch was named the same as tag. Now it searches only for tag refs, instead of all refs. (tarides/dune-release#452, @3Rafal) - Fix project name detection from `dune-project`. The parser could get confused when opam file generation is used. Now it only considers the first `(name X)` in the file. (tarides/dune-release#445, @emillon) ### Removed - Remove support for delegates. Previous users of this feature should now use `dune-release delegate-info` and wrap dune-release calls in a script. See tarides/dune-release#188 for details. (tarides/dune-release#428, @NathanReb) - Removed support for the OPAM 1.2.2 client. This means `dune-release` expects the `opam` binary to be version 2.0 at least. (tarides/dune-release#406, tarides/dune-release#411, @Leonidas-from-XIV)
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Jun 23, 2023
CHANGES: ### Added - Adopt the OCaml Code of Conduct (tarides/dune-release#473, @rikusilvola) - Added support for projects that have their OPAM files in the `opam/` subdirectory. (tarides/dune-release#466, @Leonidas-from-XIV) ### Changed - Running `dune-release check` now attempts to discover and parse the change log, and a new flag `--skip-change-log` disables this behaviour. (tarides/dune-release#458, @gridbugs) - List the main package and amount of subpackages when creating the PR to avoid very long package lists in PRs (tarides/dune-release#465, @emillon) ### Fixed - Avoid collision between branch and tag name. Tag detection got confused when branch was named the same as tag. Now it searches only for tag refs, instead of all refs. (tarides/dune-release#452, @3Rafal) - Fix project name detection from `dune-project`. The parser could get confused when opam file generation is used. Now it only considers the first `(name X)` in the file. (tarides/dune-release#445, @emillon) ### Removed - Remove support for delegates. Previous users of this feature should now use `dune-release delegate-info` and wrap dune-release calls in a script. See tarides/dune-release#188 for details. (tarides/dune-release#428, @NathanReb) - Removed support for the OPAM 1.2.2 client. This means `dune-release` expects the `opam` binary to be version 2.0 at least. (tarides/dune-release#406, tarides/dune-release#411, @Leonidas-from-XIV) ### Security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that a project where
dune-release checksucceeded didn't publish because its change log failed to parse, and iterating on debugging and fixing the change log was difficult with no simple way to exercise the change log parsing logic.