-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid collision between branch and tag name #452
Conversation
7437357
to
274d13c
Compare
Hi! Thanks for your contribution! Can you add a changelog entry and Mercurial support? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, recommend to merge when CI is green.
Nice, thanks, @3Rafal! Looks good to me as well. |
@Leonidas-from-XIV , @pitag-ha |
Yup, let's goooo! Thanks again. |
CHANGES: ### Added - Adopt the OCaml Code of Conduct (tarides/dune-release#473, @rikusilvola) - Added support for projects that have their OPAM files in the `opam/` subdirectory. (tarides/dune-release#466, @Leonidas-from-XIV) ### Changed - Running `dune-release check` now attempts to discover and parse the change log, and a new flag `--skip-change-log` disables this behaviour. (tarides/dune-release#458, @gridbugs) - List the main package and amount of subpackages when creating the PR to avoid very long package lists in PRs (tarides/dune-release#465, @emillon) ### Fixed - Avoid collision between branch and tag name. Tag detection got confused when branch was named the same as tag. Now it searches only for tag refs, instead of all refs. (tarides/dune-release#452, @3Rafal) - Fix project name detection from `dune-project`. The parser could get confused when opam file generation is used. Now it only considers the first `(name X)` in the file. (tarides/dune-release#445, @emillon) ### Removed - Remove support for delegates. Previous users of this feature should now use `dune-release delegate-info` and wrap dune-release calls in a script. See tarides/dune-release#188 for details. (tarides/dune-release#428, @NathanReb) - Removed support for the OPAM 1.2.2 client. This means `dune-release` expects the `opam` binary to be version 2.0 at least. (tarides/dune-release#406, tarides/dune-release#411, @Leonidas-from-XIV)
CHANGES: ### Added - Adopt the OCaml Code of Conduct (tarides/dune-release#473, @rikusilvola) - Added support for projects that have their OPAM files in the `opam/` subdirectory. (tarides/dune-release#466, @Leonidas-from-XIV) ### Changed - Running `dune-release check` now attempts to discover and parse the change log, and a new flag `--skip-change-log` disables this behaviour. (tarides/dune-release#458, @gridbugs) - List the main package and amount of subpackages when creating the PR to avoid very long package lists in PRs (tarides/dune-release#465, @emillon) ### Fixed - Avoid collision between branch and tag name. Tag detection got confused when branch was named the same as tag. Now it searches only for tag refs, instead of all refs. (tarides/dune-release#452, @3Rafal) - Fix project name detection from `dune-project`. The parser could get confused when opam file generation is used. Now it only considers the first `(name X)` in the file. (tarides/dune-release#445, @emillon) ### Removed - Remove support for delegates. Previous users of this feature should now use `dune-release delegate-info` and wrap dune-release calls in a script. See tarides/dune-release#188 for details. (tarides/dune-release#428, @NathanReb) - Removed support for the OPAM 1.2.2 client. This means `dune-release` expects the `opam` binary to be version 2.0 at least. (tarides/dune-release#406, tarides/dune-release#411, @Leonidas-from-XIV) ### Security
This should resolve #451