incorporation localization of texts using of the library i18n #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
✅ Deploy Preview for teloscan-stage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for dev-mainnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Deploying with
|
| Latest commit: |
9c2ec6d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://da202db5.teloscan.pages.dev |
| Branch Preview URL: | https://91-add-i18n-localizations.teloscan.pages.dev |
Viterbo
changed the title
This was referenced Jan 11, 2023
Closed
|
@Viterbo check syntax in templates, text fields aren't rendering. examples: |
karynemayer
suggested changes
Jan 12, 2023
donnyquixotic
previously approved these changes
Jan 13, 2023
ezra-sg
suggested changes
Jan 13, 2023
donnyquixotic
previously approved these changes
Jan 13, 2023
|
contract tab is missing some localizations on route also the tabs there seem to be broken |
|
tx details page, route
as well as Details tab |
donnyquixotic
approved these changes
Jan 17, 2023
karynemayer
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91
Description
Telos scan needs to include internationalization and for that i18n was incorporated and all hard-coded texts were changed for a call to the $t() function with the corresponding path.
Requirements
This PR needs to be merged after merging the incorporation of the library i18n PR
Checklist: