Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Spanish (es-ES) translation #301

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Jan 11, 2023

Fixes #297

Description

This PR incorporates the translation for the Spanish language.

Blocked

This PR is blocked until merging the incorporation of the library i18n PR

Test scenarios

I changed manually the default language to 'es-ES' and then explored the site, searching for texts, labels, placeholders, tooltips, and error or notification messages that may be showing the key name instead the Spanish text associated.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages

@Viterbo Viterbo added the 🚫 Blocked Work cannot be done until blocker is resolved label Jan 11, 2023
@Viterbo Viterbo self-assigned this Jan 11, 2023
@Viterbo Viterbo linked an issue Jan 11, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit 79b2168
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/63c80992c0690b00085936c8
😎 Deploy Preview https://deploy-preview-301--dev-mainnet-teloscan.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit 79b2168
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/63c80992639344000850a9be
😎 Deploy Preview https://deploy-preview-301--teloscan-stage.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

donnyquixotic
donnyquixotic previously approved these changes Jan 11, 2023
karynemayer
karynemayer previously approved these changes Jan 12, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 79b2168
Status: ✅  Deploy successful!
Preview URL: https://3feb55f1.teloscan.pages.dev
Branch Preview URL: https://297-spanish-translation-1.teloscan.pages.dev

View logs

@Viterbo Viterbo removed the 🚫 Blocked Work cannot be done until blocker is resolved label Jan 18, 2023
@donnyquixotic donnyquixotic merged commit 1060764 into dev Jan 18, 2023
@donnyquixotic donnyquixotic deleted the 297-spanish-translation-1 branch January 18, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanish translation
3 participants