Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new option to the header menu to change the language #303

Closed
wants to merge 26 commits into from

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Jan 11, 2023

Fixes #302

Description

This PR includes a new option in the header menu to change the current language.

Blocked

This PR is blocked until merging the incorporation of the library i18n PR and at least one of the following language incorporations:

Test scenarios

  • Open the header menu
  • open the Language sub-menu
  • You should see
    • one entry for each language present
    • the current language should be selected
  • change the current selection
  • the language should change and the page should reload immediately showing the corresponding Language

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages

@Viterbo Viterbo added the 🚫 Blocked Work cannot be done until blocker is resolved label Jan 11, 2023
@Viterbo Viterbo self-assigned this Jan 11, 2023
@Viterbo Viterbo linked an issue Jan 11, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit 2f44dc7
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/63c99fd9512b330009f5a835
😎 Deploy Preview https://deploy-preview-303--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit 2f44dc7
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/63c99fd91686a900082284fc
😎 Deploy Preview https://deploy-preview-303--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

donnyquixotic
donnyquixotic previously approved these changes Jan 11, 2023
@Viterbo Viterbo marked this pull request as draft January 17, 2023 16:23
@Viterbo Viterbo removed the 🚫 Blocked Work cannot be done until blocker is resolved label Jan 17, 2023
@karynemayer karynemayer mentioned this pull request Jan 17, 2023
4 tasks
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2f44dc7
Status: ✅  Deploy successful!
Preview URL: https://0a61c3b1.teloscan.pages.dev
Branch Preview URL: https://302-we-need-a-way-the-change.teloscan.pages.dev

View logs

@Viterbo
Copy link
Collaborator Author

Viterbo commented Jan 18, 2023

@EJSG, this is a completely discardable PR but I solved the conflicts as you requested.

@Viterbo
Copy link
Collaborator Author

Viterbo commented Jan 20, 2023

I close this PR since it was solved in this PR using the new header.

@Viterbo Viterbo closed this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We need a way the change the language
4 participants