Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: removing gogoproto extensions #7718

Merged
merged 1 commit into from
Sep 10, 2024
Merged

*: removing gogoproto extensions #7718

merged 1 commit into from
Sep 10, 2024

Conversation

GiedriusS
Copy link
Member

Removed all gogoproto extensions and dealt with the changes. 2nd step in removing gogoproto.

Copy link
Contributor

@pedro-stanaka pedro-stanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this coming to fruition, would be interesting to see some benchmarks. Specially in receivers and queriers.

@GiedriusS GiedriusS force-pushed the rm_gogoproto_extensions branch 6 times, most recently from 164ff59 to 378c09f Compare September 10, 2024 11:31
Removed all gogoproto extensions and dealt with the changes. 2nd step in
removing gogoproto.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
@GiedriusS GiedriusS merged commit 97710f4 into main Sep 10, 2024
22 checks passed
@GiedriusS GiedriusS deleted the rm_gogoproto_extensions branch September 10, 2024 12:17
GiedriusS added a commit that referenced this pull request Oct 1, 2024
This reverts commit 97710f4.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS added a commit that referenced this pull request Oct 1, 2024
This reverts commit 97710f4.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS added a commit that referenced this pull request Oct 1, 2024
* Revert "store: add chunk pooling (#7771)"

This reverts commit a2113fd.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "query/store: memoize PromLabels() call (#7767)"

This reverts commit 735db72.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "store: compare labels directly (#7766)"

This reverts commit 30f453e.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "store: don't create intermediate labels (#7762)"

This reverts commit 8cd3fae.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "*: build with stringlabels (#7745)"

This reverts commit 883fade.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "*: enable gRPC pooling (#7742)"

This reverts commit ca8ab90.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "*: switch to vtprotobuf (#7721)"

This reverts commit a8e7109.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "*: removing gogoproto extensions (#7718)"

This reverts commit 97710f4.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "*: rm ZLabels (#7675)"

This reverts commit 8c8a88e.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

---------

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
jnyi pushed a commit to jnyi/thanos that referenced this pull request Oct 17, 2024
Removed all gogoproto extensions and dealt with the changes. 2nd step in
removing gogoproto.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
jnyi pushed a commit to jnyi/thanos that referenced this pull request Oct 17, 2024
* Revert "store: add chunk pooling (thanos-io#7771)"

This reverts commit a2113fd.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "query/store: memoize PromLabels() call (thanos-io#7767)"

This reverts commit 735db72.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "store: compare labels directly (thanos-io#7766)"

This reverts commit 30f453e.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "store: don't create intermediate labels (thanos-io#7762)"

This reverts commit 8cd3fae.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "*: build with stringlabels (thanos-io#7745)"

This reverts commit 883fade.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "*: enable gRPC pooling (thanos-io#7742)"

This reverts commit ca8ab90.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "*: switch to vtprotobuf (thanos-io#7721)"

This reverts commit a8e7109.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "*: removing gogoproto extensions (thanos-io#7718)"

This reverts commit 97710f4.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Revert "*: rm ZLabels (thanos-io#7675)"

This reverts commit 8c8a88e.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

---------

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants