-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: switch back to gogoproto, rm stringlabels #7790
Conversation
This reverts commit a2113fd. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
This reverts commit 735db72. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
This reverts commit 30f453e. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
This reverts commit 8cd3fae. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
This reverts commit 883fade. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
This reverts commit ca8ab90. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
This reverts commit a8e7109. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
This reverts commit 97710f4. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
e1f3dae
to
2d06594
Compare
This reverts commit 8c8a88e. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
2d06594
to
71c4ce3
Compare
I don’t know if we should revert stringlabels altogether. It is very useful for receivers which are very memory-heavy. Maybe be want |
👍 I think let's distribute two versions of Thanos so that users could run Receive with stringlabels. It's awkward but should still be helpful. I'll do that in a separate PR. |
* Revert "store: add chunk pooling (thanos-io#7771)" This reverts commit a2113fd. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "query/store: memoize PromLabels() call (thanos-io#7767)" This reverts commit 735db72. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "store: compare labels directly (thanos-io#7766)" This reverts commit 30f453e. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "store: don't create intermediate labels (thanos-io#7762)" This reverts commit 8cd3fae. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: build with stringlabels (thanos-io#7745)" This reverts commit 883fade. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: enable gRPC pooling (thanos-io#7742)" This reverts commit ca8ab90. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: switch to vtprotobuf (thanos-io#7721)" This reverts commit a8e7109. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: removing gogoproto extensions (thanos-io#7718)" This reverts commit 97710f4. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: rm ZLabels (thanos-io#7675)" This reverts commit 8c8a88e. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> --------- Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
I suggest changing course back to gogoproto. It seems to me right now that the best course of action is to focus on implementing a new RPC protocol that has zero-copy and would give us tight control of allocations/memory usage. Here are some of the reasons why I think we should do that:
[]*T
instead of[]T
. This makes sense from proto perspective but it's bad for us because it means a lot of extra allocations: not just for the data itself but also for pointers to each variable.Name/Value string
format, then we can cast with zero copies, but iflabels.Labels
is different, then we would be forced to allocate again to accommodate the custom layout.