*: build with stringlabels #7745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
commented
Sep 13, 2024
pkg/query/test_test.go
Outdated
There was a problem hiding this comment.
We need to add the option to test a queryable to the promql test framework - Ill do that in followup.
MichaHoffmann
commented
Sep 13, 2024
| @@ -91,45 +91,6 @@ func TestRetryError(t *testing.T) { | |||
| testutil.Assert(t, IsHaltError(err), "not a halt error. Retry should not hide halt error") | |||
| } | |||
|
|
|||
| func TestGroupKey(t *testing.T) { | |||
There was a problem hiding this comment.
Groupkey depends on the labels implementation, slicelabels have a different one then stringlabels.
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffmann/build-with-stringlabels
branch
from
7610378
to
67cff90
Compare
fpetkovski
approved these changes
Sep 13, 2024
saswatamcode
approved these changes
Sep 13, 2024
GiedriusS
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit 883fade. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
added a commit
that referenced
this pull request
Oct 1, 2024
* Revert "store: add chunk pooling (#7771)" This reverts commit a2113fd. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "query/store: memoize PromLabels() call (#7767)" This reverts commit 735db72. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "store: compare labels directly (#7766)" This reverts commit 30f453e. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "store: don't create intermediate labels (#7762)" This reverts commit 8cd3fae. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: build with stringlabels (#7745)" This reverts commit 883fade. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: enable gRPC pooling (#7742)" This reverts commit ca8ab90. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: switch to vtprotobuf (#7721)" This reverts commit a8e7109. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: removing gogoproto extensions (#7718)" This reverts commit 97710f4. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: rm ZLabels (#7675)" This reverts commit 8c8a88e. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> --------- Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
* Revert "store: add chunk pooling (thanos-io#7771)" This reverts commit a2113fd. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "query/store: memoize PromLabels() call (thanos-io#7767)" This reverts commit 735db72. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "store: compare labels directly (thanos-io#7766)" This reverts commit 30f453e. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "store: don't create intermediate labels (thanos-io#7762)" This reverts commit 8cd3fae. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: build with stringlabels (thanos-io#7745)" This reverts commit 883fade. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: enable gRPC pooling (thanos-io#7742)" This reverts commit ca8ab90. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: switch to vtprotobuf (thanos-io#7721)" This reverts commit a8e7109. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: removing gogoproto extensions (thanos-io#7718)" This reverts commit 97710f4. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Revert "*: rm ZLabels (thanos-io#7675)" This reverts commit 8c8a88e. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> --------- Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Finalized conversion to stringlabels
Verification