Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move uniforms to command buffer scope #55

Merged
merged 17 commits into from
Jun 27, 2024
Merged

Move uniforms to command buffer scope #55

merged 17 commits into from
Jun 27, 2024

Conversation

thatcosmonaut
Copy link
Owner

Addresses #54

Uniform data is now scoped to the command buffer. I also addressed some D3D11 implementation inconsistencies that should improve performance via the Don't Touch The Driver principle.

Needs corresponding Metal changes.

@thatcosmonaut
Copy link
Owner Author

  • Went back to a pooling strategy for uniform buffers to address situations where lots of command buffers are created and submitted (for example, when there is backpressure in immediate/mailbox mode).
  • The number of uniform slots per stage is now 4 instead of 14.
  • Uniform buffers are now 32 KiB instead of 1 MiB.

@flibitijibibo flibitijibibo self-assigned this Jun 27, 2024
@flibitijibibo flibitijibibo marked this pull request as ready for review June 27, 2024 02:25
@flibitijibibo flibitijibibo merged commit 346bc4e into gpu_next Jun 27, 2024
78 checks passed
@flibitijibibo flibitijibibo deleted the uniforms_tweak branch June 27, 2024 02:26
flibitijibibo pushed a commit that referenced this pull request Jun 28, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
d5fd70a 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Jul 6, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (thatcosmonaut#55)
cb80dd5 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
flibitijibibo pushed a commit that referenced this pull request Jul 11, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
668e96f 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Jul 12, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (thatcosmonaut#55)
79f6307 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Jul 13, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (thatcosmonaut#55)
94821ca 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
flibitijibibo pushed a commit that referenced this pull request Jul 16, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
121fdbe 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
flibitijibibo pushed a commit that referenced this pull request Jul 19, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
58300d9 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
flibitijibibo pushed a commit that referenced this pull request Jul 30, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
b7ed9f0 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Jul 30, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (thatcosmonaut#55)
611ba9b 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Aug 1, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (thatcosmonaut#55)
421d243 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Aug 1, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (thatcosmonaut#55)
7dae09a 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
flibitijibibo pushed a commit that referenced this pull request Aug 2, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
673b4c0 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
flibitijibibo pushed a commit that referenced this pull request Aug 4, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
0a40ae0 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
thatcosmonaut added a commit that referenced this pull request Aug 5, 2024
@thatcosmonaut @TheSpydog
Move uniforms to command buffer scope (#55)
38a2fb3 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
flibitijibibo pushed a commit that referenced this pull request Aug 6, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
da853c7 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
flibitijibibo pushed a commit that referenced this pull request Aug 9, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
c45a0c5 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Aug 9, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (thatcosmonaut#55)
56cd8fc 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
TheSpydog added a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Aug 17, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (thatcosmonaut#55)
d7fad4f 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
flibitijibibo pushed a commit that referenced this pull request Aug 23, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
3d1e866 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
flibitijibibo pushed a commit that referenced this pull request Aug 28, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
fe5b77b 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
flibitijibibo pushed a commit that referenced this pull request Aug 28, 2024
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (#55)
b781be5 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSpydog TheSpydog TheSpydog approved these changes

Assignees

@flibitijibibo flibitijibibo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thatcosmonaut @TheSpydog @flibitijibibo