Fixes #14188 - change pulp_parent to qpid_client class #78
Conversation
| $deploy = $::certs::deploy, | ||
|
|
||
| $nodes_cert_dir = $certs::params::nodes_cert_dir, | ||
| $nodes_cert_name = $certs::params::nodes_cert_name, |
|
We need to pin rake to make tests pass, foreman did this here: theforeman/foreman-installer-modulesync#28 I opened a PR for us to do it: Katello/foreman-installer-modulesync#4 |
johnpmitsch
force-pushed
the
pulp_parent_removal
branch
from
eff2d85 to
4c0f8e9
Compare
|
[test] |
johnpmitsch
force-pushed
the
pulp_parent_removal
branch
3 times, most recently
from
ae230ac to
2fa04ed
Compare
| $messaging_ca_cert = $certs::ca_cert, | ||
| $messaging_client_cert = $certs::params::messaging_client_cert | ||
|
|
||
| ) inherits pulp::params { # lint:ignore:inherits_across_namespaces |
|
I was thinking maybe we keep pulp_parent and pulp_child for now to make refactoring to use qpid_client less impactful and require less coordination of merging code. |
johnpmitsch
force-pushed
the
pulp_parent_removal
branch
from
2fa04ed to
cce5ca3
Compare
johnpmitsch
changed the title
johnpmitsch
force-pushed
the
pulp_parent_removal
branch
2 times, most recently
from
de9d7f1 to
2b0e5fd
Compare
| $regenerate = $::certs::regenerate, | ||
| $deploy = $::certs::deploy, | ||
|
|
||
| $messaging_ca_cert = $certs::ca_cert, |
There was a problem hiding this comment.
Looks like this parameter isn't used and could be removed
|
This will need updating as well https://github.com/Katello/puppet-certs/blob/master/manifests/capsule.pp |
johnpmitsch
force-pushed
the
pulp_parent_removal
branch
from
2b0e5fd to
3f87524
Compare
| @@ -26,7 +26,6 @@ | |||
| class { '::certs::apache': hostname => $capsule_fqdn } | |||
| class { '::certs::qpid': hostname => $capsule_fqdn } | |||
| class { '::certs::qpid_router': hostname => $capsule_fqdn } | |||
| class { '::certs::pulp_child': hostname => $capsule_fqdn } | |||
There was a problem hiding this comment.
Need to replace this with qpid_client, and down below
johnpmitsch
force-pushed
the
pulp_parent_removal
branch
from
3f87524 to
d78e216
Compare
|
@ehelms updated |
|
Can you fix the test failure? Otherwise looks good |
johnpmitsch
force-pushed
the
pulp_parent_removal
branch
from
d78e216 to
e55f49b
Compare
|
@ehelms fixed |
|
normal functionality and capsule-certs-generate is working with these changes |
|
ACK - thanks @johnpmitsch ! |
Fixes #14188 - change pulp_parent to qpid_client class
No description provided.