Fixes #13200 - Ensure that the capsule installer sets up a standart p… #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pulp::child::fragment{'gpg_key_proxy': | ||
| ssl_content => template('capsule/_pulp_child_gpg_proxy.erb'), | ||
| } | ||
|
|
||
| class { '::certs::pulp_child': | ||
| hostname => $capsule_fqdn, | ||
| notify => [ Class['pulp'], Class['pulp::child'] ], |
There was a problem hiding this comment.
Remove the second notify here as we are removing that
|
This needs to include your new qpid_client class |
johnpmitsch
force-pushed
the
installer_changes
branch
4 times, most recently
from
34e77e2 to
7e0ffc8
Compare
|
Tested with theforeman/puppet-certs#78 on a capsule install, which ran fine and I was able to run a capsule sync |
johnpmitsch
force-pushed
the
installer_changes
branch
3 times, most recently
from
9e97439 to
4885d51
Compare
| class { '::certs::pulp_child': | ||
| hostname => $capsule_fqdn, | ||
| notify => [ Class['pulp'], Class['pulp::child'] ], | ||
| ::pulp::apache::fragment{'gpg_key_proxy': |
There was a problem hiding this comment.
I don't think you need the leading :: in this case, otherwise looks good!
johnpmitsch
force-pushed
the
installer_changes
branch
3 times, most recently
from
f087df5 to
3d63bc9
Compare
|
tested with theforeman/puppet-pulp#133 and theforeman/puppet-certs#78 on a capsule install and it ran successfully |
|
Can you please update the minimum version of puppet-certs to 0.5.0 and puppet-pulp to 3.2.0 in the metadata.json? |
johnpmitsch
force-pushed
the
installer_changes
branch
from
3d63bc9 to
5212607
Compare
|
@ehelms updated |
johnpmitsch
force-pushed
the
installer_changes
branch
from
5212607 to
233e31a
Compare
|
Thanks @johnpmitsch ! |
ehelms
added a commit
that referenced
this pull request
Mar 16, 2016
Fixes #13200 - Ensure that the capsule installer sets up a standart p…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ulp server