Allow specifying custom fragment on httpd module #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $order = 15, | ||
| ) { | ||
|
|
||
| if $ssl_content { |
There was a problem hiding this comment.
Does it make sense to use this fragment if there is no content?
There was a problem hiding this comment.
My brain pre-optimized to allow HTTP fragments in the future, I can just remove this check for now :)
There was a problem hiding this comment.
Then you can also remove the = undef and add a validate_string.
ehelms
force-pushed
the
custom-fragment
branch
2 times, most recently
from
4e04cac to
b3a3d36
Compare
|
ACK tested with theforeman/puppet-foreman_proxy_content#76 and theforeman/puppet-certs#78 on a capsule install and install ran successfully |
ehelms
added a commit
that referenced
this pull request
Mar 16, 2016
Allow specifying custom fragment on httpd module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.