Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard scvi-tools dependency #1185

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

michalk8
Copy link
Contributor

@michalk8 michalk8 commented Feb 7, 2024

Changes

Make scvi-tools install optional as pip install 'scvelo[vi]'.

Related to the failing CI, see here: theislab/cellrank#1156 (comment)

Related issues

Closes #1189.

@michalk8
Copy link
Contributor Author

michalk8 commented Feb 7, 2024

I disabled the testing of VELOVI because of upper chex pin that was fixed here: scverse/scvi-tools#2474
It should be re-enabled once new scvi-tools version is out.

Copy link
Member

@WeilerP WeilerP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @michalk8.

@WeilerP WeilerP merged commit 3f0a612 into theislab:main Feb 14, 2024
6 checks passed
@michalk8 michalk8 deleted the feature/optional-scvi branch February 14, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hard scvi dependency
2 participants