Remove rgeos from the dependency #5242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems timely as rgeos is being retired some time during 2023 according to its DESCRIPTION file |
|
Ah, thanks, good point. We also need to think about what to do with maptools. I'll file a new issue. |
teunbrand
pushed a commit
to teunbrand/ggplot2
that referenced
this pull request
Oct 4, 2023
teunbrand
added a commit
that referenced
this pull request
Oct 9, 2023
* Remove rgeos from the dependency (#5242) --------- Co-authored-by: Hiroaki Yutani <yutani.ini@gmail.com>
teunbrand
added a commit
that referenced
this pull request
Oct 13, 2023
* Cherry-pick from #5327 * Add a NEWS item * Hotfix 3.4.4 (#5449) * is.atomic() --> is.atomic() || is.null() * Polish news * Put is.null() first * Cherrypick rgeos removal from description (#5453) * Remove rgeos from the dependency (#5242) --------- Co-authored-by: Hiroaki Yutani <yutani.ini@gmail.com> * run revdepcheck * Update CRAN comments * Increment version number to 3.4.4 * Fix Version 3.4.4 NEWS Typo (#5479) Change "the upcoming retirement of rproj, rgeos, and maptools" to "the upcoming retirement of rgdal, rgeos, and maptools" * Increment version number to 3.4.4.9000 --------- Co-authored-by: Hiroaki Yutani <yutani.ini@gmail.com> Co-authored-by: Thomas Lin Pedersen <thomasp85@gmail.com> Co-authored-by: Matt Nield <64328730+matthewjnield@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See #5230 (comment))
rgoes is used nowhere. I couldn't find how it was used. We can find the name "rgoes" only in this NEWS item of ggplot2 v0.9.2. My guess is that
SpatialPolygonsDataFramewas living in rgeos at that time (now in sp)?It seems rgeos already became unused in 2015, so anyway I believe it's safe to remove rgoes now.
#1098