Hotfix 3.4.4 #5449
Merged
Hotfix 3.4.4 #5449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasp85
approved these changes
Oct 2, 2023
teunbrand
added a commit
that referenced
this pull request
Oct 13, 2023
* Cherry-pick from #5327 * Add a NEWS item * Hotfix 3.4.4 (#5449) * is.atomic() --> is.atomic() || is.null() * Polish news * Put is.null() first * Cherrypick rgeos removal from description (#5453) * Remove rgeos from the dependency (#5242) --------- Co-authored-by: Hiroaki Yutani <yutani.ini@gmail.com> * run revdepcheck * Update CRAN comments * Increment version number to 3.4.4 * Fix Version 3.4.4 NEWS Typo (#5479) Change "the upcoming retirement of rproj, rgeos, and maptools" to "the upcoming retirement of rgdal, rgeos, and maptools" * Increment version number to 3.4.4.9000 --------- Co-authored-by: Hiroaki Yutani <yutani.ini@gmail.com> Co-authored-by: Thomas Lin Pedersen <thomasp85@gmail.com> Co-authored-by: Matt Nield <64328730+matthewjnield@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes needed for #5437.
Mostly, it just replaces
is.atomic(x)byis.atomic(x) || is.null(x). The one exception is incheck_breaks_labels()where NULL can be matched with an atomic vector without problems.