Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bors #134

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Add bors #134

merged 1 commit into from
Nov 1, 2018

Conversation

Hoverbear
Copy link
Contributor

As I mentioned earlier, we are starting to experiment with bors to help us manage PRs in TiKV. Since we don't want to jam up TiKV, we can experiment a bit with Raft.

This should enable bors. There will still be more configuration and learning before we get it right.

Ultimately you should eventually be able to follow the document in https://bors.tech/documentation/getting-started/ to tell our friend bors they can merge a PR. :)

@Hoverbear Hoverbear added the Tooling/Testing CI, benchmarking, and testing infrastucture. label Oct 25, 2018
@Hoverbear Hoverbear added this to the 0.5.0 milestone Oct 25, 2018
@Hoverbear Hoverbear self-assigned this Oct 25, 2018
@ice1000
Copy link
Contributor

ice1000 commented Oct 25, 2018

Very cool!

Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We need to use it in prometheus, grpc, and other projects.

@Hoverbear
Copy link
Contributor Author

@siddontang Yes! Let's use Raft as a testing ground for a week or two and learn how it works first.

@Hoverbear Hoverbear merged commit 52856d1 into master Nov 1, 2018
@Hoverbear Hoverbear deleted the bors branch November 1, 2018 13:28
@@ -0,0 +1,4 @@
status = [
"continuous-integration/travis-ci/push",
"continuous-integration/appveyor/branch"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️ See #137 .

@Hoverbear Hoverbear mentioned this pull request Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling/Testing CI, benchmarking, and testing infrastucture.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants