Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Enables @bors for TiKV.
Learn about bors, or see the
CONTRIBUTING.md
changes in this PR.What is Bors?: Bors is a bot who will help us merge PRs faster and reduce CI wait times!
How?: Once a PR has two approvals you will be able to do
bors r+
as a maintainer of TiKV to have bors go ahead and try to merge the PR. Bors will automatically merge if there are no conflicts, and if a conflict breaks the build it will report it. For small changes, bors supports abors rollup
command to have it try multiple PRs at once, we have not tried this though. Bors also supports setting priorities on the queue, so important builds can be prioritized.Why?: Right now our team waits a long time for CI builds, and if another PR is merged all others must rebuild. This is time consuming and slow. Bors will do this for us automagically in a queue.
When?: I will need some time to figure out how to work it with CircleCI and Jenkins. Right now we have it working for AppVeyor and Travis-CI. If you'd like, I am very happy to set up bors on any libraries you are working on as well, but a large project gets the most benefit.
This introduces bors in an optional, supplementary manner.
PRs do not yet require bors to be used to be merged. This is intended for the future work, that PR will impact your workflow!!!
This is a best effort PR, as we may need to tinker with the CI to get bors properly detecting the statuses of CircleCI and (later) Jenkins. Expect follow ups.
What are the type of the changes? (mandatory)
New tooling.
How has this PR been tested? (mandatory)
It adds CI infrastructure, so cannot be practically tested. However if this fails it will not impact our contributors or workflow.
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
Only contributing docs, only for reviewers.
Does this PR affect tidb-ansible update? (mandatory)
Nope
Refer to a related PR or issue link (optional)
tikv/raft-rs#137
tikv/raft-rs#134
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)