Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appveyor, bors related branch configuration #137

Merged
merged 3 commits into from
Nov 2, 2018
Merged

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Nov 1, 2018

Adds appveyor so we can test our builds on Windows as well. Since I think none of our maintainers develop on Windows, this can possibly help us find portability bugs.

Also sets up CI to build the branches bors checks things on.

@Hoverbear Hoverbear added the Tooling/Testing CI, benchmarking, and testing infrastucture. label Nov 1, 2018
@Hoverbear Hoverbear added this to the 0.5.0 milestone Nov 1, 2018
@Hoverbear Hoverbear self-assigned this Nov 1, 2018
ice1000
ice1000 previously approved these changes Nov 1, 2018
@Hoverbear

This comment has been minimized.

bors bot added a commit that referenced this pull request Nov 1, 2018
137: Add Appveyor r=Hoverbear a=Hoverbear

Adds appveyor so we can test our builds on Windows as well. Since I think none of our maintainers develop on Windows, this can possibly help us find portability bugs.

Co-authored-by: Hoverbear <operator@hoverbear.org>
@bors

This comment has been minimized.

@Hoverbear
Copy link
Contributor Author

@ice1000 Please take a look again.

@Hoverbear Hoverbear changed the title Add Appveyor Add Appveyor, bors related branch configuration Nov 1, 2018
appveyor.yml Outdated Show resolved Hide resolved
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hoverbear Hoverbear merged commit 77b79a4 into master Nov 2, 2018
@Hoverbear Hoverbear deleted the appveyor branch November 2, 2018 13:58
@Hoverbear Hoverbear mentioned this pull request Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling/Testing CI, benchmarking, and testing infrastucture.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants