Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example-project improvements #20

Conversation

peterdew
Copy link
Collaborator

Hi @timdwilson,

I added a new featurebranche for the Example-project improvements we spoke about earlier at #19 . Please take a look. I changed the EF-approach to code-first, and database and seed-data is now created from code, so no seperate installation of test-database needed anymore.
Please pull this to get feedback from you and contributors. It is an ongoing job, some more tasks need to be done, like updating the tutorial.
I am not a contributor yet, you tried to make me one, didn't you? But I never received your invitation somehow. Please try again if possible. I would like to be one.

@timdwilson
Copy link
Owner

timdwilson commented Sep 15, 2017 via email

@timdwilson
Copy link
Owner

timdwilson commented Sep 15, 2017 via email

@peterdew
Copy link
Collaborator Author

I now see that I requested a pull from my feature branch to your master branch.
What I was intended to do, with this Pull request, was to create the new feature branch in yóur repository too. So others can work on it together with me, and finally merge it into the master in the future. Can you change it to that?

@timdwilson
Copy link
Owner

timdwilson commented Sep 16, 2017 via email

@peterdew peterdew changed the title Example project improvements Example-project improvements Sep 16, 2017
@peterdew
Copy link
Collaborator Author

About my intension to 'create the new feature branch in yóur repository too', that seems not te be a common practice, so don't bother please.
Additional changes in this area like modifying the tutorial to match the new example project can be the subject of another pull-request, I imagine. Is that correct?

@timdwilson
Copy link
Owner

timdwilson commented Sep 16, 2017 via email

@peterdew
Copy link
Collaborator Author

Oke, great. So a new branch in your repo called 'Example-project-codefirst' or something would make sense. I agree. Creating a branch in your repo is not permitted for me though as non-contributor, so please make me contributor for one time again. I changed my email-settings, there was something wrong with it! If that doesn't work, I will get in touch with GitHub Support.

@timdwilson
Copy link
Owner

timdwilson commented Sep 17, 2017 via email

@peterdew peterdew changed the base branch from master to Example-project-codefirst September 18, 2017 05:54
@peterdew
Copy link
Collaborator Author

Hi Tim, That works! Thanks!

@peterdew peterdew requested a review from groblerf September 18, 2017 05:58
@peterdew peterdew self-assigned this Sep 18, 2017
@peterdew peterdew requested a review from timdwilson September 18, 2017 06:01
@peterdew
Copy link
Collaborator Author

Hi, this is a pull request to update the new feature branch 'Example-project-codefirst' Please review the changes for me. I wonder if the commit "Merge branch 'master' into ExampleProjectImprovements" should be in the pull request. It is the commit where I synced my fork after the recent updates to master from @groblerf

@timdwilson
Copy link
Owner

timdwilson commented Sep 18, 2017 via email

@timdwilson timdwilson merged commit 54bf652 into timdwilson:Example-project-codefirst Sep 18, 2017
@peterdew peterdew deleted the ExampleProjectImprovements branch September 19, 2017 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants