-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ALTER TABLE DROP COLUMN on compressed hypertable #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
requested review from
berkley,
afiskon and
akuzm
and removed request for
a team
November 1, 2021 07:30
svenklemm
requested review from
gayyappan,
mkindahl,
erimatnor,
fabriziomello,
nikkhils and
pmwkaa
November 1, 2021 07:31
svenklemm
force-pushed
the
drop_compressed_column
branch
from
November 1, 2021 07:32
d0f36e9
to
5b79c7a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3769 +/- ##
==========================================
+ Coverage 90.36% 90.46% +0.10%
==========================================
Files 213 213
Lines 37719 37753 +34
==========================================
+ Hits 34084 34154 +70
+ Misses 3635 3599 -36
Continue to review full report at Codecov.
|
svenklemm
force-pushed
the
drop_compressed_column
branch
from
November 1, 2021 08:57
5b79c7a
to
cce9a80
Compare
erimatnor
reviewed
Nov 1, 2021
svenklemm
force-pushed
the
drop_compressed_column
branch
3 times, most recently
from
November 3, 2021 15:57
fbf5f2a
to
364ac9a
Compare
mfundul
approved these changes
Nov 4, 2021
svenklemm
force-pushed
the
drop_compressed_column
branch
3 times, most recently
from
November 4, 2021 12:19
45e0e4a
to
9df29a1
Compare
fabriziomello
approved these changes
Nov 4, 2021
gayyappan
reviewed
Nov 4, 2021
svenklemm
force-pushed
the
drop_compressed_column
branch
2 times, most recently
from
November 4, 2021 15:38
2f90b65
to
ada7269
Compare
gayyappan
approved these changes
Nov 4, 2021
svenklemm
force-pushed
the
drop_compressed_column
branch
from
November 4, 2021 16:10
ada7269
to
fc6c179
Compare
svenklemm
changed the title
Allow dropping columns from hypertable with compression
Allow ALTER TABLE DROP COLUMN on compressed hypertable
Nov 4, 2021
This patch allows dropping columns from hypertables with compression enabled when the dropped column is neither an orderby nor a segmentby column. Fixes timescale#3683
svenklemm
force-pushed
the
drop_compressed_column
branch
from
November 4, 2021 16:27
fc6c179
to
600612b
Compare
akuzm
added a commit
to akuzm/timescaledb
that referenced
this pull request
Feb 17, 2022
This release is medium priority for upgrade. We recommend that you upgrade at the next available opportunity. This release adds major new features since the 2.5.2 release, including: Compression in continuous aggregates Experimental support for timezones in continuous aggregates Experimental support for monthly buckets in continuous aggregates It also includes several bug fixes. Telemetry reports are switched to a new format, and now include more detailed statistics on compression, distributed hypertables and indexes. **Features** * timescale#3768 Allow ALTER TABLE ADD COLUMN with DEFAULT on compressed hypertable * timescale#3769 Allow ALTER TABLE DROP COLUMN on compressed hypertable * timescale#3943 Optimize first/last * timescale#3945 Add support for ALTER SCHEMA on multi-node * timescale#3949 Add support for DROP SCHEMA on multi-node **Bugfixes** * timescale#3808 Properly handle max_retries option * timescale#3863 Fix remote transaction heal logic * timescale#3869 Fix ALTER SET/DROP NULL contstraint on distributed hypertable * timescale#3944 Fix segfault in add_compression_policy * timescale#3961 Fix crash in EXPLAIN VERBOSE on distributed hypertable * timescale#4015 Eliminate float rounding instabilities in interpolate * timescale#4019 Update ts_extension_oid in transitioning state * timescale#4073 Fix buffer overflow in partition scheme **Improvements** Query planning performance is improved for hypertables with a large number of chunks. **Thanks** * @fvannee for reporting a first/last memory leak * @mmouterde for reporting an issue with floats and interpolate
akuzm
added a commit
that referenced
this pull request
Feb 17, 2022
This release is medium priority for upgrade. We recommend that you upgrade at the next available opportunity. This release adds major new features since the 2.5.2 release, including: Compression in continuous aggregates Experimental support for timezones in continuous aggregates Experimental support for monthly buckets in continuous aggregates It also includes several bug fixes. Telemetry reports are switched to a new format, and now include more detailed statistics on compression, distributed hypertables and indexes. **Features** * #3768 Allow ALTER TABLE ADD COLUMN with DEFAULT on compressed hypertable * #3769 Allow ALTER TABLE DROP COLUMN on compressed hypertable * #3943 Optimize first/last * #3945 Add support for ALTER SCHEMA on multi-node * #3949 Add support for DROP SCHEMA on multi-node **Bugfixes** * #3808 Properly handle max_retries option * #3863 Fix remote transaction heal logic * #3869 Fix ALTER SET/DROP NULL contstraint on distributed hypertable * #3944 Fix segfault in add_compression_policy * #3961 Fix crash in EXPLAIN VERBOSE on distributed hypertable * #4015 Eliminate float rounding instabilities in interpolate * #4019 Update ts_extension_oid in transitioning state * #4073 Fix buffer overflow in partition scheme **Improvements** Query planning performance is improved for hypertables with a large number of chunks. **Thanks** * @fvannee for reporting a first/last memory leak * @mmouterde for reporting an issue with floats and interpolate
svenklemm
pushed a commit
that referenced
this pull request
Feb 17, 2022
This release is medium priority for upgrade. We recommend that you upgrade at the next available opportunity. This release adds major new features since the 2.5.2 release, including: Compression in continuous aggregates Experimental support for timezones in continuous aggregates Experimental support for monthly buckets in continuous aggregates It also includes several bug fixes. Telemetry reports are switched to a new format, and now include more detailed statistics on compression, distributed hypertables and indexes. **Features** * #3768 Allow ALTER TABLE ADD COLUMN with DEFAULT on compressed hypertable * #3769 Allow ALTER TABLE DROP COLUMN on compressed hypertable * #3943 Optimize first/last * #3945 Add support for ALTER SCHEMA on multi-node * #3949 Add support for DROP SCHEMA on multi-node **Bugfixes** * #3808 Properly handle max_retries option * #3863 Fix remote transaction heal logic * #3869 Fix ALTER SET/DROP NULL contstraint on distributed hypertable * #3944 Fix segfault in add_compression_policy * #3961 Fix crash in EXPLAIN VERBOSE on distributed hypertable * #4015 Eliminate float rounding instabilities in interpolate * #4019 Update ts_extension_oid in transitioning state * #4073 Fix buffer overflow in partition scheme **Improvements** Query planning performance is improved for hypertables with a large number of chunks. **Thanks** * @fvannee for reporting a first/last memory leak * @mmouterde for reporting an issue with floats and interpolate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows dropping columns from hypertables with compression
enabled when the dropped column is neither an orderby nor a
segmentby column.
Fixes #3683