Fix crash in EXPLAIN VERBOSE on dist table #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkhils
force-pushed
the
verbose_crash
branch
from
0deb44a
to
705e521
Compare
svenklemm
reviewed
Jan 6, 2022
nikkhils
force-pushed
the
verbose_crash
branch
from
705e521
to
9bc859d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3961 +/- ##
==========================================
- Coverage 90.78% 90.74% -0.04%
==========================================
Files 213 213
Lines 38468 38468
==========================================
- Hits 34923 34908 -15
- Misses 3545 3560 +15
Continue to review full report at Codecov.
|
svenklemm
reviewed
Jan 7, 2022
akuzm
reviewed
Jan 10, 2022
akuzm
approved these changes
Jan 10, 2022
The crash is occurring in "fdw_scan_explain" function because the fsstate passed in is NULL and we try to access the "fetcher_type" field from it in VERBOSE mode. When we are doing EXPLAIN, we short circuit the init foreign scan calls and that's why fsstate is not filled up. Fixes timescale#3960
nikkhils
force-pushed
the
verbose_crash
branch
from
9bc859d
to
518993a
Compare
pmwkaa
approved these changes
Jan 10, 2022
akuzm
added a commit
to akuzm/timescaledb
that referenced
this pull request
Feb 17, 2022
This release is medium priority for upgrade. We recommend that you upgrade at the next available opportunity. This release adds major new features since the 2.5.2 release, including: Compression in continuous aggregates Experimental support for timezones in continuous aggregates Experimental support for monthly buckets in continuous aggregates It also includes several bug fixes. Telemetry reports are switched to a new format, and now include more detailed statistics on compression, distributed hypertables and indexes. **Features** * timescale#3768 Allow ALTER TABLE ADD COLUMN with DEFAULT on compressed hypertable * timescale#3769 Allow ALTER TABLE DROP COLUMN on compressed hypertable * timescale#3943 Optimize first/last * timescale#3945 Add support for ALTER SCHEMA on multi-node * timescale#3949 Add support for DROP SCHEMA on multi-node **Bugfixes** * timescale#3808 Properly handle max_retries option * timescale#3863 Fix remote transaction heal logic * timescale#3869 Fix ALTER SET/DROP NULL contstraint on distributed hypertable * timescale#3944 Fix segfault in add_compression_policy * timescale#3961 Fix crash in EXPLAIN VERBOSE on distributed hypertable * timescale#4015 Eliminate float rounding instabilities in interpolate * timescale#4019 Update ts_extension_oid in transitioning state * timescale#4073 Fix buffer overflow in partition scheme **Improvements** Query planning performance is improved for hypertables with a large number of chunks. **Thanks** * @fvannee for reporting a first/last memory leak * @mmouterde for reporting an issue with floats and interpolate
akuzm
added a commit
that referenced
this pull request
Feb 17, 2022
This release is medium priority for upgrade. We recommend that you upgrade at the next available opportunity. This release adds major new features since the 2.5.2 release, including: Compression in continuous aggregates Experimental support for timezones in continuous aggregates Experimental support for monthly buckets in continuous aggregates It also includes several bug fixes. Telemetry reports are switched to a new format, and now include more detailed statistics on compression, distributed hypertables and indexes. **Features** * #3768 Allow ALTER TABLE ADD COLUMN with DEFAULT on compressed hypertable * #3769 Allow ALTER TABLE DROP COLUMN on compressed hypertable * #3943 Optimize first/last * #3945 Add support for ALTER SCHEMA on multi-node * #3949 Add support for DROP SCHEMA on multi-node **Bugfixes** * #3808 Properly handle max_retries option * #3863 Fix remote transaction heal logic * #3869 Fix ALTER SET/DROP NULL contstraint on distributed hypertable * #3944 Fix segfault in add_compression_policy * #3961 Fix crash in EXPLAIN VERBOSE on distributed hypertable * #4015 Eliminate float rounding instabilities in interpolate * #4019 Update ts_extension_oid in transitioning state * #4073 Fix buffer overflow in partition scheme **Improvements** Query planning performance is improved for hypertables with a large number of chunks. **Thanks** * @fvannee for reporting a first/last memory leak * @mmouterde for reporting an issue with floats and interpolate
svenklemm
pushed a commit
that referenced
this pull request
Feb 17, 2022
This release is medium priority for upgrade. We recommend that you upgrade at the next available opportunity. This release adds major new features since the 2.5.2 release, including: Compression in continuous aggregates Experimental support for timezones in continuous aggregates Experimental support for monthly buckets in continuous aggregates It also includes several bug fixes. Telemetry reports are switched to a new format, and now include more detailed statistics on compression, distributed hypertables and indexes. **Features** * #3768 Allow ALTER TABLE ADD COLUMN with DEFAULT on compressed hypertable * #3769 Allow ALTER TABLE DROP COLUMN on compressed hypertable * #3943 Optimize first/last * #3945 Add support for ALTER SCHEMA on multi-node * #3949 Add support for DROP SCHEMA on multi-node **Bugfixes** * #3808 Properly handle max_retries option * #3863 Fix remote transaction heal logic * #3869 Fix ALTER SET/DROP NULL contstraint on distributed hypertable * #3944 Fix segfault in add_compression_policy * #3961 Fix crash in EXPLAIN VERBOSE on distributed hypertable * #4015 Eliminate float rounding instabilities in interpolate * #4019 Update ts_extension_oid in transitioning state * #4073 Fix buffer overflow in partition scheme **Improvements** Query planning performance is improved for hypertables with a large number of chunks. **Thanks** * @fvannee for reporting a first/last memory leak * @mmouterde for reporting an issue with floats and interpolate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash is occurring in "fdw_scan_explain" function because the
fsstate passed in is NULL and we try to access the "fetcher_type" field
from it in VERBOSE mode.
When we are doing EXPLAIN, we short circuit the init foreign scan calls
and that's why fsstate is not filled up.
Fixes #3960