This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Slack sync upstream 2018 01 29 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `make test`: The "java" and "local_example" tests failed due to not having `mvn`, so I needed to install the "maven" package. The "vtctld_web" test failed due to "Can't start Xvfb ... No such file or directory" and "WebDriverException: Message: unknown error: cannot find Chrome binary, so I needed to install the "xvfb" and "chromium-browser" packages.
changes requested by @michael-berlin
The purpose of this limiter is to prevent single user from consuming whole transaction pool. BUG=69448559
Work in progress: This is only a proposal for how to integrate TxLimiter with TxEngine/TxPool. It's obviously not ready yet, just need this reviewed whether it's valid approach.
The timing is both unreliable for tests and not useful in general, so just make the ExecTime 0 for all plans.
Both the addition of stats for the plans and the recent vindex changes for bind variables changed the vtexplain output, so update the expected output accordingly.
Instead of outputting the full json / text output emitted by the test, only output the diffs. Also include a hint to the developer to inform how to update the expected test output files from the temp output of the given run.
docker: Add vtctlclient image.
Didn't cause shift-reduce conflicts.
BUG=72403076 Since DML_SUBQUERY rewrites updates to use pk, it should suppress index hints, because those should only be used by the SELECT.
moved GLOBAL, SESSION, and VARIABLES to non_reserved_keyword
…-in-show-tablets add a serving state column to show vitess_tablets
…rain-logs add logging and a max wait time to vtgate shutdown drain
bug: DML_SUBQUERY should suppress index hints
bugs: add test for 'force index' for RemoveHints
uses mysqladmin ping
MySQL keeps a lot of state in memory, so we don’t want to lose it unnecessarily
helm: update liveness probes
Modeling after the vtgate mysql server implementation, add a simple module that implements the mysql server protocol handlers and proxies all requests to the appropriate methods in a queryservice backend. This includes optional support for query normalization.
Add a binary to wrap a standalone queryservice with a grpc service interface and a mysql server implementation using the mysqlproxy module to direct to the queryservice.
Following the example of vtgate, add support to set autocommit on or off in the session, update the execution path to use ExecuteBatch for single round-trip autocommit semantics, and add tests to ensure the behavior matches mysql.
This allows EXPLAIN and other such statements to go through without query normalization.
rafael
approved these changes
Jan 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a branch for a hard-sync of Slack's vitess fork.
Sync to upstream as of 83866b3.
Merge in the vtqueryserver branch as of 4a44d25.
This implicitly reverts:
Required configuration changes:
vtgate:
The
-tablet_autocommit_when_allowedflag is no longer supported. The correspoding behavior is now implicit.vtqueryserver:
Two new flags
-allow_unsafe_dmls -queryserver-config-passthrough-dmlsare required to be passed when running.