Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Slack sync upstream 2018 01 29 #67

Merged
merged 195 commits into from
Jan 29, 2018
Merged

Commits on Aug 14, 2017

  1. document Ubuntu packages needed for make test

    When running `make test`:
    The "java" and "local_example" tests failed due to not having `mvn`, so I needed to install the "maven" package.
    The "vtctld_web" test failed due to "Can't start Xvfb ... No such file or directory" and "WebDriverException: Message: unknown error: cannot find Chrome binary, so I needed to install the "xvfb" and "chromium-browser" packages.
    slanning authored Aug 14, 2017
    Configuration menu
    Copy the full SHA
    26a196e View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2017

  1. moved to "Run Tests" section and the proper file in "doc" directory

    changes requested by @michael-berlin
    Scott Lanning committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    153f1c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2017

  1. Configuration menu
    Copy the full SHA
    925e14a View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2017

  1. Merge pull request #1 from youtube/master

    pull
    yangxuanjia authored Nov 28, 2017
    Configuration menu
    Copy the full SHA
    1095e58 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2017

  1. because

    yangxuanjia committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    7c46f5e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d8b7c53 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2017

  1. Merge pull request #2 from youtube/master

    merge
    yangxuanjia authored Dec 8, 2017
    Configuration menu
    Copy the full SHA
    eebe071 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    40dffde View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6a8574 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2017

  1. Configuration menu
    Copy the full SHA
    f497f46 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2017

  1. Configuration menu
    Copy the full SHA
    9905c43 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2017

  1. Configuration menu
    Copy the full SHA
    d331aa9 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2017

  1. Configuration menu
    Copy the full SHA
    f465b44 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2017

  1. Configuration menu
    Copy the full SHA
    91dbb39 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2017

  1. Configuration menu
    Copy the full SHA
    83ba0dc View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2017

  1. Implemented transaction limiter.

    The purpose of this limiter is to prevent single user from consuming
    whole transaction pool.
    
    BUG=69448559
    mswietochowski committed Dec 28, 2017
    Configuration menu
    Copy the full SHA
    7192c6e View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2017

  1. Configuration menu
    Copy the full SHA
    5789cbe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    130ab68 View commit details
    Browse the repository at this point in the history
  3. WIP: Integration TxLimiter into TxPool and TxEngine.

    Work in progress: This is only a proposal for how to integrate TxLimiter
    with TxEngine/TxPool. It's obviously not ready yet, just need this
    reviewed whether it's valid approach.
    mswietochowski committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    273cafe View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2017

  1. clear out ExecTime from the Plan stats

    The timing is both unreliable for tests and not useful in general, so
    just make the ExecTime 0 for all plans.
    demmer committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    4c5ac14 View commit details
    Browse the repository at this point in the history
  2. update vtexplain expected output to upstream changes

    Both the addition of stats for the plans and the recent vindex changes
    for bind variables changed the vtexplain output, so update the expected
    output accordingly.
    demmer committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    96a9460 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fc23df5 View commit details
    Browse the repository at this point in the history
  4. make the vtexplain test output more useful

    Instead of outputting the full json / text output emitted by the test,
    only output the diffs.
    
    Also include a hint to the developer to inform how to update the expected
    test output files from the temp output of the given run.
    demmer committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    a432586 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cd0f05b View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2018

  1. drain mysql protocol connections to vtgate

    tpetr committed Jan 1, 2018
    Configuration menu
    Copy the full SHA
    6cc568e View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2018

  1. updates

    tpetr committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    cf79ae9 View commit details
    Browse the repository at this point in the history
  2. add more logging

    tpetr committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    9bd57b5 View commit details
    Browse the repository at this point in the history
  3. try and make CI happy

    tpetr committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    f998a25 View commit details
    Browse the repository at this point in the history
  4. tweaks

    tpetr committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    c40941b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    61e96c6 View commit details
    Browse the repository at this point in the history
  6. support explicit partition clause in select, insert, replace, update,…

    … delete; no subpartition support
    Alex Charis committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    31fd277 View commit details
    Browse the repository at this point in the history
  7. fix logic

    tpetr committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    bd4da27 View commit details
    Browse the repository at this point in the history
  8. Merge pull request vitessio#3492 from HubSpot/partition-clause

    support explicit partition clause
    sougou authored Jan 2, 2018
    Configuration menu
    Copy the full SHA
    3c55c93 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2018

  1. Configuration menu
    Copy the full SHA
    fe3e721 View commit details
    Browse the repository at this point in the history
  2. Merge pull request vitessio#3517 from tinyspeck/fix-vtexplain-tests-a…

    …gain
    
    Fix vtexplain tests again
    sougou authored Jan 3, 2018
    Configuration menu
    Copy the full SHA
    e22b4f4 View commit details
    Browse the repository at this point in the history
  3. Merge pull request vitessio#3521 from derekperkins/patch-4

    Disable query cache in default.cnf
    sougou authored Jan 3, 2018
    Configuration menu
    Copy the full SHA
    3fb49b7 View commit details
    Browse the repository at this point in the history
  4. Merge pull request vitessio#3519 from tinyspeck/grpc-tracing-opt

    add an option to enable grpc tracing
    sougou authored Jan 3, 2018
    Configuration menu
    Copy the full SHA
    3531eb9 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2018

  1. properly wait for transactions to complete

    tpetr committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    a42a8a9 View commit details
    Browse the repository at this point in the history
  2. suppress errors for package vtgate tests

    I noticed when running
    ```
    go test 'github.com/youtube/vitess/go/vt/vtgate' -v
    ```
    
    these errors from glog:
    
    > ERROR: logging before flag.Parse: I0104 16:13:49.401758   22951 buffer.go:144] vtgate buffer not enabled.
    > ERROR: logging before flag.Parse: I0104 16:13:49.401895   22951 discoverygateway.go:103] loading tablets for cells: 
    > ERROR: logging before flag.Parse: I0104 16:13:49.401907   22951 gateway.go:84] Gateway waiting for serving tablets...
    > ERROR: logging before flag.Parse: I0104 16:13:49.401925   22951 gateway.go:91] Waiting for tablets completed
    > ERROR: logging before flag.Parse: I0104 16:13:49.401949   22951 vtgate.go:68] Transaction mode: 'MULTI'
    > ERROR: logging before flag.Parse: I0104 16:13:49.402435   22951 streamlog.go:141] Streaming logs from VTGate at /debug/querylog.
    
    This trick from kubernetes/kubernetes#17162 can suppress them, if you want.
    slanning authored Jan 4, 2018
    Configuration menu
    Copy the full SHA
    f55a351 View commit details
    Browse the repository at this point in the history
  3. gofmt

    no comment
    slanning authored Jan 4, 2018
    Configuration menu
    Copy the full SHA
    4977733 View commit details
    Browse the repository at this point in the history
  4. shutdownCh needs to be buffered

    tpetr committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    ef0fb86 View commit details
    Browse the repository at this point in the history
  5. Merge pull request vitessio#3525 from slanning/master

    suppress errors for package vtgate tests
    sougou authored Jan 4, 2018
    Configuration menu
    Copy the full SHA
    a140329 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2018

  1. Configuration menu
    Copy the full SHA
    b9c6970 View commit details
    Browse the repository at this point in the history
  2. PR feedback

    tpetr committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    76b2322 View commit details
    Browse the repository at this point in the history
  3. dont need this anymore

    tpetr committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    bce10b4 View commit details
    Browse the repository at this point in the history
  4. also these

    tpetr committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    c7cd32e View commit details
    Browse the repository at this point in the history
  5. tweak

    tpetr committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    5d15f80 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0540a52 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    593edd1 View commit details
    Browse the repository at this point in the history
  8. Fix a typo in docs.

    mswietochowski committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    5dbed9f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4fe19bf View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f5f5d8f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3f688a8 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d5fe37a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3bcfd7a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d7991ae View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. simply track number of busy connections

    tpetr committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    e8ed465 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca4cb76 View commit details
    Browse the repository at this point in the history
  3. add support for show vindexes

    demmer committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    229711d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4ad3fc5 View commit details
    Browse the repository at this point in the history
  5. fix show indexes tests

    demmer committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    c52e58b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f60a6b0 View commit details
    Browse the repository at this point in the history
  7. Merge pull request vitessio#3530 from jvaidya/init_config

    Add "init_config" option to mysqlctl.
    sougou authored Jan 8, 2018
    Configuration menu
    Copy the full SHA
    02d4826 View commit details
    Browse the repository at this point in the history
  8. Merge pull request vitessio#3531 from tinyspeck/export-grpc-version

    export the grpc version as a debug var
    sougou authored Jan 8, 2018
    Configuration menu
    Copy the full SHA
    f4fc774 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d56bd26 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2018

  1. appease codeclimate

    demmer committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    f2122ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86efbbc View commit details
    Browse the repository at this point in the history
  3. Merge pull request vitessio#3529 from tinyspeck/vtgate-querylog-to-file

    add a flag to enable query logging to a file for vtgate
    sougou authored Jan 9, 2018
    Configuration menu
    Copy the full SHA
    9dcfd11 View commit details
    Browse the repository at this point in the history
  4. Merge pull request vitessio#3534 from tinyspeck/vindex-show-statements

    vindex show statements
    sougou authored Jan 9, 2018
    Configuration menu
    Copy the full SHA
    de43b26 View commit details
    Browse the repository at this point in the history
  5. Merge pull request vitessio#3518 from HubSpot/vtgate-mysql-drain

    drain mysql protocol connections to vtgate at shutdown
    sougou authored Jan 9, 2018
    Configuration menu
    Copy the full SHA
    6a55b81 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6c81f81 View commit details
    Browse the repository at this point in the history
  7. Refactored tx_limiter API to only use callers, not context.

    This makes API smaller and cleaner.
    mswietochowski committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    9fd7aa2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1c78ebe View commit details
    Browse the repository at this point in the history
  9. A few small vtgate fixes / cleanups.

    * Remove unused 'method string' from Executor.execute().
    * Remove srv_topo_timeout flag from resilient_srv_topo_server.
      We can just used the provided context, no need to slap on
      a random timeout.
    * Update MessageStream comment, we do support multiple shards.
    * In vtgate SplitQuery, use closures directly, inside of wrapping them
      in a method.
    alainjobart committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    faf6910 View commit details
    Browse the repository at this point in the history
  10. Moving topo.SrvTopoServer into srvtopo.Server.

    The new package will also eventually contain:
    * the ResilientSrvTopoServer implementation of that interface.
    * helper methods to resolve cell/keyspace/shards.
    alainjobart committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    b13e0cc View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c413521 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2018

  1. Configuration menu
    Copy the full SHA
    6a90256 View commit details
    Browse the repository at this point in the history
  2. Moving some VSchema watch logic to srvtopo.

    It's more consistent to have the watch code in srvtopo.
    alainjobart committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    6baafa2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bb32a50 View commit details
    Browse the repository at this point in the history
  4. comment: unshard -> shard

    yangxuanjia committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    03a928f View commit details
    Browse the repository at this point in the history
  5. rollback Less()

    yangxuanjia committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    f1d2b68 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1d5870c View commit details
    Browse the repository at this point in the history
  7. explicitly enumerate the plan opcodes in the two cases

    To clarify what is going on in the two cases of inside-a-transaction
    and not-in-a-transaction, explicitly enumerate all the expected plan
    opcodes and make the default case an error, rather than relying on
    default behavior.
    demmer committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    9e30fd7 View commit details
    Browse the repository at this point in the history
  8. Merge pull request vitessio#3538 from tinyspeck/quiet-no-fieldcache-w…

    …arning
    
    remove the verbose log when fieldinfo can't be cached
    sougou authored Jan 10, 2018
    Configuration menu
    Copy the full SHA
    635b518 View commit details
    Browse the repository at this point in the history
  9. Merge pull request vitessio#3540 from yangxuanjia/master

    modify some comments
    sougou authored Jan 10, 2018
    Configuration menu
    Copy the full SHA
    b4fcdb7 View commit details
    Browse the repository at this point in the history
  10. Merge pull request vitessio#3527 from mswietochowski/txpool-limits

    Transaction pool limits
    sougou authored Jan 10, 2018
    Configuration menu
    Copy the full SHA
    02ba9a7 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f42b407 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    17a6595 View commit details
    Browse the repository at this point in the history
  13. Two fixes related to VSchema.

    * SrvVSchema update was not thread-safe. Now it is protected by the
      mutex.
    * Added a unit test for srvtopo.Server.WatchSrvVSchema.
    alainjobart committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    140f9ed View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    6bcbc69 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2018

  1. Configuration menu
    Copy the full SHA
    2a7c1b4 View commit details
    Browse the repository at this point in the history
  2. Merge pull request vitessio#3528 from tinyspeck/vtgate-increase-qps-g…

    …ranularity
    
    increase the frequency of vtgate qps rate metrics from 1m to 5s
    sougou authored Jan 11, 2018
    Configuration menu
    Copy the full SHA
    1f5d6e5 View commit details
    Browse the repository at this point in the history
  3. Fixing integration tests.

    A 'not found' is not a vschema watch error any more.
    alainjobart committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    448c4f4 View commit details
    Browse the repository at this point in the history
  4. Merge pull request vitessio#3539 from alainjobart/vtgate

    Vtgate refactors.
    alainjobart authored Jan 11, 2018
    Configuration menu
    Copy the full SHA
    ca2a7f1 View commit details
    Browse the repository at this point in the history
  5. Merge pull request vitessio#3541 from tinyspeck/query-executor-cleanup

    query executor cleanup
    sougou authored Jan 11, 2018
    Configuration menu
    Copy the full SHA
    f100a5d View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2018

  1. Configuration menu
    Copy the full SHA
    9326dc2 View commit details
    Browse the repository at this point in the history
  2. Pass down dba pool

    rafael committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    1ddeda7 View commit details
    Browse the repository at this point in the history
  3. Amend comment for clarity

    rafael committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    17b3703 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    73600e1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3dde522 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4175098 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b7e97bc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    56bf3b2 View commit details
    Browse the repository at this point in the history
  9. Proto changes for aggregate stats.

    This would allow re-using the current StreamHealthCheck to convey the
    status of a group of tablets, between vtgate and l2vtgate (which will
    be merged into vtgate).
    alainjobart committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    ce32589 View commit details
    Browse the repository at this point in the history
  10. Changes per code review

    rafael committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    dea8a22 View commit details
    Browse the repository at this point in the history
  11. Merge pull request vitessio#3552 from alainjobart/celltarget

    Proto changes for aggregate stats.
    sougou authored Jan 12, 2018
    Configuration menu
    Copy the full SHA
    3f0b610 View commit details
    Browse the repository at this point in the history
  12. Merge pull request vitessio#3551 from tinyspeck/show-vitess-tablets

    show vitess tablets
    sougou authored Jan 12, 2018
    Configuration menu
    Copy the full SHA
    56dd7f1 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2018

  1. Merge pull request vitessio#3550 from tinyspeck/fix-nil-pointer-app-d…

    …ebug
    
    Fix nil pointer exception when using appDebug feature
    sougou authored Jan 13, 2018
    Configuration menu
    Copy the full SHA
    b21cd23 View commit details
    Browse the repository at this point in the history
  2. v3: support for aggregation and sorting of TEXT

    This change adds support for aggregating and sorting of columns
    that may need to follow collation rules.
    
    The feature depends on mysql's weight_string function
    that returns a lexically comparable value of any text column.
    If a group by or order by uses a text column like varchar, then
    v3 will additionally request the weight_string versions of such
    columns and perform ordering and aggregation using those values
    instead.
    
    The identification of a text column is currently based on a new
    "columns" field in the vschema that allows you to specify the
    type of each column. This part was implemented in a previous PR.
    
    Two approaches were possible:
    1. Request additional weight_string values at the time of push-down.
    2. Rewire the primitives to request and use the additional weight_string
       values during the Wireup phase.
    I went with option 2 because it minimizes overall impact of the
    code, which will allow us to yank this behavior out when we
    implement collation aware sorting in vtgate. Also, since all
    the weight_string columns get added at the end, we only have
    to truncate the rows before returning what's needed.
    
    The following changes were made:
    * sqltypes: result truncate functionality.
    * engine: Add TruncateColumnCount field that can be used to truncate
      a result if needed.
    * planbuilder: Change Wireup to check and request weight_strings.
      If weight_string was requested, set the row truncation to make
      sure that the weight_string values don't get passed on.
    sougou committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    9c08562 View commit details
    Browse the repository at this point in the history
  3. Merge pull request vitessio#3522 from sougou/v3

    v3: support for aggregation and sorting of TEXT
    sougou authored Jan 13, 2018
    Configuration menu
    Copy the full SHA
    fe5e639 View commit details
    Browse the repository at this point in the history
  4. vtgate: remove accidental vttablet dependency

    Some copy-paste code introduced a dependency from vtgate to
    tabletserver, and ended up exporting all of vttablet's flags
    in vtgate. This PR fixes it.
    sougou committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    11d2639 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2018

  1. Merge pull request vitessio#3555 from sougou/bugs

    vtgate: remove accidental vttablet dependency
    sougou authored Jan 14, 2018
    Configuration menu
    Copy the full SHA
    2efa0df View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2018

  1. v3: cosmetic prep work for autocommit

    This change is mostly cosmetic. Previously, vtgatepb.Session was
    the variable that the Executor shared through its layers.
    We now change it to share a SafeSession, which also encapsulates
    vtgatepb.Session, but it can carry additional state that lower
    layers can use to make instant-commit decisions.
    
    This additional flag will be added in the next iteration.
    sougou committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    75555d7 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. make "set session wait_timeout=1234" not error

    Maybe more a request for comments than a pull request,
    since I'm not too confident I'm doing things right.
    This set query currently causes a syntax error
    (and is one of a couple queries blocking our testing).
    
    I added a "Scope" field to Set struct in ast.go.
    Updated sql.y to allow session/global in "set $scope ...".
    That was a little complicated because it caused a "shift-reduce conflict"
    which I solved by weirdly having separate set_session_or_global and show_session_or_global;
    and I added tokens for SESSION and GLOBAL,
    and that caused "SHOW ..." to break,
    so I ended up adding STATUS and VARIABLES tokens, too
    (I haven't worked with parsers before, don't know if this is sane)
    and a Scope field to Show struct.
    
    In executor.go I added the Scope field to the return of sqlparser.ExtractSetValues
    and make an error if it's "global", which is possibly wrong.
    Also not sure I handled wait_timeout correctly..
    
    In vtexplain_vttablet.go I made it return an empty result
    in case of Set and Show statements.
    
    There was a create table test that used a "status" column,
    which now conflicted with the new reserved word.
    I changed the column name, though I'm not sure that's a good idea..
    
    So let me know how WTF it is. :)
    Scott Lanning committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    e5655b8 View commit details
    Browse the repository at this point in the history
  2. Removing useless Once().

    The method it's in is already only called once, it log.Fatalf() if
    called more than once. Also, it already registers a gazillion of named
    stats, that would definitely fail if called again.
    alainjobart committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    bda2483 View commit details
    Browse the repository at this point in the history
  3. Merge pull request vitessio#3556 from sougou/autocommit

    v3: cosmetic prep work for autocommit
    sougou authored Jan 16, 2018
    Configuration menu
    Copy the full SHA
    04736af View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2018

  1. Merge remote-tracking branch 'upstream/master'

    fixed conflict in executor.go from 75555d7 (merged in 04736af )
    Scott Lanning committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    3bddbdb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b486677 View commit details
    Browse the repository at this point in the history
  3. add more logging and a max wait time to vtgate shutdown drain

    Wait no more than 30 seconds for active vtgate mysql connections to
    drain, and emit a log every 2 seconds while waiting with the count
    of connections that we're waiting for.
    demmer committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    b9d32c1 View commit details
    Browse the repository at this point in the history
  4. Few fixes related to tablets wait in vtgate.

    Now both vtgate and l2vtgate will log.Fatal at start if they can't
    contact the topology server to get the list of SrvKeyspace and the
    individual SrvKeyspace objects.
    
    Make the WaitForTabletTypes correct. We used to wait for all tablet
    types for any shard in the keyspace partitions. It's not correct because
    a keyspace partition is only valid for a single tablet type, not all of
    them. In practice, this would only show during horizontal resharding
    when some shards are not in cells. Fixing this makes the code somewhat
    simpler though, as we can't have duplicate keyspace/shard/tablet type,
    no need to de-dup them, so using an array of Target instead of a map of
    keyspaceShard.
    
    As a side fix, the fake SrvKeyspace we used for some tabletconn tests
    had the wrong partition type. Now that we pay attention to it, had to
    fix that.
    
    BUG=72045104
    alainjobart committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    7c19135 View commit details
    Browse the repository at this point in the history
  5. vtgate: fix vtgate_test

    The parsing of flags in vtgate_test caused it to eat all flags
    including the ones used by the test package. This caused tests
    here to ignore things like -run, etc.
    
    I tried changing the init to TestMain. That didn't help. So,
    I'm removing the parsing call for now until we figure out a
    different way to fix this.
    sougou committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    ae9396f View commit details
    Browse the repository at this point in the history
  6. Merge pull request vitessio#3561 from sougou/bugs

    vtgate: fix vtgate_test
    sougou authored Jan 17, 2018
    Configuration menu
    Copy the full SHA
    d435aeb View commit details
    Browse the repository at this point in the history
  7. Merge pull request vitessio#3558 from alainjobart/simpler

    Few fixes related to vtgate startup.
    sougou authored Jan 17, 2018
    Configuration menu
    Copy the full SHA
    98abe80 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3968cbc View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2018

  1. Merge pull request vitessio#3548 from dweitzman/update_alias_fix

    Allow aliases in update statements
    sougou authored Jan 18, 2018
    Configuration menu
    Copy the full SHA
    ee1dcc9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request vitessio#3557 from slanning/master

    make "set session wait_timeout=1234" not error
    sougou authored Jan 18, 2018
    Configuration menu
    Copy the full SHA
    322c006 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2018

  1. add a planbuilder option to pass through DMLs

    When PassthroughDMLs is set, then all update or delete queries are
    returned as PlanPassDML regardless of query type.
    demmer committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    1e29552 View commit details
    Browse the repository at this point in the history
  2. add vttablet option to pass through all DMLs

    Add a flag to the queryserver config that both configures the
    planbuilder to use PlanPassDML for all plans and allows those plans
    to execute even in statement based replication.
    demmer committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    2de23da View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2018

  1. bug: fix mycnf error propagation

    This bug has confused many people because it just crashes vttablet
    with a mysterious SIGSEGV. The problem was a bug in the error
    propagation of mycnf which was using old panic style error handling.
    
    This also addresses what vitessio#3195 was trying to fix.
    sougou committed Jan 21, 2018
    Configuration menu
    Copy the full SHA
    09e80c2 View commit details
    Browse the repository at this point in the history
  2. bug: quote strings in parse errors

    Alternate fix for vitessio#3247, along with test fixes.
    sougou committed Jan 21, 2018
    Configuration menu
    Copy the full SHA
    eeef41a View commit details
    Browse the repository at this point in the history
  3. Merge pull request vitessio#3059 from slanning/patch-2

    document Ubuntu packages needed for `make test`
    sougou authored Jan 21, 2018
    Configuration menu
    Copy the full SHA
    d2e2575 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2018

  1. Merge pull request vitessio#3568 from sougou/bugs

    bug: fix mycnf error propagation
    sougou authored Jan 22, 2018
    Configuration menu
    Copy the full SHA
    788962c View commit details
    Browse the repository at this point in the history
  2. Merge pull request vitessio#3569 from sougou/bugs2

    bug: quote strings in parse errors
    sougou authored Jan 22, 2018
    Configuration menu
    Copy the full SHA
    bf64d2e View commit details
    Browse the repository at this point in the history
  3. Revert "sort the vtexplain queries before outputting them"

    This reverts commit 1f3a930.
    
    Sorting in fact makes the test output illogical for sequences where
    statements occur in the same time quantum since it inverts the
    causal ordering.
    demmer committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    2c78f0e View commit details
    Browse the repository at this point in the history
  4. add execution mode option to vtexplain

    Include an execution mode in the vtexplain options and refactor the
    tests to support different outputs for each execution mode.
    
    The mode doesn't yet change the behavior -- support for legacy
    autocommit and TwoPC to come in subsequent commits.
    demmer committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    0c08f88 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c777315 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f16c5dc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    aabed96 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0a82a1f View commit details
    Browse the repository at this point in the history
  9. remove json mode output from vtexplain tests

    The json mode ends up being very verbose and prone to changes when
    the internals of the vtgate plan object change, so remove them from
    the vtexplain tests.
    demmer committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    12abecc View commit details
    Browse the repository at this point in the history
  10. add a vtexplain test for json output

    Check the structure of the vtexplain output without depending on the
    details of the Plan so that any future changes to the plan structure
    don't cause the vtexplain tests to need updating.
    demmer committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    b4ec805 View commit details
    Browse the repository at this point in the history
  11. Merge pull request vitessio#3532 from tinyspeck/vtexplain-test-other-…

    …modes
    
    vtexplain support different modes
    sougou authored Jan 22, 2018
    Configuration menu
    Copy the full SHA
    1914a97 View commit details
    Browse the repository at this point in the history
  12. add a separate allowUnsafeDMLs flag

    Since PlanPassDML executions are fundamentally unsafe in SBR mode,
    they should not be allowed unless the user explicitly wants to
    enable them, so add a separate flag which is not exposed in a command
    line flag (but will be in vtqueryserver) to allow the unsafe
    statements when in SBR mode.
    demmer committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    b204a25 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2018

  1. Add new Dockerfile tailored for Kubernetes

    This needs to be added to the Docker Hub auto build process
    derekperkins authored and enisoc committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    42b450d View commit details
    Browse the repository at this point in the history
  2. Overhaul helm chart

    - Allows for custom database images
    - Supports MySQL protocol
    - Upgrade to etcd2 topology server
    - Uses etcd-operator
    - Default pod affinity/anti-affinity
    - HPA for vtgates
    - Pod security context doesn’t allow root privileges
    - Supports default credential chains for GCS/S3
    - Moves backup and other config to ConfigMap
    - Temporarily removes Orchestrator support
    - Vitess components log to stdout/stderr only
    - MySQL slow/error logs redirected to stdout
    - Removed syslog and hostPath mounts
    - Uses new vitess:k8s Docker image
    - Support regional failure domain affinity
    derekperkins authored and enisoc committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    6775d26 View commit details
    Browse the repository at this point in the history
  3. Tweak vitess/k8s Dockerfile

    enisoc committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    85ab5d3 View commit details
    Browse the repository at this point in the history
  4. add servenv helper routines for common logic on flag parsing

    Add servenv.ParseFlags and servenv.ParseFlagsAndArgs to handle the
    common logic around parsing flags, handling the -version flag to
    print version, and verify that positional arguments either are or
    are not supplied as expected.
    demmer committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    489c422 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d1e5a57 View commit details
    Browse the repository at this point in the history
  6. ignore /*! mysql-specific */ comment statements

    This is related to vitessio#3520
    
    Also ignore /*!50708 mysql-version-specific */ comments.
    
    I'm not sure if it's a good idea. Instead of stripping leading comments,
    in case it's /*! ... */ we don't strip it, and consider it a new StmtComment statement type.
    (Not sure if that should be added to ast.go . I didn't.)
    I assumed this kind of comment was the only thing in the query,
    so if there's something like "/*! ... */ select ..." it wouldn't work.
    The handleComment in executor.go basically does nothing, returning &sqltypes.Result{}
    Scott Lanning committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    cc06faf View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2c0aaa9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b61debd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    abad1c3 View commit details
    Browse the repository at this point in the history
  10. Merge pull request vitessio#3564 from tinyspeck/queryserver-passthrou…

    …gh-dmls
    
    passthrough DML option
    sougou authored Jan 23, 2018
    Configuration menu
    Copy the full SHA
    787ad0d View commit details
    Browse the repository at this point in the history
  11. helm: Tweak chart config.

    enisoc committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    e9adf37 View commit details
    Browse the repository at this point in the history
  12. Merge pull request vitessio#3573 from tinyspeck/handle-positional-arg…

    …uments
    
    add positional argument validation
    sougou authored Jan 23, 2018
    Configuration menu
    Copy the full SHA
    faa0672 View commit details
    Browse the repository at this point in the history
  13. Merge pull request vitessio#3574 from tinyspeck/fix-for-topo

    Fix for refreshing schema after update
    sougou authored Jan 23, 2018
    Configuration menu
    Copy the full SHA
    90a8904 View commit details
    Browse the repository at this point in the history
  14. Merge pull request vitessio#3575 from dweitzman/parse_status

    Allow columns named 'status'
    sougou authored Jan 23, 2018
    Configuration menu
    Copy the full SHA
    fccc652 View commit details
    Browse the repository at this point in the history
  15. Merge pull request vitessio#3582 from youtube/helm

    Update Helm Chart
    enisoc authored Jan 23, 2018
    Configuration menu
    Copy the full SHA
    5a7f4df View commit details
    Browse the repository at this point in the history
  16. Merge pull request vitessio#3576 from slanning/comment-queries

    ignore mysql-specific comment statements
    sougou authored Jan 23, 2018
    Configuration menu
    Copy the full SHA
    1b5c48f View commit details
    Browse the repository at this point in the history
  17. docker: add minimal binary images

    mysqlctld, vtctl, vtctld, vtgate, vttablet
    derekperkins committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    8501c83 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    6b2aaab View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. Configuration menu
    Copy the full SHA
    dd2be93 View commit details
    Browse the repository at this point in the history
  2. v3: instant-commit for autocommit

    If we are in autocommit mode and vtgate does not break a DML into
    smaller parts, then it has the opportunity to send that statement
    through to a vttablet as autocommit in a single round-trip.
    
    Reviewer instructions:
    @demmer: I'm not too sure about the vtexplain fixes, or if additional
    tests are required there. Extra scrutiny may be required there.
    
    Implementation notes:
    * SafeSession has a state machine for tracking autocommit state.
    * The autocommit state is initialized by executor as needed.
    * VCursor API has been changed for ExecMultiShard. It now accepts
      an extra canCommit flag that should be set to true if the engine
      is executing its final DML. This, combined with the autocommit
      state will decide if an instant autocommit is possible.
    sougou committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    3f86922 View commit details
    Browse the repository at this point in the history
  3. Merge pull request vitessio#3559 from sougou/autocommit

    v3: instant-commit for autocommit
    sougou authored Jan 24, 2018
    Configuration menu
    Copy the full SHA
    3e39b05 View commit details
    Browse the repository at this point in the history
  4. moved VARIABLES to non_reserved_keyword

    This also fixes an omission from b61debd
    to remove the extra STATUS left in reserved_keyword .
    
    (I wasn't sure about GLOBAL and SESSION from my previous commit e5655b8 ,
    so I left them for now but possibly they also should be in non_reserved_keyword.)
    Scott Lanning committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    4d65037 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. Merge pull request vitessio#3583 from derekperkins/binary-specific-do…

    …ckerfiles
    
    Create and use minimal docker images in Kubernetes
    enisoc authored Jan 25, 2018
    Configuration menu
    Copy the full SHA
    5fe41bf View commit details
    Browse the repository at this point in the history
  2. docker: Add vtctlclient image.

    enisoc committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    406ae81 View commit details
    Browse the repository at this point in the history
  3. Merge pull request vitessio#3587 from enisoc/docker-vtctlclient

    docker: Add vtctlclient image.
    enisoc authored Jan 25, 2018
    Configuration menu
    Copy the full SHA
    1cbceba View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b1e64ed View commit details
    Browse the repository at this point in the history
  5. also move GLOBAL and SESSION keywords to non_reserved_keyword

    Didn't cause shift-reduce conflicts.
    Scott Lanning committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    be7e755 View commit details
    Browse the repository at this point in the history
  6. bug: DML_SUBQUERY should suppress index hints

    BUG=72403076
    Since DML_SUBQUERY rewrites updates to use pk, it should suppress
    index hints, because those should only be used by the SELECT.
    sougou committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    1d67a90 View commit details
    Browse the repository at this point in the history
  7. Merge pull request vitessio#3585 from slanning/non-reserved-keywords2

    moved GLOBAL, SESSION, and VARIABLES to non_reserved_keyword
    sougou authored Jan 25, 2018
    Configuration menu
    Copy the full SHA
    46af0b1 View commit details
    Browse the repository at this point in the history
  8. Merge pull request vitessio#3588 from tinyspeck/include-serving-state…

    …-in-show-tablets
    
    add a serving state column to show vitess_tablets
    sougou authored Jan 25, 2018
    Configuration menu
    Copy the full SHA
    36f02b9 View commit details
    Browse the repository at this point in the history
  9. Merge pull request vitessio#3560 from tinyspeck/vtgate-mysql-server-d…

    …rain-logs
    
    add logging and a max wait time to vtgate shutdown drain
    sougou authored Jan 25, 2018
    Configuration menu
    Copy the full SHA
    4a3f148 View commit details
    Browse the repository at this point in the history
  10. Merge pull request vitessio#3589 from sougou/bugs

    bug: DML_SUBQUERY should suppress index hints
    sougou authored Jan 25, 2018
    Configuration menu
    Copy the full SHA
    cca6112 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0bc4ebc View commit details
    Browse the repository at this point in the history
  12. Merge pull request vitessio#3590 from sougou/bugs

    bugs: add test for 'force index' for RemoveHints
    sougou authored Jan 25, 2018
    Configuration menu
    Copy the full SHA
    43aaa50 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2018

  1. Configuration menu
    Copy the full SHA
    9a49113 View commit details
    Browse the repository at this point in the history
  2. helm: add liveness probe to mysql container

    uses mysqladmin ping
    derekperkins committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    5c0ae3d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7ae9ac6 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2018

  1. Configuration menu
    Copy the full SHA
    c4fffdd View commit details
    Browse the repository at this point in the history
  2. helm: remove mysql livenessProbe

    MySQL keeps a lot of state in memory, so we don’t want to lose it unnecessarily
    derekperkins committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    b434853 View commit details
    Browse the repository at this point in the history
  3. Merge pull request vitessio#3584 from derekperkins/mysql-liveness-probe

    helm: update liveness probes
    enisoc authored Jan 27, 2018
    Configuration menu
    Copy the full SHA
    83866b3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8f0bc14 View commit details
    Browse the repository at this point in the history
  5. add a reusable mysqlproxy module

    Modeling after the vtgate mysql server implementation, add a simple
    module that implements the mysql server protocol handlers and
    proxies all requests to the appropriate methods in a queryservice
    backend.
    
    This includes optional support for query normalization.
    demmer committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    f786a06 View commit details
    Browse the repository at this point in the history
  6. add vtqueryserver

    Add a binary to wrap a standalone queryservice with a grpc service
    interface and a mysql server implementation using the mysqlproxy
    module to direct to the queryservice.
    demmer committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    5e7254e View commit details
    Browse the repository at this point in the history
  7. resolve upstream conflict

    demmer committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    bb33739 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e1fdd3e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a75a754 View commit details
    Browse the repository at this point in the history
  10. rework the proxy implementation of autocommit to match mysql

    Following the example of vtgate, add support to set autocommit on
    or off in the session, update the execution path to use ExecuteBatch
    for single round-trip autocommit semantics, and add tests to ensure
    the behavior matches mysql.
    demmer committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    45ad926 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2b3048f View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0ea8013 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    bc7ffa9 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. add proxy support for other statements

    This allows EXPLAIN and other such statements to go through without
    query normalization.
    demmer committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    4a44d25 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d48e84a View commit details
    Browse the repository at this point in the history