-
Notifications
You must be signed in to change notification settings - Fork 9
Commits on Aug 14, 2017
-
document Ubuntu packages needed for
make test
When running `make test`: The "java" and "local_example" tests failed due to not having `mvn`, so I needed to install the "maven" package. The "vtctld_web" test failed due to "Can't start Xvfb ... No such file or directory" and "WebDriverException: Message: unknown error: cannot find Chrome binary, so I needed to install the "xvfb" and "chromium-browser" packages.
Configuration menu - View commit details
-
Copy full SHA for 26a196e - Browse repository at this point
Copy the full SHA 26a196eView commit details
Commits on Aug 15, 2017
-
moved to "Run Tests" section and the proper file in "doc" directory
changes requested by @michael-berlin
Scott Lanning committedAug 15, 2017 Configuration menu - View commit details
-
Copy full SHA for 153f1c9 - Browse repository at this point
Copy the full SHA 153f1c9View commit details
Commits on Nov 26, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 925e14a - Browse repository at this point
Copy the full SHA 925e14aView commit details
Commits on Nov 28, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 1095e58 - Browse repository at this point
Copy the full SHA 1095e58View commit details
Commits on Dec 7, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 7c46f5e - Browse repository at this point
Copy the full SHA 7c46f5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8b7c53 - Browse repository at this point
Copy the full SHA d8b7c53View commit details
Commits on Dec 8, 2017
-
Configuration menu - View commit details
-
Copy full SHA for eebe071 - Browse repository at this point
Copy the full SHA eebe071View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40dffde - Browse repository at this point
Copy the full SHA 40dffdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6a8574 - Browse repository at this point
Copy the full SHA b6a8574View commit details
Commits on Dec 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for f497f46 - Browse repository at this point
Copy the full SHA f497f46View commit details
Commits on Dec 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9905c43 - Browse repository at this point
Copy the full SHA 9905c43View commit details
Commits on Dec 19, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d331aa9 - Browse repository at this point
Copy the full SHA d331aa9View commit details
Commits on Dec 21, 2017
-
Configuration menu - View commit details
-
Copy full SHA for f465b44 - Browse repository at this point
Copy the full SHA f465b44View commit details
Commits on Dec 22, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 91dbb39 - Browse repository at this point
Copy the full SHA 91dbb39View commit details
Commits on Dec 25, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 83ba0dc - Browse repository at this point
Copy the full SHA 83ba0dcView commit details
Commits on Dec 28, 2017
-
Implemented transaction limiter.
The purpose of this limiter is to prevent single user from consuming whole transaction pool. BUG=69448559
Configuration menu - View commit details
-
Copy full SHA for 7192c6e - Browse repository at this point
Copy the full SHA 7192c6eView commit details
Commits on Dec 29, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5789cbe - Browse repository at this point
Copy the full SHA 5789cbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 130ab68 - Browse repository at this point
Copy the full SHA 130ab68View commit details -
WIP: Integration TxLimiter into TxPool and TxEngine.
Work in progress: This is only a proposal for how to integrate TxLimiter with TxEngine/TxPool. It's obviously not ready yet, just need this reviewed whether it's valid approach.
Configuration menu - View commit details
-
Copy full SHA for 273cafe - Browse repository at this point
Copy the full SHA 273cafeView commit details
Commits on Dec 31, 2017
-
clear out ExecTime from the Plan stats
The timing is both unreliable for tests and not useful in general, so just make the ExecTime 0 for all plans.
Configuration menu - View commit details
-
Copy full SHA for 4c5ac14 - Browse repository at this point
Copy the full SHA 4c5ac14View commit details -
update vtexplain expected output to upstream changes
Both the addition of stats for the plans and the recent vindex changes for bind variables changed the vtexplain output, so update the expected output accordingly.
Configuration menu - View commit details
-
Copy full SHA for 96a9460 - Browse repository at this point
Copy the full SHA 96a9460View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc23df5 - Browse repository at this point
Copy the full SHA fc23df5View commit details -
make the vtexplain test output more useful
Instead of outputting the full json / text output emitted by the test, only output the diffs. Also include a hint to the developer to inform how to update the expected test output files from the temp output of the given run.
Configuration menu - View commit details
-
Copy full SHA for a432586 - Browse repository at this point
Copy the full SHA a432586View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd0f05b - Browse repository at this point
Copy the full SHA cd0f05bView commit details
Commits on Jan 1, 2018
-
drain mysql protocol connections to vtgate
tpetr committedJan 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 6cc568e - Browse repository at this point
Copy the full SHA 6cc568eView commit details
Commits on Jan 2, 2018
-
tpetr committed
Jan 2, 2018 Configuration menu - View commit details
-
Copy full SHA for cf79ae9 - Browse repository at this point
Copy the full SHA cf79ae9View commit details -
tpetr committed
Jan 2, 2018 Configuration menu - View commit details
-
Copy full SHA for 9bd57b5 - Browse repository at this point
Copy the full SHA 9bd57b5View commit details -
tpetr committed
Jan 2, 2018 Configuration menu - View commit details
-
Copy full SHA for f998a25 - Browse repository at this point
Copy the full SHA f998a25View commit details -
tpetr committed
Jan 2, 2018 Configuration menu - View commit details
-
Copy full SHA for c40941b - Browse repository at this point
Copy the full SHA c40941bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61e96c6 - Browse repository at this point
Copy the full SHA 61e96c6View commit details -
support explicit partition clause in select, insert, replace, update,…
… delete; no subpartition support
Alex Charis committedJan 2, 2018 Configuration menu - View commit details
-
Copy full SHA for 31fd277 - Browse repository at this point
Copy the full SHA 31fd277View commit details -
tpetr committed
Jan 2, 2018 Configuration menu - View commit details
-
Copy full SHA for bd4da27 - Browse repository at this point
Copy the full SHA bd4da27View commit details -
Merge pull request vitessio#3492 from HubSpot/partition-clause
support explicit partition clause
Configuration menu - View commit details
-
Copy full SHA for 3c55c93 - Browse repository at this point
Copy the full SHA 3c55c93View commit details
Commits on Jan 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for fe3e721 - Browse repository at this point
Copy the full SHA fe3e721View commit details -
Merge pull request vitessio#3517 from tinyspeck/fix-vtexplain-tests-a…
…gain Fix vtexplain tests again
Configuration menu - View commit details
-
Copy full SHA for e22b4f4 - Browse repository at this point
Copy the full SHA e22b4f4View commit details -
Merge pull request vitessio#3521 from derekperkins/patch-4
Disable query cache in default.cnf
Configuration menu - View commit details
-
Copy full SHA for 3fb49b7 - Browse repository at this point
Copy the full SHA 3fb49b7View commit details -
Merge pull request vitessio#3519 from tinyspeck/grpc-tracing-opt
add an option to enable grpc tracing
Configuration menu - View commit details
-
Copy full SHA for 3531eb9 - Browse repository at this point
Copy the full SHA 3531eb9View commit details
Commits on Jan 4, 2018
-
properly wait for transactions to complete
tpetr committedJan 4, 2018 Configuration menu - View commit details
-
Copy full SHA for a42a8a9 - Browse repository at this point
Copy the full SHA a42a8a9View commit details -
suppress errors for package vtgate tests
I noticed when running ``` go test 'github.com/youtube/vitess/go/vt/vtgate' -v ``` these errors from glog: > ERROR: logging before flag.Parse: I0104 16:13:49.401758 22951 buffer.go:144] vtgate buffer not enabled. > ERROR: logging before flag.Parse: I0104 16:13:49.401895 22951 discoverygateway.go:103] loading tablets for cells: > ERROR: logging before flag.Parse: I0104 16:13:49.401907 22951 gateway.go:84] Gateway waiting for serving tablets... > ERROR: logging before flag.Parse: I0104 16:13:49.401925 22951 gateway.go:91] Waiting for tablets completed > ERROR: logging before flag.Parse: I0104 16:13:49.401949 22951 vtgate.go:68] Transaction mode: 'MULTI' > ERROR: logging before flag.Parse: I0104 16:13:49.402435 22951 streamlog.go:141] Streaming logs from VTGate at /debug/querylog. This trick from kubernetes/kubernetes#17162 can suppress them, if you want.
Configuration menu - View commit details
-
Copy full SHA for f55a351 - Browse repository at this point
Copy the full SHA f55a351View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4977733 - Browse repository at this point
Copy the full SHA 4977733View commit details -
shutdownCh needs to be buffered
tpetr committedJan 4, 2018 Configuration menu - View commit details
-
Copy full SHA for ef0fb86 - Browse repository at this point
Copy the full SHA ef0fb86View commit details -
Merge pull request vitessio#3525 from slanning/master
suppress errors for package vtgate tests
Configuration menu - View commit details
-
Copy full SHA for a140329 - Browse repository at this point
Copy the full SHA a140329View commit details
Commits on Jan 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b9c6970 - Browse repository at this point
Copy the full SHA b9c6970View commit details -
tpetr committed
Jan 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 76b2322 - Browse repository at this point
Copy the full SHA 76b2322View commit details -
tpetr committed
Jan 5, 2018 Configuration menu - View commit details
-
Copy full SHA for bce10b4 - Browse repository at this point
Copy the full SHA bce10b4View commit details -
tpetr committed
Jan 5, 2018 Configuration menu - View commit details
-
Copy full SHA for c7cd32e - Browse repository at this point
Copy the full SHA c7cd32eView commit details -
tpetr committed
Jan 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 5d15f80 - Browse repository at this point
Copy the full SHA 5d15f80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0540a52 - Browse repository at this point
Copy the full SHA 0540a52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 593edd1 - Browse repository at this point
Copy the full SHA 593edd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dbed9f - Browse repository at this point
Copy the full SHA 5dbed9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fe19bf - Browse repository at this point
Copy the full SHA 4fe19bfView commit details -
refactor mysql OnTerm hook into its own function
tpetr committedJan 5, 2018 Configuration menu - View commit details
-
Copy full SHA for f5f5d8f - Browse repository at this point
Copy the full SHA f5f5d8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f688a8 - Browse repository at this point
Copy the full SHA 3f688a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5fe37a - Browse repository at this point
Copy the full SHA d5fe37aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bcfd7a - Browse repository at this point
Copy the full SHA 3bcfd7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7991ae - Browse repository at this point
Copy the full SHA d7991aeView commit details
Commits on Jan 8, 2018
-
simply track number of busy connections
tpetr committedJan 8, 2018 Configuration menu - View commit details
-
Copy full SHA for e8ed465 - Browse repository at this point
Copy the full SHA e8ed465View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca4cb76 - Browse repository at this point
Copy the full SHA ca4cb76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 229711d - Browse repository at this point
Copy the full SHA 229711dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ad3fc5 - Browse repository at this point
Copy the full SHA 4ad3fc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c52e58b - Browse repository at this point
Copy the full SHA c52e58bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f60a6b0 - Browse repository at this point
Copy the full SHA f60a6b0View commit details -
Merge pull request vitessio#3530 from jvaidya/init_config
Add "init_config" option to mysqlctl.
Configuration menu - View commit details
-
Copy full SHA for 02d4826 - Browse repository at this point
Copy the full SHA 02d4826View commit details -
Merge pull request vitessio#3531 from tinyspeck/export-grpc-version
export the grpc version as a debug var
Configuration menu - View commit details
-
Copy full SHA for f4fc774 - Browse repository at this point
Copy the full SHA f4fc774View commit details -
Configuration menu - View commit details
-
Copy full SHA for d56bd26 - Browse repository at this point
Copy the full SHA d56bd26View commit details
Commits on Jan 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f2122ea - Browse repository at this point
Copy the full SHA f2122eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86efbbc - Browse repository at this point
Copy the full SHA 86efbbcView commit details -
Merge pull request vitessio#3529 from tinyspeck/vtgate-querylog-to-file
add a flag to enable query logging to a file for vtgate
Configuration menu - View commit details
-
Copy full SHA for 9dcfd11 - Browse repository at this point
Copy the full SHA 9dcfd11View commit details -
Merge pull request vitessio#3534 from tinyspeck/vindex-show-statements
vindex show statements
Configuration menu - View commit details
-
Copy full SHA for de43b26 - Browse repository at this point
Copy the full SHA de43b26View commit details -
Merge pull request vitessio#3518 from HubSpot/vtgate-mysql-drain
drain mysql protocol connections to vtgate at shutdown
Configuration menu - View commit details
-
Copy full SHA for 6a55b81 - Browse repository at this point
Copy the full SHA 6a55b81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c81f81 - Browse repository at this point
Copy the full SHA 6c81f81View commit details -
Refactored tx_limiter API to only use callers, not context.
This makes API smaller and cleaner.
Configuration menu - View commit details
-
Copy full SHA for 9fd7aa2 - Browse repository at this point
Copy the full SHA 9fd7aa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c78ebe - Browse repository at this point
Copy the full SHA 1c78ebeView commit details -
A few small vtgate fixes / cleanups.
* Remove unused 'method string' from Executor.execute(). * Remove srv_topo_timeout flag from resilient_srv_topo_server. We can just used the provided context, no need to slap on a random timeout. * Update MessageStream comment, we do support multiple shards. * In vtgate SplitQuery, use closures directly, inside of wrapping them in a method.
Configuration menu - View commit details
-
Copy full SHA for faf6910 - Browse repository at this point
Copy the full SHA faf6910View commit details -
Moving topo.SrvTopoServer into srvtopo.Server.
The new package will also eventually contain: * the ResilientSrvTopoServer implementation of that interface. * helper methods to resolve cell/keyspace/shards.
Configuration menu - View commit details
-
Copy full SHA for b13e0cc - Browse repository at this point
Copy the full SHA b13e0ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for c413521 - Browse repository at this point
Copy the full SHA c413521View commit details
Commits on Jan 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 6a90256 - Browse repository at this point
Copy the full SHA 6a90256View commit details -
Moving some VSchema watch logic to srvtopo.
It's more consistent to have the watch code in srvtopo.
Configuration menu - View commit details
-
Copy full SHA for 6baafa2 - Browse repository at this point
Copy the full SHA 6baafa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb32a50 - Browse repository at this point
Copy the full SHA bb32a50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03a928f - Browse repository at this point
Copy the full SHA 03a928fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1d2b68 - Browse repository at this point
Copy the full SHA f1d2b68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d5870c - Browse repository at this point
Copy the full SHA 1d5870cView commit details -
explicitly enumerate the plan opcodes in the two cases
To clarify what is going on in the two cases of inside-a-transaction and not-in-a-transaction, explicitly enumerate all the expected plan opcodes and make the default case an error, rather than relying on default behavior.
Configuration menu - View commit details
-
Copy full SHA for 9e30fd7 - Browse repository at this point
Copy the full SHA 9e30fd7View commit details -
Merge pull request vitessio#3538 from tinyspeck/quiet-no-fieldcache-w…
…arning remove the verbose log when fieldinfo can't be cached
Configuration menu - View commit details
-
Copy full SHA for 635b518 - Browse repository at this point
Copy the full SHA 635b518View commit details -
Merge pull request vitessio#3540 from yangxuanjia/master
modify some comments
Configuration menu - View commit details
-
Copy full SHA for b4fcdb7 - Browse repository at this point
Copy the full SHA b4fcdb7View commit details -
Merge pull request vitessio#3527 from mswietochowski/txpool-limits
Transaction pool limits
Configuration menu - View commit details
-
Copy full SHA for 02ba9a7 - Browse repository at this point
Copy the full SHA 02ba9a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f42b407 - Browse repository at this point
Copy the full SHA f42b407View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17a6595 - Browse repository at this point
Copy the full SHA 17a6595View commit details -
* SrvVSchema update was not thread-safe. Now it is protected by the mutex. * Added a unit test for srvtopo.Server.WatchSrvVSchema.
Configuration menu - View commit details
-
Copy full SHA for 140f9ed - Browse repository at this point
Copy the full SHA 140f9edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bcbc69 - Browse repository at this point
Copy the full SHA 6bcbc69View commit details
Commits on Jan 11, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 2a7c1b4 - Browse repository at this point
Copy the full SHA 2a7c1b4View commit details -
Merge pull request vitessio#3528 from tinyspeck/vtgate-increase-qps-g…
…ranularity increase the frequency of vtgate qps rate metrics from 1m to 5s
Configuration menu - View commit details
-
Copy full SHA for 1f5d6e5 - Browse repository at this point
Copy the full SHA 1f5d6e5View commit details -
A 'not found' is not a vschema watch error any more.
Configuration menu - View commit details
-
Copy full SHA for 448c4f4 - Browse repository at this point
Copy the full SHA 448c4f4View commit details -
Merge pull request vitessio#3539 from alainjobart/vtgate
Vtgate refactors.
Configuration menu - View commit details
-
Copy full SHA for ca2a7f1 - Browse repository at this point
Copy the full SHA ca2a7f1View commit details -
Merge pull request vitessio#3541 from tinyspeck/query-executor-cleanup
query executor cleanup
Configuration menu - View commit details
-
Copy full SHA for f100a5d - Browse repository at this point
Copy the full SHA f100a5dView commit details
Commits on Jan 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9326dc2 - Browse repository at this point
Copy the full SHA 9326dc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ddeda7 - Browse repository at this point
Copy the full SHA 1ddeda7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17b3703 - Browse repository at this point
Copy the full SHA 17b3703View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73600e1 - Browse repository at this point
Copy the full SHA 73600e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dde522 - Browse repository at this point
Copy the full SHA 3dde522View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4175098 - Browse repository at this point
Copy the full SHA 4175098View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7e97bc - Browse repository at this point
Copy the full SHA b7e97bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56bf3b2 - Browse repository at this point
Copy the full SHA 56bf3b2View commit details -
Proto changes for aggregate stats.
This would allow re-using the current StreamHealthCheck to convey the status of a group of tablets, between vtgate and l2vtgate (which will be merged into vtgate).
Configuration menu - View commit details
-
Copy full SHA for ce32589 - Browse repository at this point
Copy the full SHA ce32589View commit details -
Configuration menu - View commit details
-
Copy full SHA for dea8a22 - Browse repository at this point
Copy the full SHA dea8a22View commit details -
Merge pull request vitessio#3552 from alainjobart/celltarget
Proto changes for aggregate stats.
Configuration menu - View commit details
-
Copy full SHA for 3f0b610 - Browse repository at this point
Copy the full SHA 3f0b610View commit details -
Merge pull request vitessio#3551 from tinyspeck/show-vitess-tablets
show vitess tablets
Configuration menu - View commit details
-
Copy full SHA for 56dd7f1 - Browse repository at this point
Copy the full SHA 56dd7f1View commit details
Commits on Jan 13, 2018
-
Merge pull request vitessio#3550 from tinyspeck/fix-nil-pointer-app-d…
…ebug Fix nil pointer exception when using appDebug feature
Configuration menu - View commit details
-
Copy full SHA for b21cd23 - Browse repository at this point
Copy the full SHA b21cd23View commit details -
v3: support for aggregation and sorting of TEXT
This change adds support for aggregating and sorting of columns that may need to follow collation rules. The feature depends on mysql's weight_string function that returns a lexically comparable value of any text column. If a group by or order by uses a text column like varchar, then v3 will additionally request the weight_string versions of such columns and perform ordering and aggregation using those values instead. The identification of a text column is currently based on a new "columns" field in the vschema that allows you to specify the type of each column. This part was implemented in a previous PR. Two approaches were possible: 1. Request additional weight_string values at the time of push-down. 2. Rewire the primitives to request and use the additional weight_string values during the Wireup phase. I went with option 2 because it minimizes overall impact of the code, which will allow us to yank this behavior out when we implement collation aware sorting in vtgate. Also, since all the weight_string columns get added at the end, we only have to truncate the rows before returning what's needed. The following changes were made: * sqltypes: result truncate functionality. * engine: Add TruncateColumnCount field that can be used to truncate a result if needed. * planbuilder: Change Wireup to check and request weight_strings. If weight_string was requested, set the row truncation to make sure that the weight_string values don't get passed on.
Configuration menu - View commit details
-
Copy full SHA for 9c08562 - Browse repository at this point
Copy the full SHA 9c08562View commit details -
Merge pull request vitessio#3522 from sougou/v3
v3: support for aggregation and sorting of TEXT
Configuration menu - View commit details
-
Copy full SHA for fe5e639 - Browse repository at this point
Copy the full SHA fe5e639View commit details -
vtgate: remove accidental vttablet dependency
Some copy-paste code introduced a dependency from vtgate to tabletserver, and ended up exporting all of vttablet's flags in vtgate. This PR fixes it.
Configuration menu - View commit details
-
Copy full SHA for 11d2639 - Browse repository at this point
Copy the full SHA 11d2639View commit details
Commits on Jan 14, 2018
-
Merge pull request vitessio#3555 from sougou/bugs
vtgate: remove accidental vttablet dependency
Configuration menu - View commit details
-
Copy full SHA for 2efa0df - Browse repository at this point
Copy the full SHA 2efa0dfView commit details
Commits on Jan 15, 2018
-
v3: cosmetic prep work for autocommit
This change is mostly cosmetic. Previously, vtgatepb.Session was the variable that the Executor shared through its layers. We now change it to share a SafeSession, which also encapsulates vtgatepb.Session, but it can carry additional state that lower layers can use to make instant-commit decisions. This additional flag will be added in the next iteration.
Configuration menu - View commit details
-
Copy full SHA for 75555d7 - Browse repository at this point
Copy the full SHA 75555d7View commit details
Commits on Jan 16, 2018
-
make "set session wait_timeout=1234" not error
Maybe more a request for comments than a pull request, since I'm not too confident I'm doing things right. This set query currently causes a syntax error (and is one of a couple queries blocking our testing). I added a "Scope" field to Set struct in ast.go. Updated sql.y to allow session/global in "set $scope ...". That was a little complicated because it caused a "shift-reduce conflict" which I solved by weirdly having separate set_session_or_global and show_session_or_global; and I added tokens for SESSION and GLOBAL, and that caused "SHOW ..." to break, so I ended up adding STATUS and VARIABLES tokens, too (I haven't worked with parsers before, don't know if this is sane) and a Scope field to Show struct. In executor.go I added the Scope field to the return of sqlparser.ExtractSetValues and make an error if it's "global", which is possibly wrong. Also not sure I handled wait_timeout correctly.. In vtexplain_vttablet.go I made it return an empty result in case of Set and Show statements. There was a create table test that used a "status" column, which now conflicted with the new reserved word. I changed the column name, though I'm not sure that's a good idea.. So let me know how WTF it is. :)
Scott Lanning committedJan 16, 2018 Configuration menu - View commit details
-
Copy full SHA for e5655b8 - Browse repository at this point
Copy the full SHA e5655b8View commit details -
The method it's in is already only called once, it log.Fatalf() if called more than once. Also, it already registers a gazillion of named stats, that would definitely fail if called again.
Configuration menu - View commit details
-
Copy full SHA for bda2483 - Browse repository at this point
Copy the full SHA bda2483View commit details -
Merge pull request vitessio#3556 from sougou/autocommit
v3: cosmetic prep work for autocommit
Configuration menu - View commit details
-
Copy full SHA for 04736af - Browse repository at this point
Copy the full SHA 04736afView commit details
Commits on Jan 17, 2018
-
Merge remote-tracking branch 'upstream/master'
Scott Lanning committedJan 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 3bddbdb - Browse repository at this point
Copy the full SHA 3bddbdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b486677 - Browse repository at this point
Copy the full SHA b486677View commit details -
add more logging and a max wait time to vtgate shutdown drain
Wait no more than 30 seconds for active vtgate mysql connections to drain, and emit a log every 2 seconds while waiting with the count of connections that we're waiting for.
Configuration menu - View commit details
-
Copy full SHA for b9d32c1 - Browse repository at this point
Copy the full SHA b9d32c1View commit details -
Few fixes related to tablets wait in vtgate.
Now both vtgate and l2vtgate will log.Fatal at start if they can't contact the topology server to get the list of SrvKeyspace and the individual SrvKeyspace objects. Make the WaitForTabletTypes correct. We used to wait for all tablet types for any shard in the keyspace partitions. It's not correct because a keyspace partition is only valid for a single tablet type, not all of them. In practice, this would only show during horizontal resharding when some shards are not in cells. Fixing this makes the code somewhat simpler though, as we can't have duplicate keyspace/shard/tablet type, no need to de-dup them, so using an array of Target instead of a map of keyspaceShard. As a side fix, the fake SrvKeyspace we used for some tabletconn tests had the wrong partition type. Now that we pay attention to it, had to fix that. BUG=72045104
Configuration menu - View commit details
-
Copy full SHA for 7c19135 - Browse repository at this point
Copy the full SHA 7c19135View commit details -
The parsing of flags in vtgate_test caused it to eat all flags including the ones used by the test package. This caused tests here to ignore things like -run, etc. I tried changing the init to TestMain. That didn't help. So, I'm removing the parsing call for now until we figure out a different way to fix this.
Configuration menu - View commit details
-
Copy full SHA for ae9396f - Browse repository at this point
Copy the full SHA ae9396fView commit details -
Merge pull request vitessio#3561 from sougou/bugs
vtgate: fix vtgate_test
Configuration menu - View commit details
-
Copy full SHA for d435aeb - Browse repository at this point
Copy the full SHA d435aebView commit details -
Merge pull request vitessio#3558 from alainjobart/simpler
Few fixes related to vtgate startup.
Configuration menu - View commit details
-
Copy full SHA for 98abe80 - Browse repository at this point
Copy the full SHA 98abe80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3968cbc - Browse repository at this point
Copy the full SHA 3968cbcView commit details
Commits on Jan 18, 2018
-
Merge pull request vitessio#3548 from dweitzman/update_alias_fix
Allow aliases in update statements
Configuration menu - View commit details
-
Copy full SHA for ee1dcc9 - Browse repository at this point
Copy the full SHA ee1dcc9View commit details -
Merge pull request vitessio#3557 from slanning/master
make "set session wait_timeout=1234" not error
Configuration menu - View commit details
-
Copy full SHA for 322c006 - Browse repository at this point
Copy the full SHA 322c006View commit details
Commits on Jan 19, 2018
-
add a planbuilder option to pass through DMLs
When PassthroughDMLs is set, then all update or delete queries are returned as PlanPassDML regardless of query type.
Configuration menu - View commit details
-
Copy full SHA for 1e29552 - Browse repository at this point
Copy the full SHA 1e29552View commit details -
add vttablet option to pass through all DMLs
Add a flag to the queryserver config that both configures the planbuilder to use PlanPassDML for all plans and allows those plans to execute even in statement based replication.
Configuration menu - View commit details
-
Copy full SHA for 2de23da - Browse repository at this point
Copy the full SHA 2de23daView commit details
Commits on Jan 21, 2018
-
bug: fix mycnf error propagation
This bug has confused many people because it just crashes vttablet with a mysterious SIGSEGV. The problem was a bug in the error propagation of mycnf which was using old panic style error handling. This also addresses what vitessio#3195 was trying to fix.
Configuration menu - View commit details
-
Copy full SHA for 09e80c2 - Browse repository at this point
Copy the full SHA 09e80c2View commit details -
bug: quote strings in parse errors
Alternate fix for vitessio#3247, along with test fixes.
Configuration menu - View commit details
-
Copy full SHA for eeef41a - Browse repository at this point
Copy the full SHA eeef41aView commit details -
Merge pull request vitessio#3059 from slanning/patch-2
document Ubuntu packages needed for `make test`
Configuration menu - View commit details
-
Copy full SHA for d2e2575 - Browse repository at this point
Copy the full SHA d2e2575View commit details
Commits on Jan 22, 2018
-
Merge pull request vitessio#3568 from sougou/bugs
bug: fix mycnf error propagation
Configuration menu - View commit details
-
Copy full SHA for 788962c - Browse repository at this point
Copy the full SHA 788962cView commit details -
Merge pull request vitessio#3569 from sougou/bugs2
bug: quote strings in parse errors
Configuration menu - View commit details
-
Copy full SHA for bf64d2e - Browse repository at this point
Copy the full SHA bf64d2eView commit details -
Revert "sort the vtexplain queries before outputting them"
This reverts commit 1f3a930. Sorting in fact makes the test output illogical for sequences where statements occur in the same time quantum since it inverts the causal ordering.
Configuration menu - View commit details
-
Copy full SHA for 2c78f0e - Browse repository at this point
Copy the full SHA 2c78f0eView commit details -
add execution mode option to vtexplain
Include an execution mode in the vtexplain options and refactor the tests to support different outputs for each execution mode. The mode doesn't yet change the behavior -- support for legacy autocommit and TwoPC to come in subsequent commits.
Configuration menu - View commit details
-
Copy full SHA for 0c08f88 - Browse repository at this point
Copy the full SHA 0c08f88View commit details -
Configuration menu - View commit details
-
Copy full SHA for c777315 - Browse repository at this point
Copy the full SHA c777315View commit details -
Configuration menu - View commit details
-
Copy full SHA for f16c5dc - Browse repository at this point
Copy the full SHA f16c5dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for aabed96 - Browse repository at this point
Copy the full SHA aabed96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a82a1f - Browse repository at this point
Copy the full SHA 0a82a1fView commit details -
remove json mode output from vtexplain tests
The json mode ends up being very verbose and prone to changes when the internals of the vtgate plan object change, so remove them from the vtexplain tests.
Configuration menu - View commit details
-
Copy full SHA for 12abecc - Browse repository at this point
Copy the full SHA 12abeccView commit details -
add a vtexplain test for json output
Check the structure of the vtexplain output without depending on the details of the Plan so that any future changes to the plan structure don't cause the vtexplain tests to need updating.
Configuration menu - View commit details
-
Copy full SHA for b4ec805 - Browse repository at this point
Copy the full SHA b4ec805View commit details -
Merge pull request vitessio#3532 from tinyspeck/vtexplain-test-other-…
…modes vtexplain support different modes
Configuration menu - View commit details
-
Copy full SHA for 1914a97 - Browse repository at this point
Copy the full SHA 1914a97View commit details -
add a separate allowUnsafeDMLs flag
Since PlanPassDML executions are fundamentally unsafe in SBR mode, they should not be allowed unless the user explicitly wants to enable them, so add a separate flag which is not exposed in a command line flag (but will be in vtqueryserver) to allow the unsafe statements when in SBR mode.
Configuration menu - View commit details
-
Copy full SHA for b204a25 - Browse repository at this point
Copy the full SHA b204a25View commit details
Commits on Jan 23, 2018
-
Add new Dockerfile tailored for Kubernetes
This needs to be added to the Docker Hub auto build process
Configuration menu - View commit details
-
Copy full SHA for 42b450d - Browse repository at this point
Copy the full SHA 42b450dView commit details -
- Allows for custom database images - Supports MySQL protocol - Upgrade to etcd2 topology server - Uses etcd-operator - Default pod affinity/anti-affinity - HPA for vtgates - Pod security context doesn’t allow root privileges - Supports default credential chains for GCS/S3 - Moves backup and other config to ConfigMap - Temporarily removes Orchestrator support - Vitess components log to stdout/stderr only - MySQL slow/error logs redirected to stdout - Removed syslog and hostPath mounts - Uses new vitess:k8s Docker image - Support regional failure domain affinity
Configuration menu - View commit details
-
Copy full SHA for 6775d26 - Browse repository at this point
Copy the full SHA 6775d26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85ab5d3 - Browse repository at this point
Copy the full SHA 85ab5d3View commit details -
add servenv helper routines for common logic on flag parsing
Add servenv.ParseFlags and servenv.ParseFlagsAndArgs to handle the common logic around parsing flags, handling the -version flag to print version, and verify that positional arguments either are or are not supplied as expected.
Configuration menu - View commit details
-
Copy full SHA for 489c422 - Browse repository at this point
Copy the full SHA 489c422View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1e5a57 - Browse repository at this point
Copy the full SHA d1e5a57View commit details -
ignore /*! mysql-specific */ comment statements
This is related to vitessio#3520 Also ignore /*!50708 mysql-version-specific */ comments. I'm not sure if it's a good idea. Instead of stripping leading comments, in case it's /*! ... */ we don't strip it, and consider it a new StmtComment statement type. (Not sure if that should be added to ast.go . I didn't.) I assumed this kind of comment was the only thing in the query, so if there's something like "/*! ... */ select ..." it wouldn't work. The handleComment in executor.go basically does nothing, returning &sqltypes.Result{}
Scott Lanning committedJan 23, 2018 Configuration menu - View commit details
-
Copy full SHA for cc06faf - Browse repository at this point
Copy the full SHA cc06fafView commit details -
Fixes test that asserts that changes to vschema are updated correctly…
… by topo watcher
Configuration menu - View commit details
-
Copy full SHA for 2c0aaa9 - Browse repository at this point
Copy the full SHA 2c0aaa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b61debd - Browse repository at this point
Copy the full SHA b61debdView commit details -
Configuration menu - View commit details
-
Copy full SHA for abad1c3 - Browse repository at this point
Copy the full SHA abad1c3View commit details -
Merge pull request vitessio#3564 from tinyspeck/queryserver-passthrou…
…gh-dmls passthrough DML option
Configuration menu - View commit details
-
Copy full SHA for 787ad0d - Browse repository at this point
Copy the full SHA 787ad0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9adf37 - Browse repository at this point
Copy the full SHA e9adf37View commit details -
Merge pull request vitessio#3573 from tinyspeck/handle-positional-arg…
…uments add positional argument validation
Configuration menu - View commit details
-
Copy full SHA for faa0672 - Browse repository at this point
Copy the full SHA faa0672View commit details -
Merge pull request vitessio#3574 from tinyspeck/fix-for-topo
Fix for refreshing schema after update
Configuration menu - View commit details
-
Copy full SHA for 90a8904 - Browse repository at this point
Copy the full SHA 90a8904View commit details -
Merge pull request vitessio#3575 from dweitzman/parse_status
Allow columns named 'status'
Configuration menu - View commit details
-
Copy full SHA for fccc652 - Browse repository at this point
Copy the full SHA fccc652View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a7f4df - Browse repository at this point
Copy the full SHA 5a7f4dfView commit details -
Merge pull request vitessio#3576 from slanning/comment-queries
ignore mysql-specific comment statements
Configuration menu - View commit details
-
Copy full SHA for 1b5c48f - Browse repository at this point
Copy the full SHA 1b5c48fView commit details -
docker: add minimal binary images
mysqlctld, vtctl, vtctld, vtgate, vttablet
Configuration menu - View commit details
-
Copy full SHA for 8501c83 - Browse repository at this point
Copy the full SHA 8501c83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b2aaab - Browse repository at this point
Copy the full SHA 6b2aaabView commit details
Commits on Jan 24, 2018
-
Configuration menu - View commit details
-
Copy full SHA for dd2be93 - Browse repository at this point
Copy the full SHA dd2be93View commit details -
v3: instant-commit for autocommit
If we are in autocommit mode and vtgate does not break a DML into smaller parts, then it has the opportunity to send that statement through to a vttablet as autocommit in a single round-trip. Reviewer instructions: @demmer: I'm not too sure about the vtexplain fixes, or if additional tests are required there. Extra scrutiny may be required there. Implementation notes: * SafeSession has a state machine for tracking autocommit state. * The autocommit state is initialized by executor as needed. * VCursor API has been changed for ExecMultiShard. It now accepts an extra canCommit flag that should be set to true if the engine is executing its final DML. This, combined with the autocommit state will decide if an instant autocommit is possible.
Configuration menu - View commit details
-
Copy full SHA for 3f86922 - Browse repository at this point
Copy the full SHA 3f86922View commit details -
Merge pull request vitessio#3559 from sougou/autocommit
v3: instant-commit for autocommit
Configuration menu - View commit details
-
Copy full SHA for 3e39b05 - Browse repository at this point
Copy the full SHA 3e39b05View commit details -
moved VARIABLES to non_reserved_keyword
This also fixes an omission from b61debd to remove the extra STATUS left in reserved_keyword . (I wasn't sure about GLOBAL and SESSION from my previous commit e5655b8 , so I left them for now but possibly they also should be in non_reserved_keyword.)
Scott Lanning committedJan 24, 2018 Configuration menu - View commit details
-
Copy full SHA for 4d65037 - Browse repository at this point
Copy the full SHA 4d65037View commit details
Commits on Jan 25, 2018
-
Merge pull request vitessio#3583 from derekperkins/binary-specific-do…
…ckerfiles Create and use minimal docker images in Kubernetes
Configuration menu - View commit details
-
Copy full SHA for 5fe41bf - Browse repository at this point
Copy the full SHA 5fe41bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 406ae81 - Browse repository at this point
Copy the full SHA 406ae81View commit details -
Merge pull request vitessio#3587 from enisoc/docker-vtctlclient
docker: Add vtctlclient image.
Configuration menu - View commit details
-
Copy full SHA for 1cbceba - Browse repository at this point
Copy the full SHA 1cbcebaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1e64ed - Browse repository at this point
Copy the full SHA b1e64edView commit details -
also move GLOBAL and SESSION keywords to non_reserved_keyword
Didn't cause shift-reduce conflicts.
Scott Lanning committedJan 25, 2018 Configuration menu - View commit details
-
Copy full SHA for be7e755 - Browse repository at this point
Copy the full SHA be7e755View commit details -
bug: DML_SUBQUERY should suppress index hints
BUG=72403076 Since DML_SUBQUERY rewrites updates to use pk, it should suppress index hints, because those should only be used by the SELECT.
Configuration menu - View commit details
-
Copy full SHA for 1d67a90 - Browse repository at this point
Copy the full SHA 1d67a90View commit details -
Merge pull request vitessio#3585 from slanning/non-reserved-keywords2
moved GLOBAL, SESSION, and VARIABLES to non_reserved_keyword
Configuration menu - View commit details
-
Copy full SHA for 46af0b1 - Browse repository at this point
Copy the full SHA 46af0b1View commit details -
Merge pull request vitessio#3588 from tinyspeck/include-serving-state…
…-in-show-tablets add a serving state column to show vitess_tablets
Configuration menu - View commit details
-
Copy full SHA for 36f02b9 - Browse repository at this point
Copy the full SHA 36f02b9View commit details -
Merge pull request vitessio#3560 from tinyspeck/vtgate-mysql-server-d…
…rain-logs add logging and a max wait time to vtgate shutdown drain
Configuration menu - View commit details
-
Copy full SHA for 4a3f148 - Browse repository at this point
Copy the full SHA 4a3f148View commit details -
Merge pull request vitessio#3589 from sougou/bugs
bug: DML_SUBQUERY should suppress index hints
Configuration menu - View commit details
-
Copy full SHA for cca6112 - Browse repository at this point
Copy the full SHA cca6112View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bc4ebc - Browse repository at this point
Copy the full SHA 0bc4ebcView commit details -
Merge pull request vitessio#3590 from sougou/bugs
bugs: add test for 'force index' for RemoveHints
Configuration menu - View commit details
-
Copy full SHA for 43aaa50 - Browse repository at this point
Copy the full SHA 43aaa50View commit details
Commits on Jan 26, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9a49113 - Browse repository at this point
Copy the full SHA 9a49113View commit details -
helm: add liveness probe to mysql container
uses mysqladmin ping
Configuration menu - View commit details
-
Copy full SHA for 5c0ae3d - Browse repository at this point
Copy the full SHA 5c0ae3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ae9ac6 - Browse repository at this point
Copy the full SHA 7ae9ac6View commit details
Commits on Jan 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c4fffdd - Browse repository at this point
Copy the full SHA c4fffddView commit details -
helm: remove mysql livenessProbe
MySQL keeps a lot of state in memory, so we don’t want to lose it unnecessarily
Configuration menu - View commit details
-
Copy full SHA for b434853 - Browse repository at this point
Copy the full SHA b434853View commit details -
Merge pull request vitessio#3584 from derekperkins/mysql-liveness-probe
helm: update liveness probes
Configuration menu - View commit details
-
Copy full SHA for 83866b3 - Browse repository at this point
Copy the full SHA 83866b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f0bc14 - Browse repository at this point
Copy the full SHA 8f0bc14View commit details -
add a reusable mysqlproxy module
Modeling after the vtgate mysql server implementation, add a simple module that implements the mysql server protocol handlers and proxies all requests to the appropriate methods in a queryservice backend. This includes optional support for query normalization.
Configuration menu - View commit details
-
Copy full SHA for f786a06 - Browse repository at this point
Copy the full SHA f786a06View commit details -
Add a binary to wrap a standalone queryservice with a grpc service interface and a mysql server implementation using the mysqlproxy module to direct to the queryservice.
Configuration menu - View commit details
-
Copy full SHA for 5e7254e - Browse repository at this point
Copy the full SHA 5e7254eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb33739 - Browse repository at this point
Copy the full SHA bb33739View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1fdd3e - Browse repository at this point
Copy the full SHA e1fdd3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a75a754 - Browse repository at this point
Copy the full SHA a75a754View commit details -
rework the proxy implementation of autocommit to match mysql
Following the example of vtgate, add support to set autocommit on or off in the session, update the execution path to use ExecuteBatch for single round-trip autocommit semantics, and add tests to ensure the behavior matches mysql.
Configuration menu - View commit details
-
Copy full SHA for 45ad926 - Browse repository at this point
Copy the full SHA 45ad926View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b3048f - Browse repository at this point
Copy the full SHA 2b3048fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ea8013 - Browse repository at this point
Copy the full SHA 0ea8013View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc7ffa9 - Browse repository at this point
Copy the full SHA bc7ffa9View commit details
Commits on Jan 29, 2018
-
add proxy support for other statements
This allows EXPLAIN and other such statements to go through without query normalization.
Configuration menu - View commit details
-
Copy full SHA for 4a44d25 - Browse repository at this point
Copy the full SHA 4a44d25View commit details -
Configuration menu - View commit details
-
Copy full SHA for d48e84a - Browse repository at this point
Copy the full SHA d48e84aView commit details