Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clusters list openapi doc #522

Merged
merged 4 commits into from
May 12, 2022
Merged

Clusters list openapi doc #522

merged 4 commits into from
May 12, 2022

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented May 12, 2022 •
edited
Loading

  • GET /api/hosts
  • GET /api/clusters
  • GET /api/sap_systems
  • GET /api/databases
  • GET /api/checks/catalog
  • POST /api/clusters/:cluster_id/checks
  • POST /api/clusters/:cluster_id/checks/request_execution
  • POST /api/runner/callback

For extra information see here #512

fabriziosestito
fabriziosestito reviewed May 12, 2022
View reviewed changes
lib/trento_web/openapi/schema/host.ex Outdated
description: "Detected Provider on which the host is running",
enum: [:azure, :aws, :gcp, :unknown]
},
provider: TrentoWeb.OpenApi.Schema.Provider.SupportedProviders,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use aliases for this long module names (maybe just aliasing TrentoWeb.OpenApi.Schema)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, made some polishing here f372b79

fabriziosestito
fabriziosestito approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nitpick you are free to ignore (just not sure why credo is not complaining about it)

@nelsonkopliku nelsonkopliku merged commit 2a660e1 into main May 12, 2022
@nelsonkopliku nelsonkopliku deleted the clusters_list_openapi_doc branch May 12, 2022 13:30
@nelsonkopliku nelsonkopliku mentioned this pull request May 13, 2022
Merged
8 tasks
@nelsonkopliku nelsonkopliku added documentation Improvements or additions to documentation enhancement New feature or request labels May 16, 2022
@nelsonkopliku nelsonkopliku self-assigned this May 16, 2022
This was referenced May 16, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 24, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@arbulu89 arbulu89 Awaiting requested review from arbulu89

@dottorblaster dottorblaster Awaiting requested review from dottorblaster

@rtorrero rtorrero Awaiting requested review from rtorrero

@stefanotorresi stefanotorresi Awaiting requested review from stefanotorresi

Assignees

@nelsonkopliku nelsonkopliku

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonkopliku @fabriziosestito