Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner callback api #569

Merged
merged 4 commits into from
May 20, 2022
Merged

Runner callback api #569

merged 4 commits into from
May 20, 2022

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented May 20, 2022 •
edited
Loading

image
image
image

  • GET /api/hosts
  • GET /api/clusters
  • GET /api/sap_systems
  • GET /api/databases
  • GET /api/checks/catalog
  • POST /api/clusters/:cluster_id/checks
  • POST /api/clusters/:cluster_id/checks/request_execution
  • POST /api/runner/callback
  • GET /api/installation/api-key
  • GET /api/sap_systems/health
  • GET /api/about
  • GET /api/settings
  • POST /api/accept_eula

Follows up #512 #522 #528 #536 #546 #558

Base automatically changed from request_execution_openapi to main May 20, 2022 11:47
@nelsonkopliku nelsonkopliku force-pushed the runner_callback_api branch from 34efa04 to d6f4f5d Compare May 20, 2022 11:49
@nelsonkopliku nelsonkopliku force-pushed the runner_callback_api branch from d6f4f5d to c04c21d Compare May 20, 2022 11:56
@nelsonkopliku nelsonkopliku marked this pull request as ready for review May 20, 2022 11:56
arbulu89
arbulu89 approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another green light!
Go!

PD: Excellent work documenting the PR itself by the way!

lib/trento_web/openapi/schema/runner.ex
require OpenApiSpex
alias OpenApiSpex.Schema

defmodule ResourceIdentifier do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we are already visualizing and environment where we can run checks beyond only clusters hehe

Otherwise, I would call this ClusterIdentifier.
But I find it totally fine as it is

@nelsonkopliku nelsonkopliku merged commit 58df9d0 into main May 20, 2022
@nelsonkopliku nelsonkopliku deleted the runner_callback_api branch May 20, 2022 13:27
@nelsonkopliku nelsonkopliku mentioned this pull request May 20, 2022
Merged
13 tasks
@nelsonkopliku nelsonkopliku self-assigned this May 20, 2022
@nelsonkopliku nelsonkopliku added documentation Improvements or additions to documentation enhancement New feature or request labels May 20, 2022
This was referenced May 23, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

@dottorblaster dottorblaster Awaiting requested review from dottorblaster

@fabriziosestito fabriziosestito Awaiting requested review from fabriziosestito

@rtorrero rtorrero Awaiting requested review from rtorrero

@stefanotorresi stefanotorresi Awaiting requested review from stefanotorresi

Assignees

@nelsonkopliku nelsonkopliku

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonkopliku @arbulu89