Sap systems and Databases openapi #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
requested review from
arbulu89,
fabriziosestito,
dottorblaster,
rtorrero and
stefanotorresi
arbulu89
requested changes
May 13, 2022
There was a problem hiding this comment.
Hey @nelsonkopliku ,
Nice job. I have just found some missmatches in the types, some descriptions and tiny details.
| features: %Schema{type: :string, description: "Instance Features"}, | ||
| http_port: %Schema{type: :integer, description: "Instance HTTP Port"}, | ||
| https_port: %Schema{type: :integer, description: "Instance HTTPS Port"}, | ||
| start_priority: %Schema{type: :string, description: "Instance Start Priority"}, |
There was a problem hiding this comment.
The instance priority is a number with decimals
There was a problem hiding this comment.
Interesting, we're defining it as a string in commands, events and readmodels.
I'll keep it like this and create an item in the backlog if that's ok.
There was a problem hiding this comment.
Totally fine! We don't do anything more than displaying it, so string is even good for us
nelsonkopliku
force-pushed
the
sap_systems_openapi
branch
from
60fbbd9 to
2e90f57
Compare
Elixir! 😂 |
nelsonkopliku
added
documentation
This was referenced May 16, 2022
Merged
Merged
Merged
This was referenced May 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For extra information see here
#512
#522