Add zipWith #1883
Closed
Add zipWith #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1883 +/- ##
==========================================
+ Coverage 94.97% 94.97% +<.01%
==========================================
Files 241 241
Lines 4199 4202 +3
Branches 106 112 +6
==========================================
+ Hits 3988 3991 +3
Misses 211 211
Continue to review full report at Codecov.
|
* Added more implementations of map2Eval I hit a case where I wanted laziness with map2Eval and realized in many cases where we could have it, we do not. There were all the cases I saw that we missed, which I hope our existing tests cover. * Add tests for map2 and map2Eval * remove incorrect instances
I've verified this with `bench/jmh:run` which still runs benchmarks :)
This is a proposal to add `origami` to the list of Typelevel projects. However if I remember correctly one of the criteria for being part of the system is to have a compiler-checked documentation which doesn't exist anymore (it was there on a previous version of the library). I will add it and maybe then we can merge in this PR? Is anything else needed?
This is for your consideration. Grafter uses `Reader` instances for component dependencies and `Eval` for actions starting-up the application graph.
…el#1852) sbt-ghpages is a dependency of sbt-microsites and therefore does not need to be listed explicitly as plugin. We have the same situation with tut whose keys we are using in our `build.sbt` but do not explicitly list in `plugins.sbt`.
* Bump scalatest version to 3.0.3 * Bump scalatest version to 3.0.4
Both settings check if the `TRAVIS` environment variable is set.
This version also supports sbt 1.0.0.
This is a cosmetic change that has been possible since sbt 0.13.8: https://github.com/sbt/sbt/releases/tag/v0.13.8
`doctestWithDependencies` has been removed upstream since the plugin does not automatically add dependencies anymore.
* Limit runtime of monad loop tests * Do not use Either syntax in monad loops * Add iterateWhileM and iterateUntilM * Implement iterateWhile in terms of iterateWhileM
Using parentheses for disabling tasks with sbt 1.0 will issue the
following deprecation warning:
```
warning: Adaptation of argument list by inserting () is deprecated: this
is unlikely to be what you want.
signature: DefinableTask.:=(v: S): sbt.Def.Setting[sbt.Task[S]]
given arguments: <none>
after adaptation: DefinableTask.:=((): Unit)
publish := (),
^
```
This can be fixed with curly braces which is also perfectly fine with
sbt 0.13. So this can be merged right now and will make the actual
upgrade to sbt 1.0 easier.
LukaJCB
force-pushed
the
add-zip-with
branch
2 times, most recently
from
4b500d0 to
badbf53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.