Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement protocol level min gas price #1017

Open
4 tasks
robert-zaremba opened this issue Jun 14, 2022 · 1 comment
Open
4 tasks

Implement protocol level min gas price #1017

robert-zaremba opened this issue Jun 14, 2022 · 1 comment
Assignees
@robert-zaremba
Labels
T:Security
Milestone
v4

Comments

@robert-zaremba
Copy link
Member

Summary

Currently we don't have protocol guarded min gas price which can lead to network spam attacks.

Proposal

  • Add a gov param for min gas price.
  • Validators will need to update the gas price accordingly.
  • The update has to be clearly communicated, otherwise validators with lower gas price will be kicked out and we risk chain halt.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added this to the Calypso milestone Jun 14, 2022
@robert-zaremba robert-zaremba self-assigned this Jun 21, 2022
@robert-zaremba robert-zaremba mentioned this issue Aug 4, 2022
Closed
4 tasks
@robert-zaremba
Copy link
Member Author

we will test it in beta ~ next week.

@robert-zaremba robert-zaremba mentioned this issue Sep 2, 2022
Merged
17 tasks
@robert-zaremba robert-zaremba modified the milestones: v3 - Calypso, v4 Sep 2, 2022
mergify bot pushed a commit that referenced this issue Sep 8, 2022
@robert-zaremba
feat: setting protocol controlled min gas price (#1326)
49a5dbd 
## Description

Closes: #1214

This is a "v1" solution for requiring min-gas price. More flexible mechanism ([#1017](#1017)) we will develop for v4 (or v5).

Notes:
+ added `fee-notes.md` files with stats for the fees.

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robert-zaremba robert-zaremba

Labels
T:Security
Projects
None yet
Milestone
v4
Development

No branches or pull requests
1 participant
@robert-zaremba