Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setting protocol controlled min gas price #1326

Merged
merged 60 commits into from
Sep 8, 2022
Merged

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented Sep 2, 2022

Description

Closes: #1214

This is a "v1" solution for requiring min-gas price. More flexible mechanism (#1017) we will develop for v4 (or v5).

Notes:

  • added fee-notes.md files with stats for the fees.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba added C:x/oracle C:Core Core app features labels Sep 2, 2022
@robert-zaremba robert-zaremba requested a review from a team as a code owner September 2, 2022 16:54
@robert-zaremba robert-zaremba requested review from a team as code owners September 2, 2022 17:19
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #1326 (fc9fc23) into main (5cbf948) will increase coverage by 0.24%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
+ Coverage   52.22%   52.46%   +0.24%     
==========================================
  Files          69       70       +1     
  Lines        6836     6877      +41     
==========================================
+ Hits         3570     3608      +38     
- Misses       2988     2990       +2     
- Partials      278      279       +1     
Impacted Files Coverage Δ
ante/spam_prevention.go 75.92% <0.00%> (-1.44%) ⬇️
x/leverage/client/tests/suite.go 95.45% <93.33%> (-0.20%) ⬇️
ante/fee.go 90.29% <95.74%> (+0.54%) ⬆️
util/genmap/genmap.go 100.00% <100.00%> (ø)
x/leverage/client/tests/tests.go 100.00% <100.00%> (ø)
x/leverage/module.go 58.73% <100.00%> (ø)
x/leverage/simulation/operations.go 76.95% <100.00%> (-1.07%) ⬇️
x/oracle/client/tests/suite.go 98.38% <100.00%> (ø)
x/oracle/keeper/keeper.go 84.50% <100.00%> (ø)

@robert-zaremba robert-zaremba marked this pull request as draft September 2, 2022 18:49
@robert-zaremba robert-zaremba force-pushed the robert/tx-fees branch 2 times, most recently from 72d904d to 7109f84 Compare September 2, 2022 21:51
@robert-zaremba robert-zaremba force-pushed the robert/tx-fees branch 2 times, most recently from 5893f6a to bed21c5 Compare September 3, 2022 09:16
@robert-zaremba robert-zaremba marked this pull request as ready for review September 6, 2022 22:25
Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! @RafilxTenfen asked the questions I was going to lol

might be worth adding changelog here @robert-zaremba

@adamewozniak
Copy link
Collaborator

@RafilxTenfen can you check on why the v1->v3 test is failing? https://github.com/umee-network/umee/runs/8257796548?check_suite_focus=true

I think everything else is g2g

@mergify mergify bot merged commit 49a5dbd into main Sep 8, 2022
@mergify mergify bot deleted the robert/tx-fees branch September 8, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small fee should be applied for oracle transactions
5 participants