Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-2747: update cypress and php in circleci #944

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Vote-2747: update cypress and php in circleci #944

merged 2 commits into from
Sep 4, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Aug 28, 2024 •
edited by rayestrada
Loading

Jira ticket

Vote-2747

Description

Updating PHP and Cypress version within the circleci config file.

  • PHP was updated to 8.3
  • Cypress was updated to run with the latest version documentation on latest version docker image
  • Benefits on using latest -> Will always run the most updated version of cypess and will allow us to not become behind.
  • Cons on using latest -> Will be a chance that local and pipeline version will be our of sync... however this could help flag any issues a new version might cause us in the future

Deployment and testing

Post-deploy steps

n/a

QA/Testing instructions

  1. review file changes and verify that PHP and Cypress has been updated
  2. Test run with updates located here for review

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review August 28, 2024 16:28
@clmedders clmedders requested a review from rayestrada August 29, 2024 14:57
@rayestrada rayestrada merged commit dc840d4 into dev Sep 4, 2024
3 checks passed
tt-gsa pushed a commit that referenced this pull request Sep 10, 2024
@daniel-crowder @clmedders
@mlloydbixal @rayestrada @SamiraMSadat
Sprint 67 release candidate to STAGE (#966)
65c5418 
* VOTE-2534: Revert upkeep sync file change (#955)

* Vote-2747: update cypress and php version in circleci (#944)

* VOTE-2588: add id to feature card component heading (#958)

* VOTE-2777 add alternate route for Spanish NVRF (#951)

* VOTE-2777 add alternate route for Spanish NVRF

* VOTE-2777 override language switcher for custom route

* phplint fixes

* VOTE-2777 make sure back link recognized language

* VOTE-2777 simplify the form display for the NVRF block

* VOTE-2604: Update drupal core and modules. (#956)

* VOTE-2791 add view revision permissions to content manager and content editor (#959)

* Vote-2655: French Updated Strings (#961)

* VOTE-2275: Enable and configure stage file proxy (#964)

* VOTE-2797 Make the field NVRF PDF pages translatable (#967)

* VOTE-2764: Implement loading animation on NVRF page for slow page load (#963)

* VOTE-2646: Update Arabic Strings (#965)

* VOTE-2802 NVRF updates (#968)

* VOTE-2802 update NVRF to v0.17.0

* VOTE-2802 Remove language selector from nvrf page routes

* VOTE-2802 update path for Spanish NVRF route

* bugfix NVRF svg styling

* Vote-2123: Verify Language options are active (#970)

* Vote-2123: Verify Language optionsq are active

* remove .only flag

---------

Co-authored-by: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Co-authored-by: Mandy Lloyd <amanda.lloyd@gsa.gov>
Co-authored-by: Ray Estrada <raymond.estrada@gsa.gov>
Co-authored-by: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
@rayestrada rayestrada deleted the feature/vote-2747-circleci-updates branch September 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @rayestrada