Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2802 NVRF updates #968

Merged
merged 4 commits into from
Sep 9, 2024
Merged

VOTE-2802 NVRF updates #968

merged 4 commits into from
Sep 9, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Sep 6, 2024 •
edited
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2802

Description

  • Update NVRF to v0.17.0
  • Remove the language selector from the NVRF page routes
  • Update the NVRF Spanish page route path: /llenador-de-formulario-por-correo-postal

Deployment and testing

Post-deploy steps

  1. cd in vote_nvrf and run npm i
  2. run lando drush cr

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/register/washington/mail-in-form-filler and test the latest verison of the NVRF and confirm it successfully creates an English PDF.
  2. Confirm the language selector is removed on this page
  3. visit http://vote-gov.lndo.site/es/registrar/washington/llenador-de-formulario-por-correo-postal and confirm that the NVRF loads on that page and confirm it successfully creates a Spanish PDF.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

SamiraMSadat
SamiraMSadat approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@SamiraMSadat SamiraMSadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now so we can release English. We have created a separate bug ticket for Spanish to resolve a PDF load issue

@rayestrada rayestrada merged commit 0daf91c into dev Sep 9, 2024
3 checks passed
tt-gsa pushed a commit that referenced this pull request Sep 10, 2024
@daniel-crowder @clmedders
@mlloydbixal @rayestrada @SamiraMSadat
Sprint 67 release candidate to STAGE (#966)
65c5418 
* VOTE-2534: Revert upkeep sync file change (#955)

* Vote-2747: update cypress and php version in circleci (#944)

* VOTE-2588: add id to feature card component heading (#958)

* VOTE-2777 add alternate route for Spanish NVRF (#951)

* VOTE-2777 add alternate route for Spanish NVRF

* VOTE-2777 override language switcher for custom route

* phplint fixes

* VOTE-2777 make sure back link recognized language

* VOTE-2777 simplify the form display for the NVRF block

* VOTE-2604: Update drupal core and modules. (#956)

* VOTE-2791 add view revision permissions to content manager and content editor (#959)

* Vote-2655: French Updated Strings (#961)

* VOTE-2275: Enable and configure stage file proxy (#964)

* VOTE-2797 Make the field NVRF PDF pages translatable (#967)

* VOTE-2764: Implement loading animation on NVRF page for slow page load (#963)

* VOTE-2646: Update Arabic Strings (#965)

* VOTE-2802 NVRF updates (#968)

* VOTE-2802 update NVRF to v0.17.0

* VOTE-2802 Remove language selector from nvrf page routes

* VOTE-2802 update path for Spanish NVRF route

* bugfix NVRF svg styling

* Vote-2123: Verify Language options are active (#970)

* Vote-2123: Verify Language optionsq are active

* remove .only flag

---------

Co-authored-by: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Co-authored-by: Mandy Lloyd <amanda.lloyd@gsa.gov>
Co-authored-by: Ray Estrada <raymond.estrada@gsa.gov>
Co-authored-by: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
@rayestrada rayestrada deleted the feature/VOTE-2802-nvrf-updates branch September 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamiraMSadat SamiraMSadat SamiraMSadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @SamiraMSadat