Fix Travis CI failures

[jack-oquin]

While we're at it, we need to figure out how to run valid Travis tests on ROS Kinetic. That looks tricky, but I'm sure some people must be doing it.

[nickswalker]

I took a whack at using ROS Industrial's setup on this branch of segbot_arm. It is functional (though to pass without kinetic releases, we would have to modify the configuration to pull all BWI code from source). Their approach of loading a ROS docker image should insulate us from issues like those we faced with the July Travis image change.

[jack-oquin]

Good to know. Thanks for the pointer, Nick.

[jack-oquin]

I tried using the ROS-I test tool in the kinetic branch, as Nick suggested.

I probably don't understand all there is to it yet.

[jack-oquin]

Getting closer. Failed in the build step for kinova_demo:

Starting  >>> kinova_demo                                   
_______________________________________________________________________________
Errors     << kinova_demo:cmake /root/catkin_ws/logs/kinova_demo/build.cmake.000.log
CMake Error at /root/catkin_ws/install/share/kinova_driver/cmake/kinova_driverConfig.cmake:148 (message):
  Project 'kinova_demo' tried to find library 'kinova_driver'.  The library
  is neither a target nor built/installed properly.  Did you compile project
  'kinova_driver'? Did you find_package() it before the subdirectory
  containing its code is included?
Call Stack (most recent call first):
  /opt/ros/kinetic/share/catkin/cmake/catkinConfig.cmake:76 (find_package)
  CMakeLists.txt:7 (find_package)

Travis link: https://travis-ci.org/utexas-bwi/bwi_common/jobs/335396370

[jack-oquin]

I guess we need separate Travis configurations for the different branches. There's no point in compiling the kinetic branch on Indigo.

[jack-oquin]

It's possible that the kinova driver may not install all its files correctly. We normally build it in devel space. I should try an install-space build to see what happens.

[jack-oquin]

Commit 96cd6c5 uses the ROS-I tools to run master on ROS Indigo, a simpler build than the current Kinetic branch. That may demonstrate whether the problem is in kinova-ros or not.

[jack-oquin]

Yes! Master does succeed on Indigo: https://travis-ci.org/utexas-bwi/bwi_common/builds/335651370?utm_source=email&utm_medium=notification

Now, I need to figure out what the problem is with kinova-ros.

[jack-oquin]

I am able to reproduce the kinova_demo build failure by compiling into install space:

 $ catkin config --install
 $ catkin build

That seems to indicate a CMake install() error somewhere in kinova-ros.

[jack-oquin]

Configuring Travis not to build into install space worked!

Since I'm fairly sure the install problem is in kinova-ros and not here, I'm going to close this issue as fixed and open a new one there.