Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: replace select components through new and improve version #4295

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

sjschlapbach
Copy link
Member

@sjschlapbach sjschlapbach commented Oct 5, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Updated the @uzh-bf/design-system dependency across multiple applications to version 3.0.0-alpha.31, enhancing overall performance and stability.
  • Improvements

    • Enhanced styling and layout for various components, including Select, EvaluationFooter, and LanguageSetting, improving user experience and interface consistency.
    • Added new properties and refined existing components for better functionality, such as improved dropdown positioning and updated class definitions for better alignment.
  • Bug Fixes

    • Resolved layout issues in components like FeedbackSearchAndFilters and EvaluationControlBar to ensure proper display of elements.

Copy link

aviator-app bot commented Oct 5, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link

coderabbitai bot commented Oct 5, 2024

📝 Walkthrough

Walkthrough

This pull request includes updates to multiple package.json files across various applications and packages, primarily focusing on incrementing the version of the @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31. Additionally, it features modifications to several React components, enhancing their styling and functionality, particularly in relation to Select components and form handling. The changes aim to improve the user interface and maintain consistent behavior across the projects.

Changes

File Path Change Summary
apps/auth/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.
apps/backend-docker/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.
apps/docs/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.
apps/frontend-control/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.
apps/frontend-manage/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.
apps/frontend-manage/src/components/evaluation/EvaluationFooter.tsx Updated Select component's className and onChange event handler.
apps/frontend-manage/src/components/evaluation/navigation/InstanceNavigation.tsx Updated trigger class in Select component.
apps/frontend-manage/src/components/interaction/feedbacks/FeedbackSearchAndFilters.tsx Adjusted layout and structure of JSX elements, including Checkbox handlers.
apps/frontend-manage/src/components/questions/QuestionEditModal.tsx Enhanced FormikSelectField components and refined rendering logic for fields.
apps/frontend-manage/src/components/sessions/creation/MultiplierSelector.tsx Updated className prop for FormikSelectField.
apps/frontend-manage/src/components/sessions/evaluation/EvaluationControlBar.tsx Modified logic for generating shortLabel in selectData array and updated trigger class.
apps/frontend-manage/src/components/user/DelegatedAccessSettings.tsx Expanded className definition for FormikSelectField.
apps/frontend-manage/src/components/user/LanguageSetting.tsx Updated className property for Select component.
apps/frontend-manage/src/components/user/SuspendedFirstLoginModal.tsx Modified className for FormikSelectField.
apps/frontend-manage/src/pages/index.tsx Added contentPosition to Select component and updated item class.
apps/frontend-manage/src/pages/sessions/[id]/evaluation.tsx Updated Select component's trigger width.
apps/frontend-pwa/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.
apps/frontend-pwa/src/components/common/Header.tsx Updated Select component's className and added contentPosition.
apps/frontend-pwa/src/components/forms/AvatarUpdateForm.tsx Updated trigger property of select class.
apps/func-incoming-responses/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.
apps/func-response-processor/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.
apps/office-addin/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.
packages/markdown/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.
packages/shared-components/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.
packages/shared-components/src/LanguageChanger.tsx Removed className prop from interface and updated trigger style.
packages/transactional/package.json Updated @uzh-bf/design-system dependency from 3.0.0-alpha.30 to 3.0.0-alpha.31.

Possibly related PRs

Suggested reviewers

  • rschlaefli: Suggested reviewer for the changes made in this pull request.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6d47105 and 4fa5b55.

⛔ Files ignored due to path filters (2)
  • packages/shared-components/dist/utilities.css is excluded by !**/dist/**
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (27)
  • apps/auth/package.json (1 hunks)
  • apps/backend-docker/package.json (1 hunks)
  • apps/docs/package.json (1 hunks)
  • apps/frontend-control/package.json (1 hunks)
  • apps/frontend-control/src/components/layout/Header.tsx (2 hunks)
  • apps/frontend-manage/package.json (1 hunks)
  • apps/frontend-manage/src/components/evaluation/EvaluationFooter.tsx (2 hunks)
  • apps/frontend-manage/src/components/evaluation/navigation/InstanceNavigation.tsx (1 hunks)
  • apps/frontend-manage/src/components/interaction/feedbacks/FeedbackSearchAndFilters.tsx (2 hunks)
  • apps/frontend-manage/src/components/questions/QuestionEditModal.tsx (4 hunks)
  • apps/frontend-manage/src/components/sessions/creation/MultiplierSelector.tsx (1 hunks)
  • apps/frontend-manage/src/components/sessions/evaluation/EvaluationControlBar.tsx (2 hunks)
  • apps/frontend-manage/src/components/user/DelegatedAccessSettings.tsx (1 hunks)
  • apps/frontend-manage/src/components/user/LanguageSetting.tsx (1 hunks)
  • apps/frontend-manage/src/components/user/SuspendedFirstLoginModal.tsx (1 hunks)
  • apps/frontend-manage/src/pages/index.tsx (2 hunks)
  • apps/frontend-manage/src/pages/sessions/[id]/evaluation.tsx (1 hunks)
  • apps/frontend-pwa/package.json (1 hunks)
  • apps/frontend-pwa/src/components/common/Header.tsx (1 hunks)
  • apps/frontend-pwa/src/components/forms/AvatarUpdateForm.tsx (1 hunks)
  • apps/func-incoming-responses/package.json (1 hunks)
  • apps/func-response-processor/package.json (1 hunks)
  • apps/office-addin/package.json (1 hunks)
  • packages/markdown/package.json (1 hunks)
  • packages/shared-components/package.json (1 hunks)
  • packages/shared-components/src/LanguageChanger.tsx (1 hunks)
  • packages/transactional/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (10)
  • apps/auth/package.json
  • apps/backend-docker/package.json
  • apps/docs/package.json
  • apps/frontend-control/package.json
  • apps/frontend-manage/package.json
  • apps/frontend-manage/src/pages/sessions/[id]/evaluation.tsx
  • apps/frontend-pwa/package.json
  • apps/func-response-processor/package.json
  • packages/shared-components/package.json
  • packages/transactional/package.json
🔇 Additional comments (25)
packages/shared-components/src/LanguageChanger.tsx (3)

Line range hint 12-24: LGTM! Verify visual impact of removing 'basic' prop.

The removal of the basic prop from the Select component aligns with the PR objectives of improving the component. This change simplifies the component's usage and potentially standardizes its appearance.

To ensure this change doesn't negatively impact the component's appearance, please verify the visual rendering of the LanguageChanger component in different contexts. Consider running visual regression tests if available.

Additionally, you may want to check if the basic prop is still supported by the Select component from @uzh-bf/design-system. If it's deprecated, this change is appropriate. If not, consider documenting why it was removed for this specific usage.


Line range hint 1-29: Overall, the changes improve and simplify the LanguageChanger component.

The modifications align well with the PR objectives of replacing and improving components. The removal of the className prop and the basic prop simplifies the component's interface and usage. However, ensure that these changes don't negatively impact the component's flexibility or appearance in various contexts.

Key points to address:

  1. Verify that removing the className prop doesn't break existing usage.
  2. Consider making the trigger style more flexible.
  3. Check the visual impact of removing the basic prop.

Once these points are addressed, the changes will contribute to a more streamlined and consistent component.


Line range hint 4-9: LGTM! Verify impact on component usage.

The removal of the className prop from the LanguageChanger component's interface simplifies the component. This change is consistent with the PR objectives of replacing and improving components.

To ensure this change doesn't break existing usage, please run the following script to check for any remaining usage of the className prop with LanguageChanger:

✅ Verification successful

LGTM! No usage of the className prop found with LanguageChanger.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for usage of className prop with LanguageChanger
# Expected result: No matches found

rg --type typescript --type typescriptreact 'LanguageChanger.*className'

Length of output: 109


Script:

#!/bin/bash
# Description: Check for usage of className prop with LanguageChanger
# Expected result: No matches found

rg --type ts --type tsx 'LanguageChanger.*className'

Length of output: 82


Script:

#!/bin/bash
# Description: Check for usage of className prop with LanguageChanger
# Expected result: No matches found

rg 'LanguageChanger.*className' --glob '*.ts' --glob '*.tsx'

Length of output: 62

apps/func-incoming-responses/package.json (1)

21-21: LGTM! Dependency update looks good.

The update of @uzh-bf/design-system from 3.0.0-alpha.30 to 3.0.0-alpha.31 aligns with the PR objective of replacing select components with new and improved versions. This minor version bump in a pre-release (alpha) version suggests improvements or additions without breaking changes.

To ensure consistency across the monorepo, let's verify if this update has been applied to other packages:

If any inconsistencies are found, consider updating those packages as well to maintain version uniformity across the project.

✅ Verification successful

Verification successful. All instances of @uzh-bf/design-system are updated to 3.0.0-alpha.31 across the monorepo.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistency of @uzh-bf/design-system version across the monorepo

# Test: Search for @uzh-bf/design-system in all package.json files
# Expect: All occurrences should use version 3.0.0-alpha.31
rg --type json '"@uzh-bf/design-system":\s*"[^"]*"' -g 'package.json'

Length of output: 1034

apps/frontend-manage/src/components/sessions/creation/MultiplierSelector.tsx (1)

56-60: LGTM: Improved styling flexibility for FormikSelectField

The changes to the className prop of FormikSelectField enhance the component's styling flexibility:

  1. The existing className properties are preserved using the spread operator.
  2. A tooltip property with 'z-20' is added, which likely adjusts the z-index of the tooltip for better visibility.
  3. A new select object is introduced with a trigger property, setting a specific height and width for the select trigger element.

These changes allow for more granular control over the component's appearance without affecting its core functionality.

apps/frontend-control/src/components/layout/Header.tsx (1)

34-34: Simplified styling for Select component trigger

The modification of the className prop for the Select component's trigger aligns with the PR objective of improving select components. The new styling focuses on setting maximum height and width while maintaining white text color, which simplifies the component's appearance.

However, it's worth noting that this change removes specific border styling, padding, and hover effects that were present in the previous version. These elements often provide important visual feedback to users. Let's verify if this change affects the user experience:

If these tests don't reveal any compensating styles or effects, consider adding hover effects or other visual feedback mechanisms to enhance user interaction.

apps/frontend-manage/src/components/evaluation/navigation/InstanceNavigation.tsx (1)

72-72: LGTM! Improved Select trigger width.

The addition of w-max to the trigger class is a good improvement. This change will set the width of the Select trigger to the maximum content width, preventing it from unnecessarily expanding to fill its container. This should result in a more visually appealing and precise layout for the instance selection dropdown.

apps/frontend-manage/src/components/evaluation/EvaluationFooter.tsx (3)

97-97: LGTM: Improved Select component styling

The addition of w-36 to the className property sets a fixed width for the Select component, enhancing the UI consistency. This change aligns well with the PR objective of improving select components.


107-107: LGTM: Enhanced type safety in onChange handler

The explicit casting of newValue to ChartType in the onChange handler improves type safety. This change ensures that setChartType always receives a value of the correct type, reducing the risk of runtime errors and aligning with TypeScript best practices.


Line range hint 1-124: Overall assessment: Improvements align with PR objectives

The changes made to the EvaluationFooter component successfully address the PR objective of replacing and improving select components. The modifications enhance both the styling consistency and type safety of the component. No further issues or improvements were identified in this file.

apps/frontend-pwa/src/components/forms/AvatarUpdateForm.tsx (1)

141-143: Verify the visual impact of the styling changes.

The modifications to the FormikSelectField component's styling may affect the overall layout and appearance of the form. Please ensure that these changes have been visually verified across different screen sizes and that they integrate well with the rest of the UI.

To assist in verifying the changes, you can run the following commands:

apps/frontend-pwa/src/components/common/Header.tsx (3)

Line range hint 1-224: Summary: Style improvements align with PR objectives.

The changes made to the Select component in the Header component align well with the PR objective of replacing select components with improved versions. The modifications focus on styling enhancements and potentially improved positioning.

Key points:

  1. The className for the Select trigger has been simplified.
  2. A new contentPosition prop has been added to potentially improve dropdown positioning.

These changes should improve the component's appearance and functionality. However, please ensure to verify the visual consistency and the proper functioning of the new prop across different scenarios.


94-94: LGTM! Verify prop validity and positioning impact.

The addition of the contentPosition="popper" prop to the Select component is a good enhancement. This likely improves the positioning of the dropdown content.

Please ensure that:

  1. The contentPosition prop is a valid prop for the Select component from @uzh-bf/design-system.
  2. The "popper" value behaves as expected in different screen sizes and scenarios.

Run the following commands to verify:

#!/bin/bash
# Description: Check for the usage and documentation of the contentPosition prop

# Test: Search for other occurrences of the contentPosition prop in Select components
rg --type typescript --type typescriptreact 'Select.*contentPosition'

# Test: Look for any documentation or type definitions of the Select component
rg --type typescript --type typescriptreact 'interface SelectProps' -A 20

Consider adding a comment explaining the purpose of using "popper" for better maintainability.


90-92: LGTM! Verify visual consistency.

The simplification of the className property for the Select component's trigger looks good. It focuses on essential styling (padding and text color) which can improve code readability and maintainability.

Please ensure that this change doesn't negatively impact the visual appearance of the component. Consider running the following commands to check for any unintended style changes:

✅ Verification successful

Verification Successful!

No additional Select components with similar className properties or global styles affecting the previous classes were found. The simplification of the className property in Header.tsx is isolated and does not impact other parts of the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any other occurrences of the Select component with similar styling

# Test: Search for other Select components with similar class names
rg --type typescript --type typescriptreact 'Select.*className.*trigger'

# Test: Look for any global styles that might have been affecting the previous class names
rg --type css --type scss 'border.*rounded.*text-white'

Length of output: 217


Script:

#!/bin/bash
# Description: Check for any other occurrences of the Select component with similar styling

# Test: Search for other Select components with similar class names
rg --type ts --type tsx 'Select.*className.*trigger'

# Test: Look for any global styles that might have been affecting the previous class names
rg --type css --type scss 'border.*rounded.*text-white'

Length of output: 169


Script:

#!/bin/bash
# Description: Check for any other occurrences of the Select component with similar styling using file glob patterns

# Test: Search for other Select components with similar class names in TypeScript and TSX files
rg -g "*.ts" -g "*.tsx" 'Select.*className.*trigger'

# Test: Look for any global styles that might have been affecting the previous class names in CSS and SCSS files
rg -g "*.css" -g "*.scss" 'border.*rounded.*text-white'

Length of output: 112

apps/frontend-manage/src/components/user/SuspendedFirstLoginModal.tsx (1)

148-151: LGTM: Improved styling for the language select dropdown

The addition of the select property with a trigger class of w-40 enhances the styling of the language selection dropdown. This change improves the visual consistency of the form and aligns with the PR objective of replacing select components with improved versions.

apps/frontend-manage/src/components/sessions/evaluation/EvaluationControlBar.tsx (2)

90-91: Improved question name display in dropdown

The change to increase the truncation length from 20 to 40 characters is a good improvement. It allows for longer question names to be displayed in the dropdown, enhancing the user experience by providing more context.


148-149: Improved select component width handling

The addition of w-max to the trigger class is a good improvement. It allows the select component to expand to its maximum content width, which should prevent text truncation and improve readability.

Please verify that this change doesn't negatively impact the overall layout of the component, especially in scenarios with long question names. Consider testing with various question name lengths to ensure the layout remains consistent and visually appealing.

apps/frontend-manage/src/components/user/DelegatedAccessSettings.tsx (1)

251-253: Improved responsive design for FormikSelectField

The addition of the className prop with root: 'md:w-1/2' enhances the responsive layout of the form. This change ensures that the select field occupies half the width on medium-sized screens and above, consistent with the adjacent text field. This improvement in the component's styling flexibility is a positive change.

apps/frontend-manage/src/pages/index.tsx (2)

295-295: LGTM: Improved text size for Select items

The addition of the 'text-sm' class to the Select component's item improves the UI by ensuring a consistent and appropriate text size for the dropdown items. This change aligns well with the PR objective of improving select components.


320-320: LGTM: Improved dropdown positioning for Select component

The addition of the 'contentPosition' prop with the value "popper" enhances the Select component by likely improving the positioning of its dropdown. This change aligns well with the PR objective of improving select components.

To ensure consistency across the application, let's verify if this change has been applied to all Select components:

apps/frontend-manage/src/components/questions/QuestionEditModal.tsx (5)

706-706: LGTM: Improved select field styling

The addition of the className prop with specific styling for the select trigger enhances the visual consistency of the form. This change is appropriate and aligns with good UI practices.


718-718: LGTM: Consistent styling for select fields

The addition of the className prop for the question status select field maintains consistency with the earlier change. This uniform styling approach improves the overall look and feel of the form.


Line range hint 1400-1400: Clarify the purpose of hiding errors

The addition of the hideError prop to the FormikNumberField for numerical accuracy suppresses error display for this field. While this might be intentional, it could potentially lead to usability issues if users are not informed of input problems.

Could you please clarify the reasoning behind hiding errors for this specific field? Are there alternative ways to handle and display errors for numerical inputs that maintain user feedback while addressing any specific concerns?


Line range hint 1556-1556: Consistent approach to hiding errors, but clarification needed

The addition of the hideError prop to another FormikNumberField component shows a consistent approach to handling errors for numerical inputs. However, this reinforces the need for clarification on the overall strategy for error handling in these fields.

Could you provide more context on the decision to hide errors for numerical input fields? Is there a specific user experience consideration driving this choice? It would be helpful to understand the rationale and ensure that users still receive necessary feedback on their inputs.


Line range hint 1-1556: Summary: UI enhancements with a note on error handling

The changes in this file primarily focus on improving the user interface of the QuestionEditModal component. The styling adjustments to select fields and consistent application of these changes contribute to a more polished and uniform appearance.

However, the introduction of error hiding for numerical input fields raises some questions about the overall error handling strategy. While this approach may serve a specific purpose, it's important to ensure that it doesn't compromise the user's ability to input correct data.

To conclude this review, it would be beneficial to have a broader discussion on the error handling approach for numerical inputs. Consider documenting the rationale behind hiding errors and any alternative feedback mechanisms in place to guide users in providing correct input.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarcloud bot commented Oct 5, 2024

@sjschlapbach sjschlapbach merged commit 57e1019 into v3 Oct 5, 2024
12 of 15 checks passed
@sjschlapbach sjschlapbach deleted the new-select-components branch October 5, 2024 16:15
Copy link

cypress bot commented Oct 5, 2024

klicker-uzh    Run #3149

Run Properties:  status check passed Passed #3149  •  git commit d3176e87a1 ℹ️: Merge 4fa5b550ab0841c43c04951d2fd6c38733703628 into 6d471052850537137138af3eafd7...
Project klicker-uzh
Branch Review new-select-components
Run status status check passed Passed #3149
Run duration 09m 43s
Commit git commit d3176e87a1 ℹ️: Merge 4fa5b550ab0841c43c04951d2fd6c38733703628 into 6d471052850537137138af3eafd7...
Committer Julius Schlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 47
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Oct 5, 2024

klicker-uzh    Run #3150

Run Properties:  status check passed Passed #3150  •  git commit 57e101934e: style: replace select components through new and improve version (#4295)
Project klicker-uzh
Branch Review v3
Run status status check passed Passed #3150
Run duration 09m 42s
Commit git commit 57e101934e: style: replace select components through new and improve version (#4295)
Committer Julius Schlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 47
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant