feat: allow adding free text questions without sample solution to practice quizzes and microlearnings #4260
Conversation
sjschlapbach
commented
Sep 15, 2024
•
sjschlapbach
commented
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
WalkthroughWalkthroughThe pull request introduces significant changes across multiple components in the application, primarily focusing on restructuring data handling. The previous implementation used separate arrays for various properties related to stack elements, which have now been consolidated into a single Changes
Possibly related PRs
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Additional context usedBiome
Additional comments not posted (9)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
klicker-uzh
|
||||||||||||||||||||||||||||
| Project |
klicker-uzh
|
| Branch Review |
PracticeQuizFTQuestions
|
| Run status |
|
| Run duration | 08m 57s |
| Commit |
|
| Committer | Julius Schlapbach |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
43
|
| View all changes introduced in this branch ↗︎ | |
…t sample solution
…udents are not shown
…ple solution setting into editor on edit
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (24)
- apps/frontend-manage/src/components/sessions/creation/AddStackButton.tsx (4 hunks)
- apps/frontend-manage/src/components/sessions/creation/StackBlockCreation.tsx (7 hunks)
- apps/frontend-manage/src/components/sessions/creation/StackCreationErrors.tsx (1 hunks)
- apps/frontend-manage/src/components/sessions/creation/StackCreationStep.tsx (1 hunks)
- apps/frontend-manage/src/components/sessions/creation/WizardLayout.tsx (1 hunks)
- apps/frontend-manage/src/components/sessions/creation/groupActivity/GroupActivityStackClues.tsx (1 hunks)
- apps/frontend-manage/src/components/sessions/creation/groupActivity/GroupActivityWizard.tsx (3 hunks)
- apps/frontend-manage/src/components/sessions/creation/groupActivity/submitGroupActivityForm.ts (3 hunks)
- apps/frontend-manage/src/components/sessions/creation/microLearning/MicroLearningWizard.tsx (5 hunks)
- apps/frontend-manage/src/components/sessions/creation/microLearning/submitMicrolearningForm.ts (1 hunks)
- apps/frontend-manage/src/components/sessions/creation/practiceQuiz/PracticeQuizWizard.tsx (5 hunks)
- apps/frontend-manage/src/components/sessions/creation/practiceQuiz/submitPracticeQuizForm.ts (1 hunks)
- cypress/cypress/e2e/G-microlearning-workflow.cy.ts (5 hunks)
- packages/graphql/src/graphql/ops/QGetSingleMicroLearning.graphql (1 hunks)
- packages/graphql/src/graphql/ops/QGetSinglePracticeQuiz.graphql (1 hunks)
- packages/graphql/src/ops.ts (2 hunks)
- packages/graphql/src/public/client.json (1 hunks)
- packages/graphql/src/public/server.json (1 hunks)
- packages/graphql/src/services/practiceQuizzes.ts (4 hunks)
- packages/i18n/messages/de.ts (3 hunks)
- packages/i18n/messages/en.ts (3 hunks)
- packages/shared-components/src/FreeTextQuestion.tsx (1 hunks)
- packages/shared-components/src/evaluation/FTEvaluation.tsx (1 hunks)
- packages/shared-components/src/evaluation/PracticeQuizPoints.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/shared-components/src/evaluation/PracticeQuizPoints.tsx
Additional context used
Learnings (1)
apps/frontend-manage/src/components/sessions/creation/StackCreationErrors.tsx (1)
Learnt from: sjschlapbach PR: uzh-bf/klicker-uzh#4169 File: apps/frontend-manage/src/components/sessions/creation/StackCreationErrors.tsx:53-59 Timestamp: 2024-08-13T15:13:44.365Z Learning: In the `StackCreationErrors` component, `flatMap` is used to filter out empty or undefined elements from error arrays before mapping them to list entries.
Biome
apps/frontend-manage/src/components/sessions/creation/microLearning/MicroLearningWizard.tsx
[error] 138-138: Do not add then to an object.
(lint/suspicious/noThenProperty)
apps/frontend-manage/src/components/sessions/creation/practiceQuiz/PracticeQuizWizard.tsx
[error] 149-149: Do not add then to an object.
(lint/suspicious/noThenProperty)
Additional comments not posted (55)
packages/graphql/src/graphql/ops/QGetSinglePracticeQuiz.graphql (1)
1-5: Verify that the new fragment provides all the necessary data fields.The changes to the import statement and the fragment being used align with the PR objective of allowing free text questions without sample solutions. However, please ensure that the new
PracticeQuizDatafragment provides all the necessary data fields required by the application.Run the following script to verify the usage of the
PracticeQuizDatafragment:packages/graphql/src/graphql/ops/QGetSingleMicroLearning.graphql (1)
1-1: Verify the impact of the fragment change on the application.The import statement has been updated to reference a different GraphQL fragment,
FMicroLearningData, instead ofFMicroLearningDataWithoutSolutions. This change suggests a shift in the data structure being utilized in the query, potentially altering the information returned by thegetSingleMicroLearningoperation.Please ensure that:
- The new fragment provides all the necessary data for the application to function correctly.
- The change does not introduce any breaking changes or unexpected behavior in the application.
- The naming of the fragment accurately reflects the data it contains.
Run the following script to verify the usage of the
FMicroLearningDatafragment:Also applies to: 5-5
Verification successful
These new scripts will help us verify the existence of .graphql files and search for the
FMicroLearningDatafragment without relying on file type recognition. We'll also perform a broader search to catch potential variations or partial matches of the fragment name.
Verified: Fragment change is consistent and impacts only the specified query.
The change from
FMicroLearningDataWithoutSolutionstoFMicroLearningDatain theQGetSingleMicroLearning.graphqlfile has been verified. This modification is consistent with the codebase structure and appears to be intentional. The new fragmentFMicroLearningDatais properly defined and includes more comprehensive data, likely incorporating solution-related information.Key points:
- The
FMicroLearningDatafragment is correctly defined and used.- The impact is limited to the
QGetSingleMicroLearningquery.- Other queries, such as
QGetMicrolearning, continue to use theWithoutSolutionsversion.This change may result in more detailed data being returned for the
getSingleMicroLearningoperation. Ensure that the consuming components can handle the additional information appropriately.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the `FMicroLearningData` fragment in the codebase. # Test 1: Search for the usage of the `FMicroLearningData` fragment. # Expect: The fragment should be used in other GraphQL queries or mutations. rg --type graphql $'FMicroLearningData' # Test 2: Search for the definition of the `FMicroLearningData` fragment. # Expect: The fragment should be defined in a `.graphql` file. fd --type file --extension graphql --exec rg $'fragment FMicroLearningData'Length of output: 147
Script:
#!/bin/bash # Description: Verify the existence of .graphql files and search for the FMicroLearningData fragment # Test 1: Check for the existence of .graphql files echo "Checking for .graphql files:" fd -e graphql # Test 2: Search for the usage of the FMicroLearningData fragment in all files echo -e "\nSearching for FMicroLearningData fragment usage:" rg "FMicroLearningData" # Test 3: Search for the definition of the FMicroLearningData fragment echo -e "\nSearching for FMicroLearningData fragment definition:" rg "fragment FMicroLearningData" # Test 4: Perform a broader search for similar fragment names echo -e "\nPerforming a broader search for similar fragment names:" rg "fragment.*MicroLearning"Length of output: 18274
packages/shared-components/src/evaluation/FTEvaluation.tsx (1)
32-44: LGTM!The conditional rendering of the answers section is a great improvement. It enhances the component's efficiency by preventing unnecessary rendering of empty sections and improves the user interface by avoiding the display of irrelevant information.
The logic for displaying answers is implemented correctly, with appropriate handling of undefined counts. The JSX structure is clean and encapsulates the answers display within the conditional block.
Overall, these changes enhance the component's performance and user experience without introducing any apparent issues or potential bugs.
apps/frontend-manage/src/components/sessions/creation/StackCreationErrors.tsx (2)
8-25: LGTM!The
StackErrorElementcomponent is a clean and reusable way to render individual error messages. It encapsulates the rendering logic and uses theuseTranslationshook to access translations. The component takes an error message and its index as props, making it flexible and maintainable.
34-59: Great refactor!The refactored
StackCreationErrorscomponent enhances the readability and maintainability of the code by:
- Reducing redundancy and improving the separation of concerns.
- Using the
StackErrorElementcomponent to render each error message conditionally based on its existence, making the code more modular and reusable.- Utilizing
flatMapto filter out empty or undefined elements before mapping them to list entries, aligning with the learning retrieved from long-term memory.The new structure streamlines the rendering logic and makes it easier to understand and maintain.
apps/frontend-manage/src/components/sessions/creation/practiceQuiz/submitPracticeQuizForm.ts (1)
44-45: LGTM! The new approach improves clarity and maintainability.The change from using
stack.elementIdstostack.elementsfor constructing theelementsarray enhances the clarity of the code by directly utilizing the element objects instead of their IDs. This modification improves the readability and maintainability of the code while maintaining the overall functionality.apps/frontend-manage/src/components/sessions/creation/microLearning/submitMicrolearningForm.ts (1)
47-48: Verify the impact of the change in the structure of theelementsarray.The change in the mapping logic suggests that the
stack.elementsarray now contains element objects instead of just element IDs. This change may impact downstream logic that relies on the structure of this array.Please verify the following:
- Ensure that any code that consumes the
elementsarray is updated to handle the new structure of the array.- Verify that the GraphQL mutation payload expects the
elementsarray to contain objects withelementIdandorderproperties.Run the following script to verify the usage of the
elementsarray:apps/frontend-manage/src/components/sessions/creation/groupActivity/submitGroupActivityForm.ts (2)
41-44: LGTM!The code segment correctly maps over
values.stack.elementsto create an array of objects withelementIdandorderproperties, aligning with the new data model.
71-74: LGTM!The code segment correctly maps over
values.stack.elementsto create an array of objects withelementIdandorderproperties, aligning with the new data model.packages/shared-components/src/FreeTextQuestion.tsx (1)
76-84: LGTM! The changes align with the PR objective.The modification to the
evaluationprop passed to thePracticeQuizPointscomponent correctly handles the scenario where no solutions are provided for a free text question. By conditionally settingxpAwardedtonullwhen thesolutionsarray is empty, the code enables the addition of free text questions without sample solutions, as intended by the PR.The changes are localized and should not introduce any errors or have unintended side effects on other parts of the codebase.
apps/frontend-manage/src/components/sessions/creation/WizardLayout.tsx (2)
42-47: Verify the usage ofElementStackFormValuesinterface across the codebase.The changes to the
ElementStackFormValuesinterface improve the organization and clarity of element-related data. The new nested object structure enhances encapsulation and makes the relationships between different properties easier to understand.Please ensure that all code interacting with this interface has been updated to match the new structure. Run the following script to verify the interface usage:
53-60: Verify the error handling code that uses theElementStackErrorValuesinterface.The modifications to the
ElementStackErrorValuesinterface allow for more flexible error handling and better representation of the data structure. The changes align with the updates made to theElementStackFormValuesinterface.Please ensure that the error handling logic has been updated to handle the new structure of the
elementsproperty. Run the following script to verify the interface usage in error handling code:Verification successful
The changes to
ElementStackErrorValuesinterface have been implemented correctly and are being used appropriately.The updated
ElementStackErrorValuesinterface inWizardLayout.tsxmatches the structure described in the review comment. Related components likeStackBlockCreationandStackCreationErrorsare using this updated interface, suggesting that they are prepared to handle the new error structure.While we didn't find explicit error handling code (try/catch blocks), this is not a concern as the interface is primarily used for structuring and displaying error data rather than for exception handling.
- The changes allow for more flexible error representation in element stacks.
- Components using this interface appear to be ready to work with the new structure.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `ElementStackErrorValues` interface in error handling code. # Test: Search for the interface usage in error handling contexts. Expect: No mismatches with the new structure. rg --type typescript -A 5 $'ElementStackErrorValues' | rg --type typescript $'(catch|error)'Length of output: 160
Script:
#!/bin/bash # Description: Verify the presence of TypeScript files and search for ElementStackErrorValues usage # Test 1: Check for TypeScript files echo "Checking for TypeScript files:" fd '\.(ts|tsx)$' # Test 2: Search for ElementStackErrorValues usage without specifying file type echo -e "\nSearching for ElementStackErrorValues usage:" rg 'ElementStackErrorValues' -A 5 # Test 3: Search for error handling contexts related to ElementStackErrorValues echo -e "\nSearching for error handling contexts related to ElementStackErrorValues:" rg 'ElementStackErrorValues' -A 10 | rg '(catch|error)'Length of output: 33923
apps/frontend-manage/src/components/sessions/creation/StackCreationStep.tsx (1)
64-64: LGTM! The new key format is an improvement.Using the
idproperty of theelementsarray as the key is a better approach compared to the previous format. It creates a more unique and stable key for eachStackBlockCreationcomponent, which aligns with React best practices.This change can potentially lead to improved performance and maintainability, as React can more efficiently identify and update the components when necessary.
apps/frontend-manage/src/components/sessions/creation/AddStackButton.tsx (5)
34-41: LGTM!The code segment correctly consolidates the data into a single
elementsarray of objects, mapping the properties from the dropped item. The changes align with the AI-generated summary.
61-68: LGTM!The code segment correctly maps the
selectionobject to an array of objects calledstackElements, usingmapto directly create the array. The changes align with the AI-generated summary.
73-73: LGTM!The code segment correctly pushes the
stackElementsarray to theelementsproperty of the object being pushed, aligning with the new data structure.
99-106: LGTM!The code segment correctly consolidates the data into a single
elementsarray of objects, mapping the properties from eachselectionobject. The changes align with the new data structure.
136-136: LGTM!The code segment correctly initializes the
elementsarray as an empty array when a new stack is added, aligning with the new data structure.apps/frontend-manage/src/components/sessions/creation/groupActivity/GroupActivityStackClues.tsx (1)
69-69: LGTM!The change to the
keyprop generation logic for theStackBlockCreationcomponent is a good improvement. It enhances the uniqueness of thekeyby using the actualidof each element in thestack.elementsarray, reducing the risk of key collisions and potential rendering issues in React.apps/frontend-manage/src/components/sessions/creation/StackBlockCreation.tsx (7)
76-83: LGTM!The changes to the
dropevent handler align with the restructuring of stack elements into a singleelementsarray. The new element is created using the properties of the droppeditemand added to theelementsarray of thestackobject.
200-206: LGTM!The changes to the rendering logic align with the restructuring of stack elements into a single
elementsarray. Themapfunction is used to iterate over thestack.elementsarray directly, simplifying the rendering logic.
220-221: LGTM!The change to access the
titleproperty directly from theelementobject aligns with the restructuring of stack elements into a singleelementsarray. It simplifies the rendering logic.
235-243: LGTM!The changes to the logic for moving an element up within the
elementsarray align with the restructuring of stack elements into a singleelementsarray. TheR.movefunction is used to update theelementsarray correctly.
259-272: LGTM!The changes to the logic for moving an element down within the
elementsarray align with the restructuring of stack elements into a singleelementsarray. TheR.movefunction is used to update theelementsarray correctly.
292-294: LGTM!The changes to the logic for deleting an element from the
elementsarray align with the restructuring of stack elements into a singleelementsarray. Theslicemethod is used to remove the element at the currentquestionIdxcorrectly.
314-324: LGTM!The changes to the logic for pasting selected questions into the
elementsarray align with the restructuring of stack elements into a singleelementsarray. The selected questions are mapped to new element objects and concatenated with the existingstack.elementsarray correctly.apps/frontend-manage/src/components/sessions/creation/microLearning/MicroLearningWizard.tsx (4)
20-20: LGTM!The updated import statement looks good.
49-49: LGTM!The addition of
ElementType.FreeTextto theacceptedTypesarray is a necessary change to support free text questions without sample solutions in the micro-learning wizard.
123-141: LGTM!The updated validation schema for the
elementsarray within thestacksarray looks good:
- It ensures that each stack contains at least one element.
- It validates the structure and properties of each element object.
- The conditional validation of
hasSampleSolutionbased on the element type aligns with the PR objective of allowing free text questions without sample solutions.The changes enhance the flexibility and correctness of the validation schema.
Tools
Biome
[error] 138-138: Do not add then to an object.
(lint/suspicious/noThenProperty)
196-204: LGTM!The mapping of the
elementsarray within each stack of theinitialValueslooks good:
- It aligns with the updated data structure for elements.
- It ensures that the initial form values are consistent with the new structure.
- The default value of
trueforhasSampleSolutionmaintains backward compatibility for existing elements.The changes are necessary to support the new element structure and ensure proper initialization of the form data.
apps/frontend-manage/src/components/sessions/creation/practiceQuiz/PracticeQuizWizard.tsx (5)
22-22: LGTM!The import statement has been updated correctly to align with the changes in the form values structure.
50-50: LGTM!The addition of
ElementType.FreeTextto the accepted types aligns with the PR objective of supporting free text questions in practice quizzes.
134-152: Excellent work on restructuring the validation schema!The new validation schema for the
elementsarray significantly improves the clarity and organization of the data structure. The conditional validation ofhasSampleSolutionbased on the element type is a great addition, ensuring that free text questions do not require a sample solution, which aligns perfectly with the PR objective.These changes enhance the functionality and flexibility of the practice quiz creation process, allowing for a broader range of question types and more robust validation.
Tools
Biome
[error] 149-149: Do not add then to an object.
(lint/suspicious/noThenProperty)
167-167: LGTM!The default value for the
elementsfield has been updated correctly to align with the changes in the form values structure.
207-215: Great job on updating the mapping of stack elements!The refined mapping correctly transforms each element's data into the new format, including
id,title,type, andhasSampleSolution. This ensures that the existing stack elements align with the new structure of the form values and validation schema.These changes maintain consistency throughout the file and contribute to the overall improvement of the practice quiz creation process.
apps/frontend-manage/src/components/sessions/creation/groupActivity/GroupActivityWizard.tsx (3)
124-137: LGTM!The changes to the validation schema for the
stack.elementsproperty align with the restructuring mentioned in the AI-generated summary. The validation ensures that theelementsarray contains at least one object, and each object has the required properties (id,title, andtype). Thetypevalidation against theacceptedTypesarray enforces the allowed element types.These changes improve the organization and clarity of the validation schema and help maintain the integrity of the data structure.
181-181: LGTM!The change to the default value for the
stack.elementsproperty aligns with the restructuring mentioned in the AI-generated summary. By initializingelementsas an empty array, it ensures consistency with the updated validation schema and provides a proper starting point for the form.
228-235: LGTM!The changes to the initialization of the
stack.elementsproperty wheninitialValuesare provided align with the restructuring mentioned in the AI-generated summary. The mapping creates objects withid,title,type, andhasSampleSolutionproperties for each element ininitialValues.stacks[0].elements.Setting
hasSampleSolutiontofalsefor each element is consistent with the PR objective of allowing free text questions without sample solutions.These changes ensure that the initial values for the
stack.elementsproperty are properly mapped to the new data structure.packages/graphql/src/public/client.json (2)
134-134: Verify the underlying changes to theGetSingleMicroLearningquery.The hash value for the
GetSingleMicroLearningquery has been modified, indicating changes to its implementation or returned data structure. To better understand the reason and potential impact of this change, please provide more context about the specific modifications made to this query.
135-135: Confirm theGetSinglePracticeQuizquery changes are related to allowing free text questions without sample solutions.The hash value for the
GetSinglePracticeQuizquery has been modified. Based on the PR summary, this change is likely related to supporting the addition of free text questions without sample solutions to practice quizzes.Can you please confirm that the modifications to this query were made to enable this new feature? It would be helpful to understand how the query and/or its returned data structure were updated to accommodate questions without sample solutions.
cypress/cypress/e2e/G-microlearning-workflow.cy.ts (5)
17-18: LGTM!The new constants
questionTitle2andquestion2are declared correctly usinguuid()to ensure uniqueness across test runs. They will likely be used to set up a second SC question without a sample solution later in the test.
41-48: Looks good!The new test step correctly sets up a second SC question without configuring the sample solution. This aligns with the PR objective and sets up the necessary preconditions to validate allowing questions without sample solutions later in the test.
160-162: Great addition!The new assertions correctly verify that free text questions without sample solutions are accepted in the microlearning and don't block submission. This aligns perfectly with the PR objective.
189-202: Excellent validation!The new test step does a great job validating that SC questions without sample solutions are rejected when added to certain stacks, likely based on some predefined criteria. It ensures that such invalid questions disable the submit button until they are removed.
This aligns perfectly with the PR objective and helps maintain the integrity of the microlearning by enforcing necessary validation rules. Well done!
286-287: Spot on!The changes correctly validate the behavior when a student answers a microlearning containing a free text question without a sample solution.
After answering the SC question, the submit button remains disabled until the free text answer is entered. This aligns perfectly with the expected behavior for free text questions.
Great job covering this student-facing workflow!
packages/graphql/src/services/practiceQuizzes.ts (2)
1148-1150: LGTM!The change correctly returns the
results.responsesobject in theanswersfield only ifelementData.options.hasSampleSolutionis true. When there is no sample solution, an empty object is returned instead, ensuring that actual responses are not exposed.
1862-1864: LGTM!For 'FREE_TEXT' elements, the change correctly includes the actual
elementData.options.solutionsarray in the returnedevaluationobject only ifelementData.options.hasSampleSolutionis true. When there is no sample solution, an empty array is returned instead, ensuring that the actual solutions are not exposed.packages/i18n/messages/en.ts (3)
1005-1007: LGTM!The updated description provides more clarity by stating that all available element types can be included in a microlearning. This aligns with the PR objective of allowing free text questions without sample solutions.
1114-1115: LGTM!The updated message enhances clarity by specifying that the sample solution requirement applies to all element types except free text questions. This aligns perfectly with the PR objective.
1148-1149: LGTM!The updated description clarifies that practice quizzes can contain all available element types, including free text questions. This change aligns with the PR objective and provides a more inclusive description.
packages/i18n/messages/de.ts (3)
1006-1007: LGTM!The updated description accurately reflects the expanded scope of elements that can be included in microlearnings.
1119-1121: LGTM!The refined requirement clearly communicates that model solutions are necessary for all question types except free text questions. This aligns perfectly with the PR objective.
1155-1156: LGTM!The updated description accurately reflects the expanded scope of element types that can be included in practice quizzes.
packages/graphql/src/ops.ts (2)
3237-3244: LGTM!The modifications to the
GetSingleMicroLearningQueryandGetSinglePracticeQuizQuerytypes enhance the functionality and data richness of the queries. The addition of thehasSampleSolutionfield, thecorrectfield for choices, and thesolutionRangesfor numerical elements provide more detailed information about the elements involved in micro-learnings and practice quizzes.The changes are consistent across both query types and align with the list of alterations provided in the summary.
3514-3515: Looks good!The modifications to the
GetSingleMicroLearningDocumentandGetSinglePracticeQuizDocumentGraphQL document definitions are consistent with the changes made to the corresponding query types. The usage of theElementDatafragment ensures that the updated fields are included in the query selection sets.These changes ensure that the GraphQL queries retrieve the newly added fields from the server, maintaining consistency between the client and server.
|
klicker-uzh
|
||||||||||||||||||||||||||||||||||||||||
| Project |
klicker-uzh
|
| Branch Review |
v3
|
| Run status |
|
| Run duration | 09m 53s |
| Commit |
|
| Committer | Julius Schlapbach |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
1
|
|
Flaky
|
1
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
42
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/E-course-workflow.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Test course creation and editing functionalities > Test the assignment of random groups in the seeded test course |
Test Replay
Screenshots
|
|
cypress/e2e/F-live-quiz-workflow.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Different live-quiz workflows > creates a live quiz without questions and tests the feedback mechanisms and deletes the completed live session |
Test Replay
Screenshots
|
|
