Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Pin numpy to avoid errors due to expired scalar deprecations #630

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Dec 20, 2022

What

Pinning numpy and creating a patch release to avoid errors related to the latest updates in numpy v1.24

Why

Resolve failures in deepcell due to code that depends on numpy features that were removed in 1.24. This affects the entire deepcell ecosystem of libraries; see also: vanvalenlab/deepcell-toolbox#131 and vanvalenlab/deepcell-tracking#110

@rossbar rossbar marked this pull request as draft December 20, 2022 21:31
@rossbar
Copy link
Contributor Author

rossbar commented Dec 20, 2022

I thought we might be able to get away with this without having to release deepcell-tracking first, but the pip dependency resolver disagreed.

Marking as draft for now - the Docker job should be resolved once deepcell-tracking#110 is merged and released.

@rossbar rossbar marked this pull request as ready for review December 21, 2022 01:15
@msschwartz21 msschwartz21 added the chore Maintenance label Dec 21, 2022
@rossbar rossbar merged commit 87a0e07 into vanvalenlab:master Dec 21, 2022
@rossbar rossbar deleted the hotfix/pin-numpy branch December 21, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants