Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update deprecated code from dependencies and remove warnings filters #131

Merged
merged 7 commits into from
Dec 20, 2022

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Dec 19, 2022

The current pytest configuration is suppressing all deprecation warnings, which includes warnings from dependency libraries. This makes it much more likely for code to fall out-of-date, as can be seen in the recent failing CI jobs due to changes in the lastest version of numpy which was just releases (1.24).

This PR addresses the issue in two ways:

  1. Updates code to take into account changes in the underlying libraries, and
  2. Removes the global warnings filter in favor of fine-grained warnings filtering.

The second bullet involves adding explicit checks for warnings raised by deepcell-toolbox itself, to ensure that warnings are being raised correctly in the expected cases.

Copy link
Member

@msschwartz21 msschwartz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This seems like a particularly good change to the testing workflow because I know I've been guilty of ignoring those deprecation warnings for a long time...

@msschwartz21 msschwartz21 added the chore Maintenance label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants