Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring leaving space experience in line with Web #4850

Closed
3 tasks done
Tracked by #164
kittykat opened this issue Sep 16, 2021 · 12 comments · Fixed by #6062
Closed
3 tasks done
Tracked by #164

Bring leaving space experience in line with Web #4850

kittykat opened this issue Sep 16, 2021 · 12 comments · Fixed by #6062
Assignees
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Spaces-Testing

Comments

@kittykat
Copy link
Contributor

kittykat commented Sep 16, 2021

Your use case

Current behaviour on iOS: when a user leaves a space, they do not leave the rooms in that space

User should be able to leave a space without having to leave many rooms individually after the fact. Behaviour should be brought into line with web to offer three options.

  • (RELEASE BLOCKER) If not enough time to implement next point, add a note to say that leaving a space will not leave rooms in that space
  • (not a blocker, highest priority) If enough time, add option to stay in all rooms and leave all rooms, with a note that there are other options in Web
  • (not a blocker) Implement third option to leave selected rooms only"

Have you considered any alternatives?

No response

Additional context

No response

@kittykat kittykat added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Spaces Spaces, groups, communities X-Release-Blocker S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Spaces-Testing labels Sep 16, 2021
@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems and removed T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Sep 16, 2021
gileluard added a commit that referenced this issue Sep 20, 2021
- [Space home view inherits title from previously viewed tab](#4851)
- [Home view doesn't refresh when new rooms are created](#4849)
- [Odd error message in Space member list](#4845)
- [Bring leaving space experience in line with Web](#4850)
- [No notification for space invitation](#4840)
- [Remove filter when space is switched](#4852)
- [M10.11 Remove community tab](#4493)
@niquewoodhouse
Copy link

@gileluard Just recently (in the last day or so) improved the copy of the leave Spaces so this is a bit out of date. I can take a look and suggest new copy here

@kittykat
Copy link
Contributor Author

Removing release blocker label as it's no longer a blocker in its current state

@gileluard gileluard reopened this Sep 28, 2021
@kittykat kittykat removed their assignment Oct 7, 2021
@gileluard
Copy link
Contributor

@nadonomy @kittykat here is the actual screen on web:
Screenshot 2022-03-29 at 10 57 27

As you can see, the list of rooms is not displayed if the user doesn't select first Leave some rooms.

We could base the UI on the list of rooms so the user can see the rooms that belongs to this space. Having All rooms and No room options may make things also more flexible especially if the user wants to leave all rooms except one room.

Here is a sample view.
ezgif-2-956a649cce

@kittykat
Copy link
Contributor Author

@gileluard that's a much nicer interaction IMO than having the three options and then choosing later.

Some notes:

  • Buttons should probably say "select all" and "select none"
  • "space" in "Leave space" should be lower case

@nadonomy
Copy link
Contributor

@gileluard +1 to Kats comments. There's also some other visual & interaction tweaks we should make, things like:

  • Considering how the user should interact between All / Some / None.
  • Tweaking how scrollviews behave / what persists while scrolling.

Etc.

@gileluard can you remind me of the timeliness/which RC you want to merge this in for? Wondering how to action.

@gileluard
Copy link
Contributor

@nadonomy this is not a release blocker but it's high priority so I would say we'd like to have this feature done for the next RC after this one. @kittykat To confirm.

@kittykat
Copy link
Contributor Author

If we could have this implemented and tested by 4th April, that would be ideal 👍

@nadonomy
Copy link
Contributor

@kittykat @gileluard great! @amshakal is taking a look at this now, also benchmarking Android to consider cross-platform consistency here on mobile.

@gileluard
Copy link
Contributor

gileluard commented Apr 4, 2022

@amshakal I'm almost done with this feature. Let me know if there is something I should change

ezgif-4-5fffe2e18c

Also I'm wondering if we shouldn't rather display an simple alert if the space is empty as we display a large empty view in this case:

Simulator Screen Shot - iPhone SE (2nd generation) - 2022-04-04 at 17 57 55

@niquewoodhouse
Copy link

After discussing with @kittykat @fedrunov @gileluard, I've got some alternative designs that aim to:

  • Help the filtering make more sense (eg "what does select all rooms" do if I'm filtering
  • Reduce some of the ux complexity (eg why does someone need to see a list of all the rooms straight away - on mobile it can be a lot)

These designs aren't comprehensive, just trying to address the largest concerns that came from the meeting - any thoughts welcome and if we have a preferred route, I'll make more comprehensive designs and of course the android equivalent.

Idea 1 As little change as possible

  • Remove label and all/none options when filtering
  • Change "select rooms" in label to "rooms"
  • Wasn't sure what currently happens with the CTA when searching so left it out
ele-ios-leave-space-1.mov

Idea 2 Split the steps

  • Removes issues of select all/none options when filtering
ele-ios-leave-space-3.mov

Idea 3 Remove select none

  • Its the default option anyway
  • Add functionality to top bar (clear + cancel)
ele-ios-leave-space-2.mov

@gileluard
Copy link
Contributor

Thanks @niquewoodhouse

  • Idea 1 works for me
  • I wouldn't go for idea 2 as it supposes that the users knows the exhaustive list of rooms for this space. That's why we thought to display the list of sub rooms of the space at first.
  • Idea 3 works for me. Hopefully, the user won't need to leave all sub rooms very often.

@niquewoodhouse
Copy link

Because this feature is already in development, I'd personally lean towards doing as little change as possible, especially as it's not like this is a flow every user will definitely experience. @kittykat @fedrunov does Idea 1 above resolve the issues raised for you?

gileluard added a commit that referenced this issue Apr 22, 2022
- Hide selection bar when filtering room list
gileluard added a commit that referenced this issue Apr 22, 2022
gileluard added a commit that referenced this issue Apr 27, 2022
* Bring leaving space experience in line with Web #4850

- Done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Spaces-Testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants