-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TestORBSLAMDataProcess timeout #1484
Fix TestORBSLAMDataProcess timeout #1484
Conversation
@@ -671,7 +671,7 @@ func TestCartographerDataProcess(t *testing.T) { | |||
}() | |||
|
|||
cancelCtx, cancelFunc := context.WithCancel(context.Background()) | |||
c := make(chan int) | |||
c := make(chan int, 100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increasing the channel buffer size so that we don't block writing to the channel in the test. It's possible the data process will write to the channel a few more times before the channel is closed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I saw another failure in a PR, and realized there was still this issue in the test.