-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't spam log messages on sysfs boards #1794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Jan 20, 2023
thegreatco
approved these changes
Jan 20, 2023
tested on an ai-64 with local build |
Note: merge base coverage results not available, comparing against closest cea9c09~1=(5c672f7) instead
|
Closed
randhid
pushed a commit
to randhid/rdk
that referenced
this pull request
Feb 25, 2023
Sorry about this! We want to log when you try using the unimplemented parts, but not when you're just checking their statuses. So, remove half of viamrobotics#1786. This time, we're going to actually try it out on a robot before merging. Thanks to Pete G and Matt D for pointing out the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about this! We want to log when you try using the unimplemented parts, but not when you're just checking their statuses. So, remove half of #1786.
This time, we're going to actually try it out on a robot before merging. Thanks to @thegreatco and @dannenberg for pointing out the problem.