-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor images, change heading colors on scroll #464
Conversation
|
||
&::after { | ||
content: '' | ||
} | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
below are just placeholder images that I'll swap out in another PR
@leobauza the CI website test is failing again but I think that's okay according to @nhunzaker? |
Pretty strange. Let's not worry about it. I wish I knew what was up tho :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These graphics are so great :)
@nhunzaker yeah, it sometimes works and sometimes doesn't so I wonder if it's a CI thing? anyways, will keep moving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
src={ | ||
microcosmView ? `/${section}-microcosm.png` : `/${section}-browser.png` | ||
} | ||
alt="TODO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll replace all the alt="TODO"
at the end
* added icons to button, minified images, changed way we switch text on btn * ran yarn format * add intro and conclusion sections (#466)
* laying out structure of browser graphic * tweaked browser graphic and refactored to its own component * ran yarn format * ran yarn format * made change to json * make it so that intro/conclusion only shows microcosm graphic * added responsive styles to graphic
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
==========================================
- Coverage 93.33% 93.11% -0.22%
==========================================
Files 30 30
Lines 1065 1061 -4
Branches 199 201 +2
==========================================
- Hits 994 988 -6
Misses 60 60
- Partials 11 13 +2
Continue to review full report at Codecov.
|
This PR worked on images and font colors:
index.json