Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor images, change heading colors on scroll #464

Merged
merged 8 commits into from
Jan 9, 2018

Conversation

ccchwang
Copy link

@ccchwang ccchwang commented Jan 5, 2018

This PR worked on images and font colors:

  • refactored how we pull in images using the Gatsby way of importing them
  • added info for the rest of the sections in index.json
  • added corresponding colors for the rest of the sections
  • added scss to change the color of headings/subheadings/buttons on scroll


&::after {
content: ''
}
}
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

below are just placeholder images that I'll swap out in another PR

@ccchwang ccchwang requested a review from leobauza January 5, 2018 17:34
@ccchwang
Copy link
Author

ccchwang commented Jan 5, 2018

@leobauza the CI website test is failing again but I think that's okay according to @nhunzaker?

@nhunzaker
Copy link
Contributor

Pretty strange. Let's not worry about it. I wish I knew what was up tho :(

Copy link
Contributor

@nhunzaker nhunzaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These graphics are so great :)

@ccchwang
Copy link
Author

ccchwang commented Jan 8, 2018

@nhunzaker yeah, it sometimes works and sometimes doesn't so I wonder if it's a CI thing? anyways, will keep moving

@ccchwang ccchwang changed the title Ch/images font color refactor images, change font colors Jan 8, 2018
@ccchwang ccchwang changed the title refactor images, change font colors refactor images, change heading colors on scroll Jan 8, 2018
Copy link
Contributor

@leobauza leobauza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src={
microcosmView ? `/${section}-microcosm.png` : `/${section}-browser.png`
}
alt="TODO"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll replace all the alt="TODO" at the end

Chloe Hwang added 2 commits January 9, 2018 11:38
* added icons to button, minified images, changed way we switch text on btn

* ran yarn format

* add intro and conclusion sections (#466)
* laying out structure of browser graphic

* tweaked browser graphic and refactored to its own component

* ran yarn format

* ran yarn format

* made change to json

* make it so that intro/conclusion only shows microcosm graphic

* added responsive styles to graphic
@codecov-io
Copy link

Codecov Report

Merging #464 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   93.33%   93.11%   -0.22%     
==========================================
  Files          30       30              
  Lines        1065     1061       -4     
  Branches      199      201       +2     
==========================================
- Hits          994      988       -6     
  Misses         60       60              
- Partials       11       13       +2
Impacted Files Coverage Δ
packages/microcosm/src/domain-engine.js 80.88% <0%> (-17.65%) ⬇️
packages/microcosm/src/microcosm.js 93.39% <0%> (-5.67%) ⬇️
packages/microcosm/src/addons/action-form.js
packages/microcosm/src/addons/indexing.js 100% <0%> (ø)
packages/microcosm/src/history.js 77.27% <0%> (+0.75%) ⬆️
packages/microcosm/src/utils.js 95.89% <0%> (+1.36%) ⬆️
packages/microcosm/src/addons/action-button.js 100% <0%> (+3.12%) ⬆️
packages/microcosm/src/action.js 98.29% <0%> (+4.27%) ⬆️
packages/microcosm/src/key-path.js 85.71% <0%> (+7.14%) ⬆️
packages/microcosm/src/effect-engine.js 100% <0%> (+11.11%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659a17d...b28f2f8. Read the comment docs.

@ccchwang ccchwang merged commit 76f25e6 into master Jan 9, 2018
@ccchwang ccchwang deleted the ch/images-fontColor branch January 9, 2018 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants