Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch/browser graphic #467

Merged
merged 8 commits into from
Jan 9, 2018
Merged

Ch/browser graphic #467

merged 8 commits into from
Jan 9, 2018

Conversation

ccchwang
Copy link

@ccchwang ccchwang commented Jan 9, 2018

Created the graphic that shows for the "Browser View". All sections share variations of the same graphic. It's very simple so I just used HTML/CSS. That should help reduce the number of images to be loaded.

Desktop
screen shot 2018-01-09 at 12 55 59 pm

Mobile
screen shot 2018-01-09 at 12 56 11 pm

@codecov-io
Copy link

codecov-io commented Jan 9, 2018

Codecov Report

Merging #467 into ch/images-fontColor will increase coverage by 2.73%.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           ch/images-fontColor     #467      +/-   ##
=======================================================
+ Coverage                93.11%   95.85%   +2.73%     
=======================================================
  Files                       30       30              
  Lines                     1061     1061              
  Branches                   201      201              
=======================================================
+ Hits                       988     1017      +29     
+ Misses                      60       37      -23     
+ Partials                    13        7       -6
Impacted Files Coverage Δ
packages/microcosm/src/action.js 93.16% <0%> (-5.13%) ⬇️
packages/microcosm/src/utils.js 98.63% <0%> (+2.73%) ⬆️
packages/microcosm/src/microcosm.js 100% <0%> (+6.6%) ⬆️
packages/microcosm/src/addons/action-queue.js 100% <0%> (+6.66%) ⬆️
packages/microcosm/src/history.js 87.12% <0%> (+9.84%) ⬆️
packages/microcosm/src/domain-engine.js 98.52% <0%> (+17.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b4c54...83fa0cf. Read the comment docs.

@ccchwang ccchwang requested a review from leobauza January 9, 2018 18:02
Copy link
Contributor

@leobauza leobauza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ccchwang ccchwang merged commit b28f2f8 into ch/images-fontColor Jan 9, 2018
ccchwang pushed a commit that referenced this pull request Jan 9, 2018
* refactored how we pull in images using gatsby docs

* color for text and buttons change on scroll

* added all dummy text. refactored how colors change

* refactored color loops in scss

* small tweaks

* ran yarn format

* add icons, minify images (#465)

* add intro and conclusion sections (#466)

* add browser graphic (#467)
@ccchwang ccchwang deleted the ch/browserGraphic branch January 9, 2018 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants