add icons, minify images #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ch/images-fontColor #465 +/- ##
=======================================================
+ Coverage 93.8% 94.92% +1.12%
=======================================================
Files 29 30 +1
Lines 1033 1065 +32
Branches 195 199 +4
=======================================================
+ Hits 969 1011 +42
+ Misses 54 47 -7
+ Partials 10 7 -3
Continue to review full report at Codecov.
|
ccchwang
commented
Jan 8, 2018
|
|
||
| &.-top { | ||
| &::after { | ||
| content: ' Microcosm'; |
There was a problem hiding this comment.
now this text switching is all happening inside pages/index.js
|
Question about images in general. Since this is so image heavy how are you handling preloading or lazy loading or anything like that? |
|
@leobauza yes very good thought, I will think about and find a solution for that |
* added intro and conclusion sections, refactored some color and naming conventions * ran yarn format * tweaked json
ccchwang
pushed a commit
that referenced
this pull request
Jan 9, 2018
* refactored how we pull in images using gatsby docs * color for text and buttons change on scroll * added all dummy text. refactored how colors change * refactored color loops in scss * small tweaks * ran yarn format * add icons, minify images (#465) * add intro and conclusion sections (#466) * add browser graphic (#467)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToggleContainerinto it's own React component